public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: grinberg@compulab•co.il (Igor Grinberg)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/2] ARM: dts: imx7d: cl-som-imx7: add basic module support
Date: Tue, 22 Dec 2015 16:07:51 +0200	[thread overview]
Message-ID: <56795937.6090903@compulab.co.il> (raw)
In-Reply-To: <20151222121718.GB26290@tiger>

Hi Shawn,

On 12/22/15 14:17, Shawn Guo wrote:
> On Tue, Dec 22, 2015 at 10:15:19AM +0200, Ilya Ledvich wrote:

[...]

>> +/ {
>> +	model = "CompuLab CL-SOM-iMX7";
>> +	compatible = "compulab,cl-som-imx7", "fsl,imx7d";
>> +
>> +	memory {
>> +		reg = <0x80000000 0x10000000>; /* 256 MB - minimal configuration */
>> +	};
>> +
>> +	regulators {
>> +		compatible = "simple-bus";
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
> 
> DT maintainers dislike this fake "simple-bus" container, and we were
> asked to put fixed regulator directly under root.  I fixed it up like
> below:
> 
> 	reg_usb_otg1_vbus: regulator-vbus {
> 		compatible = "regulator-fixed";
> 		regulator-name = "usb_otg1_vbus";
> 		regulator-min-microvolt = <5000000>;
> 		regulator-max-microvolt = <5000000>;
> 		gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>;
> 		enable-active-high;
> 	};
> 

Looks good! Thanks for adjusting this.

[...]

-- 
Regards,
Igor.

  reply	other threads:[~2015-12-22 14:07 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07  7:14 [PATCH 0/8] Add support for CL-SOM-iMX7 and SBC-iMX7 Ilya Ledvich
2015-12-07  7:14 ` [PATCH 1/8] ARM: dts: imx7d: cl-som-imx7: add basic module support Ilya Ledvich
2015-12-08 15:14   ` Rob Herring
2015-12-10 14:01     ` [PATCH v2] " Igor Grinberg
2015-12-14  2:43       ` Shawn Guo
2015-12-16 14:01         ` Igor Grinberg
2015-12-21  6:36           ` Shawn Guo
2015-12-21  8:07             ` Igor Grinberg
2015-12-21 13:54               ` Shawn Guo
2015-12-21 13:59               ` Shawn Guo
2015-12-22  7:38                 ` Igor Grinberg
2015-12-07  7:14 ` [PATCH 2/8] ARM: dts: imx7d: cl-som-imx7: add usb otg support Ilya Ledvich
2015-12-07  7:14 ` [PATCH 3/8] ARM: dts: imx7d: cl-som-imx7: add eMMC support Ilya Ledvich
2015-12-07  7:14 ` [PATCH 4/8] ARM: dts: imx7d: cl-som-imx7: add fec1 support Ilya Ledvich
2015-12-07  7:14 ` [PATCH 5/8] ARM: dts: imx7d: cl-som-imx7: add eeprom support Ilya Ledvich
2015-12-07  7:14 ` [PATCH 6/8] ARM: dts: imx7d: cl-som-imx7: add gpio extender support Ilya Ledvich
2015-12-07  7:14 ` [PATCH 7/8] ARM: dts: imx7d: cl-som-imx7: add fec2 support Ilya Ledvich
2015-12-07  7:14 ` [PATCH 8/8] ARM: dts: imx7d: sbc-imx7: add basic board support Ilya Ledvich
2015-12-08 15:16   ` Rob Herring
2015-12-14  2:47 ` [PATCH 0/8] Add support for CL-SOM-iMX7 and SBC-iMX7 Shawn Guo
2015-12-16 14:09   ` Igor Grinberg
2015-12-21  6:41     ` Shawn Guo
2015-12-21  7:54       ` Igor Grinberg
2015-12-22  8:15 ` [PATCH v2 0/2] " Ilya Ledvich
2015-12-22  8:15   ` [PATCH v2 1/2] ARM: dts: imx7d: cl-som-imx7: add basic module support Ilya Ledvich
2015-12-22 12:17     ` Shawn Guo
2015-12-22 14:07       ` Igor Grinberg [this message]
2015-12-22  8:15   ` [PATCH v2 2/2] ARM: dts: imx7d: sbc-imx7: add basic board support Ilya Ledvich
2015-12-22 12:19     ` Shawn Guo
2015-12-22 14:13       ` Igor Grinberg
2015-12-22 12:13   ` [PATCH v2 0/2] Add support for CL-SOM-iMX7 and SBC-iMX7 Shawn Guo
2015-12-22 14:14     ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56795937.6090903@compulab.co.il \
    --to=grinberg@compulab$(echo .)co.il \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox