From: tn@semihalf•com (Tomasz Nowicki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 00/23] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI
Date: Mon, 21 Dec 2015 11:37:31 +0100 [thread overview]
Message-ID: <5677D66B.2070909@semihalf.com> (raw)
In-Reply-To: <4bccc2de7668dde04436ac9c19aac25d.squirrel@www.codeaurora.org>
On 18.12.2015 19:56, okaya at codeaurora.org wrote:
>> On 17.12.2015 22:24, Sinan Kaya wrote:
>>> Hi Tomasz,
>>>
>>> On 12/16/2015 10:16 AM, Tomasz Nowicki wrote:
>>>> From the functionality point of view this series might be split into
>>>> the
>>>> following logic parts:
>>>> 1. Make MMCONFIG code arch-agnostic which allows all architectures to
>>>> collect
>>>> PCI config regions and used when necessary.
>>>> 2. Move non-arch specific bits to the core code.
>>>> 3. Use MMCONFIG code and implement generic ACPI based PCI host
>>>> controller driver.
>>>> 4. Enable above driver on ARM64
>>>>
>>>> Patches has been built on top of 4.4-rc4 and can be found here:
>>>> git at github.com:semihalf-nowicki-tomasz/linux.git (pci-acpi-v2)
>>>>
>>>> NOTE, this patch set depends on Matthew's patches:
>>>> http://www.spinics.net/lists/linux-pci/msg45950.html
>>>> https://github.com/Vality/linux/tree/pci-fixes
>>>>
>>>> This has been tested on Cavium ThunderX 1 socket server and QEMU.
>>>> Any help in reviewing and testing is very appreciated.
>>>>
>>>> v1 -> v2
>>>> - moved non-arch specific piece of code to dirver/acpi/ directory
>>>> - fixed IO resource handling
>>>> - introduced PCI config accessors quirks matching
>>>> - moved ACPI_COMPANION_SET to generic code
>>>>
>>>
>>> Just tested your series. I'm seeing a resource assignment problem below.
>>> The bus addresses show as memory addresses and memory addresses show as
>>> bus addresses and IO resource did not show up.
>>>
>>>
>>> Tomasz V2
>>>
>>> [ 2.520852] ACPI: PCI Interrupt Link [LN1C] (IRQs *238)
>>> [ 2.535472] ACPI: PCI Interrupt Link [LN1D] (IRQs *239)
>>> [ 2.550562] ACPI: PCI Root Bridge [PCI2] (domain 0002 [bus 00-1f])
>>> [ 2.567813] acpi PNP0A08:02: _OSC: OS supports [ExtendedConfig ASPM
>>> ClockPM Segments MSI]
>>> [ 2.591270] acpi PNP0A08:02: _OSC: platform does not support
>>> [PCIeHotplug]
>>> [ 2.611144] acpi PNP0A08:02: _OSC: OS now controls [PME AER
>>> PCIeCapability]
>>> [ 2.630299] ACPI: IORT: can't find node related to (null) device
>>> [ 2.647184]_acpi_PNP0A08:02:_PCI_host_bridge_to_bus_0002:00
>>> [ 2.662663] pci_bus 0002:00: root bus resource [mem
>>> 0x00100000-0x3fffffff window] (bus address
>>> [0xfffff5ff00100000-0xfffff5ff3fffffff])
>>> [ 2.703561] pci_bus 0002:00: root bus resource [mem
>>> 0x40000000-0x7fffffff window] (bus address
>>> [0xfffff5fe80000000-0xfffff5febfffffff])
>>> [ 2.737737] pci_bus 0002:00: root bus resource [mem
>>> 0x80000000-0xffffffff window] (bus address
>>> [0xfffff5fe00000000-0xfffff5fe7fffffff])
>>> [ 2.794961] pci_bus 0002:00: root bus resource [bus 00-1f]
>>>
>>> Mark Salter's patches
>>>
>>> [ 2.730011] ACPI: PCI Interrupt Link [LN1C] (IRQs *238)
>>> [ 2.744648] ACPI: PCI Interrupt Link [LN1D] (IRQs *239)
>>> [ 2.759330] ACPI: PCI Root Bridge [PCI2] (domain 0002 [bus 00-1f])
>>> [ 2.783295] acpi PNP0A08:02: _OSC: OS supports [ExtendedConfig ASPM
>>> ClockPM Segments MSI]
>>> [ 2.806726] acpi PNP0A08:02: _OSC: platform does not support
>>> [PCIeHotplug]
>>> [ 2.826005] acpi PNP0A08:02: _OSC: OS now controls [PME AER
>>> PCIeCapability]
>>> [ 2.845361] PCI host bridge to bus 0002:00
>>> [ 2.856719]_pci_bus_0002:00:_root_bus_resource_[bus_00-1f]
>>> [ 2.872056] pci_bus 0002:00: root bus resource [mem
>>> 0xa0100100000-0xa013fffffff] (bus address [0x00100000-0x3fffffff])
>>> [ 2.902008] pci_bus 0002:00: root bus resource [mem
>>> 0xa0200000000-0xa023fffffff] (bus address [0x40000000-0x7fffffff])
>>> [ 2.932396] pci_bus 0002:00: root bus resource [mem
>>> 0xa0300000000-0xa037fffffff] (bus address [0x80000000-0xffffffff])
>>> [ 2.983827] pci_bus 0002:00: root bus resource [io 0x0000-0xffff]
>>>
>>> Here is how the ACPI table looks like:
>>>
>>> QWORDMemory( // Consumed-And-prodced resource(all of memory space)
>>> ResourceProducer, // bit 0 of general flags is 0
>>> PosDecode, // positive Decode: _DEC
>>> MinFixed, // Range is fixed: _MIF
>>> MaxFixed, // Range is fixed: _MAF
>>> NonCacheable, // _MEM
>>> ReadWrite, // _RW
>>> 0x00000000, // Granularity: _GRA
>>> 0x00100000, // Min - PCI Memory start: _MIN
>>> 0x3FFFFFFF, // Max - PCI Memory end: _MAX
>>> 0xA0100000000, // Translation: _TRA
>>> 0x3FF00000, // Range Length: _LEN
>>> , // Optional field left blank
>>> , // Optional field left blank
>>> MEM0, // Name declaration for this descriptor
>>> AddressRangeMemory,
>>> TypeStatic
>>> )
>>>
>>>
>>> Any thoughts?
>>>
>>>
>>
>> Yes, this is because of:
>> [PATCH V2 20/23] ACPI, PCI: Refine the way to handle translation_offset
>> for ACPI resources
>> which should have RFC tag. I posted this patch to re-trigger discussion
>> on this.
>>
>> The patch does not add Translation offset to the MMIO type resource
>> start address and for acpi_pci_probe_root_resources(ci) causes problems
>> like that. Indeed MMIO has to be fixed.
>
> OK. I assume you'll post a patch for this soon similar to what Liu Jiang
> is doing in IA64 directory (arch/ia64/pci/pci.c) as I can't proceed with
> my testing without this bugfix.
>>
>> But IO resource type is more problematic. Actually, how
>> acpi_decode_space() should parse resources and which ACPI IO descriptor
>> should be used for ARM64: QWORDIO (offset == 0 vs offset != 0), DWordIO
>> (TypeStatic vs TypeTranslation) + backward compatibility with IA64...
>>
>> Please refer to:
>> https://lkml.org/lkml/2015/11/5/581
>>
>> As Lorenzo pointed out, we *all* need to agree upon the IO resource ACPI
>> descriptor and its parsing method.
>
> Here is what I have as an IO resource.
>
> QWORDIO( //Consumed-And-produced resource
> ResourceProducer, // bit 0 of general flags is 0
> MinFixed, // Range is fixed
> MaxFixed, // Range is fixed
> PosDecode,
> EntireRange,
> 0x0000, // Granularity
> 0x1000, // Min, 0 is not accepted
> 0x10FFF, // Max
> 0x8FFFFFEF000, // Translation
> 0x10000, // Range Length
> ,, PI00
> )
>
> I don't have any type specified.
>
> I agree with Lorenzo's assessment. The min and max values represent the
> PCI IO bus addresses. The translation offset is added to these values to
> figure out the CPU view of the PCI IO range.
>
> The endpoints BAR addresses are programmed with IO addresses ranging
> between 0x1000 and 0x10FFF for this example above.
>
> Here is another question. Chris Covington and I asked this question on a
> private email to you but we didn't hear back.
I have not seen any mails like that in my mail box, unless you sent it
to linaro one, which is not accessible for me any more. Please use @semihalf
>
> We were referring to a Linaro IO hack patch as we were not sure whether
> this was a limitation of the hack or a general expectation for ARM64 PCI
> in general.
>
> I'll repeat it here.
>
> I have multiple root ports with the same IO port configuration in the
> current ACPI table.
>
> Root port 0 = IO range 0x1000-0x10FFF
> Root port 1 = IO range 0x1000-0x10FFF
> Root port 2 = IO range 0x1000-0x10FFF
>
> Each root port can have the same IO address range configuration, are we
> expecting IO port numbers to be unique across the whole system for ARM64?
Looking at pci_register_io_range which is currently used on ARM64 I
would say, no you can't have the same CPU addressable IO ranges.
pci_register_io_range does not allow to use regions which overlap each
other.
Bjorn, Arnd, Will, any opinion on this apart from current code restrictions?
Tomasz
next prev parent reply other threads:[~2015-12-21 10:37 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 15:16 [PATCH V2 00/23] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 01/23] x86, pci: Reorder logic of pci_mmconfig_insert() function Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 02/23] x86, pci, acpi: Move arch-agnostic MMCONFIG (aka ECAM) and ACPI code out of arch/x86/ directory Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 03/23] pci, acpi, mcfg: Provide generic implementation of MCFG code initialization Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 04/23] x86, pci: mmconfig_{32, 64}.c code refactoring - remove code duplication Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 05/23] x86, pci, ecam: mmconfig_64.c becomes default implementation for ECAM driver Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 06/23] XEN / PCI: Remove the dependence on arch x86 when PCI_MMCONFIG=y Tomasz Nowicki
2015-12-17 10:25 ` Tomasz Nowicki
2015-12-17 10:40 ` Tomasz Nowicki
2015-12-21 18:12 ` Stefano Stabellini
2015-12-22 8:34 ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 07/23] pci, acpi, mcfg: Provide default RAW ACPI PCI config space accessors Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 08/23] arm64, acpi: Use empty PCI config space accessors from mcfg.c file Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 09/23] pci, acpi, ecam: Add flag to indicate whether ECAM region was hot added or not Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 10/23] x86, pci: Cleanup platform specific MCFG data using previously added ECAM hot_added flag Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 11/23] arm64, pci: Remove useless boot time IRQ assignment when booting with DT Tomasz Nowicki
2016-01-12 13:50 ` Lorenzo Pieralisi
2016-01-12 16:13 ` Tomasz Nowicki
2016-01-12 17:56 ` David Daney
2016-01-13 9:43 ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 12/23] pci, acpi: Move ACPI host bridge device companion assignment to core code Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 13/23] x86, ia64, pci: Remove ACPI companion device from platform specific data Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 14/23] pci, acpi: Provide generic way to assign bus domain number Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 15/23] x86, ia64, pci: Convert arches to use PCI_DOMAINS_GENERIC Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 16/23] x86, ia64: Include acpi_pci_{add|remove}_bus to the default pcibios_{add|remove}_bus implementation Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 17/23] acpi, mcfg: Implement two calls that might be used to inject/remove MCFG region Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 18/23] x86, acpi, pci: Use equivalent function introduced in previous patch Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 19/23] acpi, mcfg: Add default PCI config accessors implementation and initial support for related quirks Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 20/23] ACPI, PCI: Refine the way to handle translation_offset for ACPI resources Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 21/23] pci, acpi: Support for ACPI based PCI hostbridge init Tomasz Nowicki
2015-12-18 12:40 ` Arnd Bergmann
2015-12-21 10:21 ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 22/23] pci, acpi: Match PCI config space accessors against platfrom specific quirks Tomasz Nowicki
2015-12-21 11:47 ` Gabriele Paoloni
2015-12-21 14:10 ` Arnd Bergmann
2015-12-21 17:29 ` David Daney
2015-12-21 22:42 ` Arnd Bergmann
2015-12-21 23:24 ` Jon Masters
2015-12-21 23:10 ` Jon Masters
2015-12-22 8:45 ` Tomasz Nowicki
2015-12-22 9:29 ` Gabriele Paoloni
2015-12-22 16:36 ` Jon Masters
2015-12-22 16:45 ` Jon Masters
2015-12-22 17:49 ` Gabriele Paoloni
2015-12-22 10:20 ` Tomasz Nowicki
2015-12-22 14:48 ` Gabriele Paoloni
2015-12-23 9:38 ` Hanjun Guo
2016-01-08 14:16 ` Mark Salter
2016-01-08 14:36 ` Tomasz Nowicki
2016-01-08 14:51 ` Mark Salter
2016-01-08 14:42 ` Jeremy Linton
2016-01-08 15:01 ` Mark Rutland
2016-01-08 15:12 ` Mark Rutland
2016-01-08 16:07 ` Mark Salter
2015-12-16 15:16 ` [PATCH V2 23/23] arm64, pci, acpi: Start using ACPI based PCI host bridge driver for ARM64 Tomasz Nowicki
2015-12-17 21:24 ` [PATCH V2 00/23] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI Sinan Kaya
2015-12-18 12:26 ` Tomasz Nowicki
2015-12-18 18:56 ` okaya at codeaurora.org
2015-12-21 10:37 ` Tomasz Nowicki [this message]
2015-12-21 12:10 ` Lorenzo Pieralisi
2015-12-21 12:42 ` Tomasz Nowicki
2015-12-21 14:15 ` Arnd Bergmann
2015-12-21 15:26 ` Okaya at codeaurora.org
2015-12-21 22:39 ` Arnd Bergmann
2016-01-11 15:39 ` Lorenzo Pieralisi
2016-01-11 15:56 ` Sinan Kaya
2016-01-12 14:30 ` Arnd Bergmann
2016-01-12 18:38 ` Lorenzo Pieralisi
2016-01-12 21:37 ` Arnd Bergmann
2016-01-11 16:09 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5677D66B.2070909@semihalf.com \
--to=tn@semihalf$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox