From: tn@semihalf•com (Tomasz Nowicki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 11/23] arm64, pci: Remove useless boot time IRQ assignment when booting with DT.
Date: Wed, 13 Jan 2016 10:43:07 +0100 [thread overview]
Message-ID: <56961C2B.3030600@semihalf.com> (raw)
In-Reply-To: <56953E33.6030003@caviumnetworks.com>
On 12.01.2016 18:56, David Daney wrote:
> On 01/12/2016 08:13 AM, Tomasz Nowicki wrote:
>> On 12.01.2016 14:50, Lorenzo Pieralisi wrote:
>>> On Wed, Dec 16, 2015 at 04:16:21PM +0100, Tomasz Nowicki wrote:
>>>> In order to probe PCIe host controller when booting with DT,
>>>> ARM64 is using drivers which defer IRQ assignment to device
>>>> enable time. It means that boot time DT specific irq map initialization
>>>> is always overridden, so lets remove that code.
>>>>
>>>> Signed-off-by: Tomasz Nowicki <tn@semihalf•com>
>>>> ---
>>>> arch/arm64/kernel/pci.c | 10 ----------
>>>> 1 file changed, 10 deletions(-)
>>>>
>>>> diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c
>>>> index 023b983..f7948f5 100644
>>>> --- a/arch/arm64/kernel/pci.c
>>>> +++ b/arch/arm64/kernel/pci.c
>>>> @@ -51,16 +51,6 @@ int pcibios_enable_device(struct pci_dev *dev, int
>>>> mask)
>>>> return pci_enable_resources(dev, mask);
>>>> }
>>>>
>>>> -/*
>>>> - * Try to assign the IRQ number from DT when adding a new device
>>>> - */
>>>> -int pcibios_add_device(struct pci_dev *dev)
>>>> -{
>>>> - dev->irq = of_irq_parse_and_map_pci(dev, 0, 0);
>>>> -
>>>> - return 0;
>>>> -}
>>>> -
>
> How was this tested? Or in other words, what PCI devices that use
> legacy INT{A,B,C,D} interrupts were used in testing this patch?
>
I used QEMU and e1000 NIC:
sudo ./qemu/aarch64-softmmu/qemu-system-aarch64 -smp 1 -m 1024 -M virt
-cpu cortex-a57 -nographic -device
e1000,netdev=net1,mac=52:54:00:12:34:56 -netdev
type=tap,ifname=tun1,id=net1,script=no,downscript=no -drive
file=qemu/ubuntu.img,id=root,if=none,format=raw -device
virtio-blk-device,drive=root -kernel linux-aarch64/arch/arm64/boot/Image
-append "console=ttyAMA0 earlycon=pl011,0x9000000 rw root=/dev/vda"
root at ubuntu:~# ifconfig
eth0 Link encap:Ethernet HWaddr 52:54:00:12:34:56
inet addr:10.0.0.48 Bcast:10.0.255.255 Mask:255.255.0.0
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:107 errors:0 dropped:0 overruns:0 frame:0
TX packets:32 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:18087 (18.0 KB) TX bytes:3818 (3.8 KB)
root at ubuntu:~# cat /proc/interrupts
CPU0
39: 280 GIC 36 Level eth0
root at ubuntu:~# lspci -vvv
00:00.0 Host bridge: Red Hat, Inc. Device 0008
Subsystem: Red Hat, Inc Device 1100
Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B- DisINTx-
Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
00:01.0 Ethernet controller: Intel Corporation 82540EM Gigabit Ethernet
Controller (rev 03)
Subsystem: Red Hat, Inc QEMU Virtual Machine
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B- DisINTx-
Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 0
Interrupt: pin A routed to IRQ 39
Region 0: Memory at 10040000 (32-bit, non-prefetchable) [size=128K]
Region 1: I/O ports at 1000 [size=64]
[virtual] Expansion ROM@10000000 [disabled] [size=256K]
Kernel driver in use: e1000
Any specific concern w.r.t. this patch?
Tomasz
next prev parent reply other threads:[~2016-01-13 9:43 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 15:16 [PATCH V2 00/23] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 01/23] x86, pci: Reorder logic of pci_mmconfig_insert() function Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 02/23] x86, pci, acpi: Move arch-agnostic MMCONFIG (aka ECAM) and ACPI code out of arch/x86/ directory Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 03/23] pci, acpi, mcfg: Provide generic implementation of MCFG code initialization Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 04/23] x86, pci: mmconfig_{32, 64}.c code refactoring - remove code duplication Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 05/23] x86, pci, ecam: mmconfig_64.c becomes default implementation for ECAM driver Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 06/23] XEN / PCI: Remove the dependence on arch x86 when PCI_MMCONFIG=y Tomasz Nowicki
2015-12-17 10:25 ` Tomasz Nowicki
2015-12-17 10:40 ` Tomasz Nowicki
2015-12-21 18:12 ` Stefano Stabellini
2015-12-22 8:34 ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 07/23] pci, acpi, mcfg: Provide default RAW ACPI PCI config space accessors Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 08/23] arm64, acpi: Use empty PCI config space accessors from mcfg.c file Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 09/23] pci, acpi, ecam: Add flag to indicate whether ECAM region was hot added or not Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 10/23] x86, pci: Cleanup platform specific MCFG data using previously added ECAM hot_added flag Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 11/23] arm64, pci: Remove useless boot time IRQ assignment when booting with DT Tomasz Nowicki
2016-01-12 13:50 ` Lorenzo Pieralisi
2016-01-12 16:13 ` Tomasz Nowicki
2016-01-12 17:56 ` David Daney
2016-01-13 9:43 ` Tomasz Nowicki [this message]
2015-12-16 15:16 ` [PATCH V2 12/23] pci, acpi: Move ACPI host bridge device companion assignment to core code Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 13/23] x86, ia64, pci: Remove ACPI companion device from platform specific data Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 14/23] pci, acpi: Provide generic way to assign bus domain number Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 15/23] x86, ia64, pci: Convert arches to use PCI_DOMAINS_GENERIC Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 16/23] x86, ia64: Include acpi_pci_{add|remove}_bus to the default pcibios_{add|remove}_bus implementation Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 17/23] acpi, mcfg: Implement two calls that might be used to inject/remove MCFG region Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 18/23] x86, acpi, pci: Use equivalent function introduced in previous patch Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 19/23] acpi, mcfg: Add default PCI config accessors implementation and initial support for related quirks Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 20/23] ACPI, PCI: Refine the way to handle translation_offset for ACPI resources Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 21/23] pci, acpi: Support for ACPI based PCI hostbridge init Tomasz Nowicki
2015-12-18 12:40 ` Arnd Bergmann
2015-12-21 10:21 ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 22/23] pci, acpi: Match PCI config space accessors against platfrom specific quirks Tomasz Nowicki
2015-12-21 11:47 ` Gabriele Paoloni
2015-12-21 14:10 ` Arnd Bergmann
2015-12-21 17:29 ` David Daney
2015-12-21 22:42 ` Arnd Bergmann
2015-12-21 23:24 ` Jon Masters
2015-12-21 23:10 ` Jon Masters
2015-12-22 8:45 ` Tomasz Nowicki
2015-12-22 9:29 ` Gabriele Paoloni
2015-12-22 16:36 ` Jon Masters
2015-12-22 16:45 ` Jon Masters
2015-12-22 17:49 ` Gabriele Paoloni
2015-12-22 10:20 ` Tomasz Nowicki
2015-12-22 14:48 ` Gabriele Paoloni
2015-12-23 9:38 ` Hanjun Guo
2016-01-08 14:16 ` Mark Salter
2016-01-08 14:36 ` Tomasz Nowicki
2016-01-08 14:51 ` Mark Salter
2016-01-08 14:42 ` Jeremy Linton
2016-01-08 15:01 ` Mark Rutland
2016-01-08 15:12 ` Mark Rutland
2016-01-08 16:07 ` Mark Salter
2015-12-16 15:16 ` [PATCH V2 23/23] arm64, pci, acpi: Start using ACPI based PCI host bridge driver for ARM64 Tomasz Nowicki
2015-12-17 21:24 ` [PATCH V2 00/23] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI Sinan Kaya
2015-12-18 12:26 ` Tomasz Nowicki
2015-12-18 18:56 ` okaya at codeaurora.org
2015-12-21 10:37 ` Tomasz Nowicki
2015-12-21 12:10 ` Lorenzo Pieralisi
2015-12-21 12:42 ` Tomasz Nowicki
2015-12-21 14:15 ` Arnd Bergmann
2015-12-21 15:26 ` Okaya at codeaurora.org
2015-12-21 22:39 ` Arnd Bergmann
2016-01-11 15:39 ` Lorenzo Pieralisi
2016-01-11 15:56 ` Sinan Kaya
2016-01-12 14:30 ` Arnd Bergmann
2016-01-12 18:38 ` Lorenzo Pieralisi
2016-01-12 21:37 ` Arnd Bergmann
2016-01-11 16:09 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56961C2B.3030600@semihalf.com \
--to=tn@semihalf$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox