* [PATCH 1/4] ARM: dts: AM33xx: Add ti, mbox-send-noirq to wkup_m3 mailbox
2015-07-17 21:08 [PATCH 0/4] ARM: dts: am335x/am43xx: wkup_m3_ipc support patches Dave Gerlach
@ 2015-07-17 21:08 ` Dave Gerlach
2015-07-17 21:08 ` [PATCH 2/4] ARM: dts: AM4372: " Dave Gerlach
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Dave Gerlach @ 2015-07-17 21:08 UTC (permalink / raw)
To: linux-arm-kernel
Add ti,mbox-send-noirq to wkup_m3 mailbox so that messages using
wkup_m3 mailbox are sent without triggering any further interrupts.
This is needed to achieve lower power numbers during CPU idle on
AM33xx.
Signed-off-by: Dave Gerlach <d-gerlach@ti•com>
[s-anna at ti.com: revise commit description]
Signed-off-by: Suman Anna <s-anna@ti•com>
---
arch/arm/boot/dts/am33xx.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 4c1b4a8..4f2c07a 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -391,6 +391,7 @@
ti,mbox-num-users = <4>;
ti,mbox-num-fifos = <8>;
mbox_wkupm3: wkup_m3 {
+ ti,mbox-send-noirq;
ti,mbox-tx = <0 0 0>;
ti,mbox-rx = <0 0 3>;
};
--
2.4.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/4] ARM: dts: AM4372: Add ti, mbox-send-noirq to wkup_m3 mailbox
2015-07-17 21:08 [PATCH 0/4] ARM: dts: am335x/am43xx: wkup_m3_ipc support patches Dave Gerlach
2015-07-17 21:08 ` [PATCH 1/4] ARM: dts: AM33xx: Add ti, mbox-send-noirq to wkup_m3 mailbox Dave Gerlach
@ 2015-07-17 21:08 ` Dave Gerlach
2015-07-17 21:08 ` [PATCH 3/4] ARM: dts: AM33xx: Add the wkup_m3_ipc node Dave Gerlach
2015-07-17 21:08 ` [PATCH 4/4] ARM: dts: AM4372: " Dave Gerlach
3 siblings, 0 replies; 8+ messages in thread
From: Dave Gerlach @ 2015-07-17 21:08 UTC (permalink / raw)
To: linux-arm-kernel
From: Keerthy <j-keerthy@ti•com>
Add ti,mbox-send-noirq to wkup_m3 mailbox so that messages using
wkup_m3 mailbox are sent without triggering any further interrupts.
This is required to be able to send multiple messages to the WkupM3
after the mailbox usage logic adjustment in the wkup_m3_ipc driver.
Signed-off-by: Keerthy <j-keerthy@ti•com>
Acked-by: Dave Gerlach <d-gerlach@ti•com>
[s-anna at ti.com: revise commit description]
Signed-off-by: Suman Anna <s-anna@ti•com>
---
arch/arm/boot/dts/am4372.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index 6f6f393..5bccc48 100644
--- a/arch/arm/boot/dts/am4372.dtsi
+++ b/arch/arm/boot/dts/am4372.dtsi
@@ -214,6 +214,7 @@
ti,mbox-num-users = <4>;
ti,mbox-num-fifos = <8>;
mbox_wkupm3: wkup_m3 {
+ ti,mbox-send-noirq;
ti,mbox-tx = <0 0 0>;
ti,mbox-rx = <0 0 3>;
};
--
2.4.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 3/4] ARM: dts: AM33xx: Add the wkup_m3_ipc node
2015-07-17 21:08 [PATCH 0/4] ARM: dts: am335x/am43xx: wkup_m3_ipc support patches Dave Gerlach
2015-07-17 21:08 ` [PATCH 1/4] ARM: dts: AM33xx: Add ti, mbox-send-noirq to wkup_m3 mailbox Dave Gerlach
2015-07-17 21:08 ` [PATCH 2/4] ARM: dts: AM4372: " Dave Gerlach
@ 2015-07-17 21:08 ` Dave Gerlach
2015-07-17 21:08 ` [PATCH 4/4] ARM: dts: AM4372: " Dave Gerlach
3 siblings, 0 replies; 8+ messages in thread
From: Dave Gerlach @ 2015-07-17 21:08 UTC (permalink / raw)
To: linux-arm-kernel
From: Suman Anna <s-anna@ti•com>
Add the Wakeup M3 IPC node for the wkup_m3_ipc driver on AM33xx SoCs.
This node uses the IPC registers, part of the Control Module, and is
therefore added as a child of the scm node.
Signed-off-by: Suman Anna <s-anna@ti•com>
Signed-off-by: Dave Gerlach <d-gerlach@ti•com>
---
arch/arm/boot/dts/am33xx.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 4f2c07a..13f097f 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -153,6 +153,14 @@
};
};
+ wkup_m3_ipc: wkup_m3_ipc at 1324 {
+ compatible = "ti,am3352-wkup-m3-ipc";
+ reg = <0x1324 0x24>;
+ interrupts = <78>;
+ ti,rproc = <&wkup_m3>;
+ mboxes = <&mailbox &mbox_wkupm3>;
+ };
+
scm_clockdomains: clockdomains {
};
};
--
2.4.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 4/4] ARM: dts: AM4372: Add the wkup_m3_ipc node
2015-07-17 21:08 [PATCH 0/4] ARM: dts: am335x/am43xx: wkup_m3_ipc support patches Dave Gerlach
` (2 preceding siblings ...)
2015-07-17 21:08 ` [PATCH 3/4] ARM: dts: AM33xx: Add the wkup_m3_ipc node Dave Gerlach
@ 2015-07-17 21:08 ` Dave Gerlach
2015-08-05 10:31 ` Tony Lindgren
3 siblings, 1 reply; 8+ messages in thread
From: Dave Gerlach @ 2015-07-17 21:08 UTC (permalink / raw)
To: linux-arm-kernel
From: Suman Anna <s-anna@ti•com>
Add the Wakeup M3 IPC device node for the wkup_m3_ipc driver on
AM4372 SoC. This node uses the IPC registers, part of the Control
Module, and is therefore added as a child of the scm node.
Signed-off-by: Suman Anna <s-anna@ti•com>
Signed-off-by: Dave Gerlach <d-gerlach@ti•com>
---
arch/arm/boot/dts/am4372.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index 5bccc48..45bcd1b 100644
--- a/arch/arm/boot/dts/am4372.dtsi
+++ b/arch/arm/boot/dts/am4372.dtsi
@@ -136,6 +136,14 @@
};
};
+ wkup_m3_ipc: wkup_m3_ipc at 1324 {
+ compatible = "ti,am4372-wkup-m3-ipc";
+ reg = <0x1324 0x44>;
+ interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
+ ti,rproc = <&wkup_m3>;
+ mboxes = <&mailbox &mbox_wkupm3>;
+ };
+
scm_clockdomains: clockdomains {
};
};
--
2.4.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 4/4] ARM: dts: AM4372: Add the wkup_m3_ipc node
2015-07-17 21:08 ` [PATCH 4/4] ARM: dts: AM4372: " Dave Gerlach
@ 2015-08-05 10:31 ` Tony Lindgren
2016-01-18 20:17 ` Dave Gerlach
0 siblings, 1 reply; 8+ messages in thread
From: Tony Lindgren @ 2015-08-05 10:31 UTC (permalink / raw)
To: linux-arm-kernel
* Dave Gerlach <d-gerlach@ti•com> [150717 14:10]:
> From: Suman Anna <s-anna@ti•com>
>
> Add the Wakeup M3 IPC device node for the wkup_m3_ipc driver on
> AM4372 SoC. This node uses the IPC registers, part of the Control
> Module, and is therefore added as a child of the scm node.
Applying the last two patches in this series into omap-for-v4.3/dt
thanks.
Probably the send-no-irq quirk you can do in the driver based
on the compatible flag like I suggested in the related mailbox
thread so not applying those until that's been discussed.
Regards,
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 4/4] ARM: dts: AM4372: Add the wkup_m3_ipc node
2015-08-05 10:31 ` Tony Lindgren
@ 2016-01-18 20:17 ` Dave Gerlach
2016-01-21 21:55 ` Tony Lindgren
0 siblings, 1 reply; 8+ messages in thread
From: Dave Gerlach @ 2016-01-18 20:17 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tony,
On 08/05/2015 05:31 AM, Tony Lindgren wrote:
> * Dave Gerlach <d-gerlach@ti•com> [150717 14:10]:
>> From: Suman Anna <s-anna@ti•com>
>>
>> Add the Wakeup M3 IPC device node for the wkup_m3_ipc driver on
>> AM4372 SoC. This node uses the IPC registers, part of the Control
>> Module, and is therefore added as a child of the scm node.
>
> Applying the last two patches in this series into omap-for-v4.3/dt
> thanks.
>
> Probably the send-no-irq quirk you can do in the driver based
> on the compatible flag like I suggested in the related mailbox
> thread so not applying those until that's been discussed.
Now that this compatible flag for the mbox driver has been accepted
here: 8e3c5952144f ("mailbox/omap: Add ti,mbox-send-noirq quirk to fix
AM33xx CPU Idle") can the first two patches in this series get picked
up. I tested applying to v4.4 and they still apply cleanly.
Regards,
Dave
>
> Regards,
>
> Tony
>
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 4/4] ARM: dts: AM4372: Add the wkup_m3_ipc node
2016-01-18 20:17 ` Dave Gerlach
@ 2016-01-21 21:55 ` Tony Lindgren
0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2016-01-21 21:55 UTC (permalink / raw)
To: linux-arm-kernel
* Dave Gerlach <d-gerlach@ti•com> [160118 12:18]:
> Hi Tony,
> On 08/05/2015 05:31 AM, Tony Lindgren wrote:
> >* Dave Gerlach <d-gerlach@ti•com> [150717 14:10]:
> >>From: Suman Anna <s-anna@ti•com>
> >>
> >>Add the Wakeup M3 IPC device node for the wkup_m3_ipc driver on
> >>AM4372 SoC. This node uses the IPC registers, part of the Control
> >>Module, and is therefore added as a child of the scm node.
> >
> >Applying the last two patches in this series into omap-for-v4.3/dt
> >thanks.
> >
> >Probably the send-no-irq quirk you can do in the driver based
> >on the compatible flag like I suggested in the related mailbox
> >thread so not applying those until that's been discussed.
>
> Now that this compatible flag for the mbox driver has been accepted here:
> 8e3c5952144f ("mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU
> Idle") can the first two patches in this series get picked up. I tested
> applying to v4.4 and they still apply cleanly.
OK applying into omap-for-v4.5/fixes thanks.
Regards,
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread