From: ddaney@caviumnetworks•com (David Daney)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v12 3/5] dt, numa: Add NUMA dt binding implementation.
Date: Mon, 29 Feb 2016 10:13:48 -0800 [thread overview]
Message-ID: <56D48A5C.6040709@caviumnetworks.com> (raw)
In-Reply-To: <20160229172956.GF31343@rric.localdomain>
On 02/29/2016 09:29 AM, Robert Richter wrote:
> On 22.02.16 17:58:21, David Daney wrote:
>> From: Ganapatrao Kulkarni <gkulkarni@caviumnetworks•com>
>>
>> ADD device tree node parsing for NUMA topology using device
>> "numa-node-id" property distance-map.
>>
>> Reviewed-by: Robert Richter <rrichter@cavium•com>
>> Signed-off-by: Ganapatrao Kulkarni <gkulkarni@caviumnetworks•com>
>> Signed-off-by: David Daney <david.daney@cavium•com>
>> ---
>> drivers/of/Kconfig | 3 +
>> drivers/of/Makefile | 1 +
>> drivers/of/of_numa.c | 211 +++++++++++++++++++++++++++++++++++++++++++++++++++
>> include/linux/of.h | 9 +++
>> 4 files changed, 224 insertions(+)
>> create mode 100644 drivers/of/of_numa.c
>>
>> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
>> index e2a4841..b3bec3a 100644
>> --- a/drivers/of/Kconfig
>> +++ b/drivers/of/Kconfig
>> @@ -112,4 +112,7 @@ config OF_OVERLAY
>> While this option is selected automatically when needed, you can
>> enable it manually to improve device tree unit test coverage.
>>
>> +config OF_NUMA
>
> In arch/arm64/Kconfig you now need to:
>
> select OF_NUMA if NUMA && OF
>
> This should depend here on OF and NUMA and enabled in that case. Why
> moving that to arch code?
The dependency on of_numa.o is in the architecture specific code, so
that is where the Kconfig select should be too.
For new code, we try to avoid putting architecture specific things into
the core Kconfig files.
Since arm64 is the only architecture that is currently using this, we
don't want to select it for non-arm64 kernels that happen to select NUMA
&& OF.
I will restore the depends, as it is guard against errors in the
architecture specific Kconfig select statements, but I am going to leave
the NUMA && OF in the arm64/Kconfig for clarity.
> This duplicates code as the same needs to be
> implemented for every arch.
>
Better to duplicate a single Kconfig select statement a few times in
architecture specific Kconfig files, than force people to continuously
modify the depends in drivers/of/Kconfig
David.
next prev parent reply other threads:[~2016-02-29 18:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 1:58 [PATCH v12 0/5] arm64, numa: Add numa support for arm64 platforms David Daney
2016-02-23 1:58 ` [PATCH v12 1/5] efi: ARM/arm64: ignore DT memory nodes instead of removing them David Daney
2016-02-23 11:58 ` Mark Rutland
2016-02-23 12:16 ` Will Deacon
2016-02-23 12:20 ` Ard Biesheuvel
2016-02-23 22:12 ` Rob Herring
2016-02-24 19:38 ` Mark Rutland
2016-02-24 19:03 ` Frank Rowand
2016-02-24 19:30 ` Rob Herring
2016-02-24 19:33 ` Mark Rutland
2016-02-23 1:58 ` [PATCH v12 2/5] Documentation, dt, numa: dt bindings for NUMA David Daney
2016-02-23 1:58 ` [PATCH v12 3/5] dt, numa: Add NUMA dt binding implementation David Daney
2016-02-29 17:29 ` Robert Richter
2016-02-29 18:13 ` David Daney [this message]
2016-02-29 19:45 ` Robert Richter
2016-02-29 22:56 ` David Daney
2016-02-23 1:58 ` [PATCH v12 4/5] arm64, numa: Add NUMA support for arm64 platforms David Daney
2016-02-23 10:26 ` Will Deacon
2016-02-23 17:34 ` David Daney
2016-02-23 17:39 ` David Daney
2016-02-26 18:53 ` Will Deacon
2016-02-26 19:51 ` David Daney
2016-02-27 4:13 ` Ganapatrao Kulkarni
2016-02-29 10:12 ` Robert Richter
2016-02-29 17:34 ` Robert Richter
2016-02-29 23:42 ` David Daney
2016-03-01 12:21 ` Robert Richter
2016-02-23 1:58 ` [PATCH v12 5/5] arm64, mm, numa: Add NUMA balancing support for arm64 David Daney
2016-02-26 18:53 ` Will Deacon
2016-02-26 19:26 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D48A5C.6040709@caviumnetworks.com \
--to=ddaney@caviumnetworks$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox