From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt
Date: Fri, 4 Mar 2016 16:37:19 +0300 [thread overview]
Message-ID: <56D98F8F.5010700@cogentembedded.com> (raw)
In-Reply-To: <1457053798-93513-4-git-send-email-huangdaode@hisilicon.com>
Hello.
On 3/4/2016 4:09 AM, Daode Huang wrote:
> In V2 chip, when sending mamagement packets, the driver should
> config the port id to BD descs.
>
> Signed-off-by: Daode Huang <huangdaode@hisilicon•com>
> Signed-off-by: Lisheng <lisheng011@huawei•com>
> ---
> drivers/net/ethernet/hisilicon/hns/hnae.h | 3 +++
> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 1 +
> drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++++
> 3 files changed, 8 insertions(+)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.h b/drivers/net/ethernet/hisilicon/hns/hnae.h
> index 1cbcb9f..11a3f97 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hnae.h
> +++ b/drivers/net/ethernet/hisilicon/hns/hnae.h
[...]
> @@ -516,6 +518,7 @@ struct hnae_handle {
> int q_num;
> int vf_id;
> u32 eport_id;
> + u32 dport_id; /*v2 tx bd should fill the dport_id*/
Please add spaces after /* and before */ (like it's done in other places
in this driver).
[...]
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> index 6250a42..b45dcc2 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> @@ -69,6 +69,10 @@ static void fill_v2_desc(struct hnae_ring *ring, void *priv,
> hnae_set_bit(rrcfv, HNSV2_TXD_VLD_B, 1);
> hnae_set_field(bn_pid, HNSV2_TXD_BUFNUM_M, 0, buf_num - 1);
>
> + /*fill port_id in the tx bd for sending management pkts*/
Likewise.
> + hnae_set_field(bn_pid, HNSV2_TXD_PORTID_M,
> + HNSV2_TXD_PORTID_S, ring->q->handle->dport_id);
> +
> if (type == DESC_TYPE_SKB) {
> skb = (struct sk_buff *)priv;
>
MBR, Sergei
next prev parent reply other threads:[~2016-03-04 13:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 1:09 [PATCH net 0/6]net: hns: hns driver updates Daode Huang
2016-03-04 0:55 ` Daode Huang
2016-03-04 1:09 ` [PATCH net 1/6] net: hns: bug fix about the overflow of mss Daode Huang
2016-03-04 1:09 ` [PATCH net 2/6] net: hns: fixes the hw interrupt bug in using napi Daode Huang
2016-03-04 1:09 ` [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt Daode Huang
2016-03-04 13:37 ` Sergei Shtylyov [this message]
2016-03-11 1:53 ` Daode Huang
2016-03-11 13:29 ` Sergei Shtylyov
2016-03-14 0:45 ` Daode Huang
2016-03-04 1:09 ` [PATCH net 4/6] net: hns: adds uc match for debug port Daode Huang
2016-03-04 13:39 ` Sergei Shtylyov
2016-03-11 1:58 ` Daode Huang
2016-03-04 1:09 ` [PATCH net 5/6] net: hns: fixed service-ges setting MAC-addr bug Daode Huang
2016-03-04 1:09 ` [PATCH net 6/6] net: hns: bug fix of getting hilink status Daode Huang
-- strict thread matches above, loose matches on Subject: below --
2016-03-04 3:05 [PATCH net 0/6]net: hns: hns driver updates Daode Huang
2016-03-04 3:05 ` [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt Daode Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D98F8F.5010700@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox