From: huangdaode@hisilicon•com (Daode Huang)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH net 4/6] net: hns: adds uc match for debug port
Date: Fri, 11 Mar 2016 09:58:41 +0800 [thread overview]
Message-ID: <56E22651.3030903@hisilicon.com> (raw)
In-Reply-To: <56D99007.6090804@cogentembedded.com>
On 2016/3/4 21:39, Sergei Shtylyov wrote:
> On 3/4/2016 4:09 AM, Daode Huang wrote:
>
>> This patch adds uc match for debug port by:
>> 1)Enables uc match of debug port when initializing gmac
>> 2)Enables uc match of mac address register2
>>
>> Signed-off-by: Daode Huang <huangdaode@hisilicon•com>
>> Signed-off-by: lipeng <lipeng321@huawei•com>
>
Lipeng is his full name. i will change it to another style (Peng Li
<lipeng321@huawei•com>)
> True/full name is required here.
>
>> ---
>> drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 18
>> +++++++++++++++++-
>> drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h | 2 ++
>> 2 files changed, 19 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c
>> b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c
>> index b8517b0..2591a51 100644
>> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c
>> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c
> [...]
>> @@ -407,8 +419,12 @@ static void hns_gmac_set_mac_addr(void *mac_drv,
>> char *mac_addr)
>>
>> u32 low_val = mac_addr[5] | (mac_addr[4] << 8)
>> | (mac_addr[3] << 16) | (mac_addr[2] << 24);
>> +
>> + u32 val = dsaf_read_dev(drv, GMAC_STATION_ADDR_HIGH_2_REG);
>> + u32 sta_addr_en = dsaf_get_bit(val, GMAC_ADDR_EN_B);
>
> Empty line needed after declarations.
>
agree,
thanks
Daode.
>> dsaf_write_dev(drv, GMAC_STATION_ADDR_LOW_2_REG, low_val);
>> - dsaf_write_dev(drv, GMAC_STATION_ADDR_HIGH_2_REG, high_val);
>> + dsaf_write_dev(drv, GMAC_STATION_ADDR_HIGH_2_REG,
>> + high_val | (sta_addr_en << GMAC_ADDR_EN_B));
>> }
>> }
>>
> [...]
>
> MBR, Sergei
>
>
> .
>
next prev parent reply other threads:[~2016-03-11 1:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 1:09 [PATCH net 0/6]net: hns: hns driver updates Daode Huang
2016-03-04 0:55 ` Daode Huang
2016-03-04 1:09 ` [PATCH net 1/6] net: hns: bug fix about the overflow of mss Daode Huang
2016-03-04 1:09 ` [PATCH net 2/6] net: hns: fixes the hw interrupt bug in using napi Daode Huang
2016-03-04 1:09 ` [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt Daode Huang
2016-03-04 13:37 ` Sergei Shtylyov
2016-03-11 1:53 ` Daode Huang
2016-03-11 13:29 ` Sergei Shtylyov
2016-03-14 0:45 ` Daode Huang
2016-03-04 1:09 ` [PATCH net 4/6] net: hns: adds uc match for debug port Daode Huang
2016-03-04 13:39 ` Sergei Shtylyov
2016-03-11 1:58 ` Daode Huang [this message]
2016-03-04 1:09 ` [PATCH net 5/6] net: hns: fixed service-ges setting MAC-addr bug Daode Huang
2016-03-04 1:09 ` [PATCH net 6/6] net: hns: bug fix of getting hilink status Daode Huang
-- strict thread matches above, loose matches on Subject: below --
2016-03-04 3:05 [PATCH net 0/6]net: hns: hns driver updates Daode Huang
2016-03-04 3:05 ` [PATCH net 4/6] net: hns: adds uc match for debug port Daode Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E22651.3030903@hisilicon.com \
--to=huangdaode@hisilicon$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox