* [PATCH v2 0/2] set specific ddr frequency when stop ddr dvfs @ 2016-11-03 6:16 Lin Huang 2016-11-03 6:16 ` [PATCH v2 1/2] PM/devfreq: add suspend frequency support Lin Huang 2016-11-03 6:16 ` [PATCH v2 2/2] PM/devfreq: rk3399: set specific ddr frequency when stop ddr dvfs Lin Huang 0 siblings, 2 replies; 5+ messages in thread From: Lin Huang @ 2016-11-03 6:16 UTC (permalink / raw) To: linux-arm-kernel We need ddr run a specific frequency when ddr dvfs stop working. So we implement get suspend frequency function in devfreq framework, and call it in rk3399 dmc driver. Lin Huang (2): PM/devfreq: add suspend frequency support PM/devfreq: rk3399: set specific ddr frequency when stop ddr dvfs drivers/devfreq/devfreq.c | 17 ++++++++++++++++- drivers/devfreq/rk3399_dmc.c | 2 +- include/linux/devfreq.h | 9 +++++++++ 3 files changed, 26 insertions(+), 2 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] PM/devfreq: add suspend frequency support 2016-11-03 6:16 [PATCH v2 0/2] set specific ddr frequency when stop ddr dvfs Lin Huang @ 2016-11-03 6:16 ` Lin Huang 2016-11-03 6:36 ` hl 2016-11-03 14:41 ` kbuild test robot 2016-11-03 6:16 ` [PATCH v2 2/2] PM/devfreq: rk3399: set specific ddr frequency when stop ddr dvfs Lin Huang 1 sibling, 2 replies; 5+ messages in thread From: Lin Huang @ 2016-11-03 6:16 UTC (permalink / raw) To: linux-arm-kernel Add suspend frequency support and if needed set it to the frequency obtained from the suspend opp (can be defined using opp-v2 bindings and is optional). Change-Id: Iaa0d3848d63d9ce03f65ea76f263e4685a4c295e Signed-off-by: Lin Huang <hl@rock-chips•com> --- Changes in v2: - use update_devfreq() instead devfreq_update_status() drivers/devfreq/devfreq.c | 17 ++++++++++++++++- include/linux/devfreq.h | 9 +++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index bf3ea76..0a76282 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -364,7 +364,10 @@ void devfreq_monitor_suspend(struct devfreq *devfreq) return; } - devfreq_update_status(devfreq, devfreq->previous_freq); + if (devfreq->suspend_freq) + update_devfreq(devfreq, devfreq->suspend_freq); + else + devfreq_update_status(devfreq, devfreq->previous_freq); devfreq->stop_polling = true; mutex_unlock(&devfreq->lock); cancel_delayed_work_sync(&devfreq->work); @@ -1251,6 +1254,18 @@ struct dev_pm_opp *devfreq_recommended_opp(struct device *dev, } EXPORT_SYMBOL(devfreq_recommended_opp); +void devfreq_opp_get_suspend_opp(struct device *dev, struct devfreq *devfreq) +{ + struct dev_pm_opp *suspend_opp; + + rcu_read_lock(); + suspend_opp = dev_pm_opp_get_suspend_opp(dev); + if (suspend_opp) + devfreq->suspend_freq = dev_pm_opp_get_freq(suspend_opp); + rcu_read_unlock(); +} +EXPORT_SYMBOL(devfreq_opp_get_suspend_opp); + /** * devfreq_register_opp_notifier() - Helper function to get devfreq notified * for any changes in the OPP availability diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h index 2de4e2e..c785ad9 100644 --- a/include/linux/devfreq.h +++ b/include/linux/devfreq.h @@ -88,6 +88,7 @@ struct devfreq_dev_status { */ struct devfreq_dev_profile { unsigned long initial_freq; + unsigned long suspend_freq; unsigned int polling_ms; int (*target)(struct device *dev, unsigned long *freq, u32 flags); @@ -172,6 +173,7 @@ struct devfreq { struct delayed_work work; unsigned long previous_freq; + unsigned long suspend_freq; struct devfreq_dev_status last_status; void *data; /* private data for governors */ @@ -214,6 +216,8 @@ extern void devm_devfreq_remove_device(struct device *dev, /* Helper functions for devfreq user device driver with OPP. */ extern struct dev_pm_opp *devfreq_recommended_opp(struct device *dev, unsigned long *freq, u32 flags); +extern void devfreq_opp_get_suspend_opp(struct device *dev, + struct devfreq *devfreq); extern int devfreq_register_opp_notifier(struct device *dev, struct devfreq *devfreq); extern int devfreq_unregister_opp_notifier(struct device *dev, @@ -348,6 +352,11 @@ static inline struct dev_pm_opp *devfreq_recommended_opp(struct device *dev, return ERR_PTR(-EINVAL); } +static inline void devfreq_opp_get_suspend_opp(struct device *dev, + struct devfreq *devfreq) +{ +} + static inline int devfreq_register_opp_notifier(struct device *dev, struct devfreq *devfreq) { -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] PM/devfreq: add suspend frequency support 2016-11-03 6:16 ` [PATCH v2 1/2] PM/devfreq: add suspend frequency support Lin Huang @ 2016-11-03 6:36 ` hl 2016-11-03 14:41 ` kbuild test robot 1 sibling, 0 replies; 5+ messages in thread From: hl @ 2016-11-03 6:36 UTC (permalink / raw) To: linux-arm-kernel Hi All, Miss something in this patch, just ignored it, sorry about that. On 2016?11?03? 14:16, Lin Huang wrote: > Add suspend frequency support and if needed set it to > the frequency obtained from the suspend opp (can be defined > using opp-v2 bindings and is optional). > > Change-Id: Iaa0d3848d63d9ce03f65ea76f263e4685a4c295e > Signed-off-by: Lin Huang <hl@rock-chips•com> > --- > Changes in v2: > - use update_devfreq() instead devfreq_update_status() > > drivers/devfreq/devfreq.c | 17 ++++++++++++++++- > include/linux/devfreq.h | 9 +++++++++ > 2 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index bf3ea76..0a76282 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -364,7 +364,10 @@ void devfreq_monitor_suspend(struct devfreq *devfreq) > return; > } > > - devfreq_update_status(devfreq, devfreq->previous_freq); > + if (devfreq->suspend_freq) > + update_devfreq(devfreq, devfreq->suspend_freq); > + else > + devfreq_update_status(devfreq, devfreq->previous_freq); > devfreq->stop_polling = true; > mutex_unlock(&devfreq->lock); > cancel_delayed_work_sync(&devfreq->work); > @@ -1251,6 +1254,18 @@ struct dev_pm_opp *devfreq_recommended_opp(struct device *dev, > } > EXPORT_SYMBOL(devfreq_recommended_opp); > > +void devfreq_opp_get_suspend_opp(struct device *dev, struct devfreq *devfreq) > +{ > + struct dev_pm_opp *suspend_opp; > + > + rcu_read_lock(); > + suspend_opp = dev_pm_opp_get_suspend_opp(dev); > + if (suspend_opp) > + devfreq->suspend_freq = dev_pm_opp_get_freq(suspend_opp); > + rcu_read_unlock(); > +} > +EXPORT_SYMBOL(devfreq_opp_get_suspend_opp); > + > /** > * devfreq_register_opp_notifier() - Helper function to get devfreq notified > * for any changes in the OPP availability > diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h > index 2de4e2e..c785ad9 100644 > --- a/include/linux/devfreq.h > +++ b/include/linux/devfreq.h > @@ -88,6 +88,7 @@ struct devfreq_dev_status { > */ > struct devfreq_dev_profile { > unsigned long initial_freq; > + unsigned long suspend_freq; > unsigned int polling_ms; > > int (*target)(struct device *dev, unsigned long *freq, u32 flags); > @@ -172,6 +173,7 @@ struct devfreq { > struct delayed_work work; > > unsigned long previous_freq; > + unsigned long suspend_freq; > struct devfreq_dev_status last_status; > > void *data; /* private data for governors */ > @@ -214,6 +216,8 @@ extern void devm_devfreq_remove_device(struct device *dev, > /* Helper functions for devfreq user device driver with OPP. */ > extern struct dev_pm_opp *devfreq_recommended_opp(struct device *dev, > unsigned long *freq, u32 flags); > +extern void devfreq_opp_get_suspend_opp(struct device *dev, > + struct devfreq *devfreq); > extern int devfreq_register_opp_notifier(struct device *dev, > struct devfreq *devfreq); > extern int devfreq_unregister_opp_notifier(struct device *dev, > @@ -348,6 +352,11 @@ static inline struct dev_pm_opp *devfreq_recommended_opp(struct device *dev, > return ERR_PTR(-EINVAL); > } > > +static inline void devfreq_opp_get_suspend_opp(struct device *dev, > + struct devfreq *devfreq) > +{ > +} > + > static inline int devfreq_register_opp_notifier(struct device *dev, > struct devfreq *devfreq) > { -- Lin Huang ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] PM/devfreq: add suspend frequency support 2016-11-03 6:16 ` [PATCH v2 1/2] PM/devfreq: add suspend frequency support Lin Huang 2016-11-03 6:36 ` hl @ 2016-11-03 14:41 ` kbuild test robot 1 sibling, 0 replies; 5+ messages in thread From: kbuild test robot @ 2016-11-03 14:41 UTC (permalink / raw) To: linux-arm-kernel Hi Lin, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc3 next-20161028] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Lin-Huang/set-specific-ddr-frequency-when-stop-ddr-dvfs/20161103-142055 config: x86_64-randconfig-x015-201644 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/devfreq/devfreq.c: In function 'devfreq_monitor_suspend': >> drivers/devfreq/devfreq.c:368:3: error: too many arguments to function 'update_devfreq' update_devfreq(devfreq, devfreq->suspend_freq); ^~~~~~~~~~~~~~ drivers/devfreq/devfreq.c:228:5: note: declared here int update_devfreq(struct devfreq *devfreq) ^~~~~~~~~~~~~~ vim +/update_devfreq +368 drivers/devfreq/devfreq.c 362 if (devfreq->stop_polling) { 363 mutex_unlock(&devfreq->lock); 364 return; 365 } 366 367 if (devfreq->suspend_freq) > 368 update_devfreq(devfreq, devfreq->suspend_freq); 369 else 370 devfreq_update_status(devfreq, devfreq->previous_freq); 371 devfreq->stop_polling = true; --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -------------- next part -------------- A non-text attachment was scrubbed... Name: .config.gz Type: application/gzip Size: 23592 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161103/9251898a/attachment-0001.gz> ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] PM/devfreq: rk3399: set specific ddr frequency when stop ddr dvfs 2016-11-03 6:16 [PATCH v2 0/2] set specific ddr frequency when stop ddr dvfs Lin Huang 2016-11-03 6:16 ` [PATCH v2 1/2] PM/devfreq: add suspend frequency support Lin Huang @ 2016-11-03 6:16 ` Lin Huang 1 sibling, 0 replies; 5+ messages in thread From: Lin Huang @ 2016-11-03 6:16 UTC (permalink / raw) To: linux-arm-kernel We need ddr run a specific frequency when ddr dvfs stop working. For example: if we enable two monitor, then we will stop ddr dvfs, but we hope ddr can run in highest frequency obviously. Change-Id: I02460f0becbf0e1a732e2a55b8e529f53c01109c Signed-off-by: Lin Huang <hl@rock-chips•com> --- Changes in v2: - None drivers/devfreq/rk3399_dmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c index e24b73d..9309941 100644 --- a/drivers/devfreq/rk3399_dmc.c +++ b/drivers/devfreq/rk3399_dmc.c @@ -443,7 +443,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) if (IS_ERR(data->devfreq)) return PTR_ERR(data->devfreq); devm_devfreq_register_opp_notifier(dev, data->devfreq); - + devfreq_opp_get_suspend_opp(dev, data->devfreq); data->dev = dev; platform_set_drvdata(pdev, data); -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-03 14:41 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-11-03 6:16 [PATCH v2 0/2] set specific ddr frequency when stop ddr dvfs Lin Huang 2016-11-03 6:16 ` [PATCH v2 1/2] PM/devfreq: add suspend frequency support Lin Huang 2016-11-03 6:36 ` hl 2016-11-03 14:41 ` kbuild test robot 2016-11-03 6:16 ` [PATCH v2 2/2] PM/devfreq: rk3399: set specific ddr frequency when stop ddr dvfs Lin Huang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox