From: Krzysztof Kozlowski <krzk@kernel•org>
To: Arnd Bergmann <arnd@arndb•de>,
Tudor Ambarus <tudor.ambarus@linaro•org>,
Alim Akhtar <alim.akhtar@samsung•com>
Cc: linux-kernel@vger•kernel.org, linux-samsung-soc@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
"Peter Griffin" <peter.griffin@linaro•org>,
"André Draszik" <andre.draszik@linaro•org>,
jyescas@google•com, kernel-team@android•com,
stable@vger•kernel.org
Subject: Re: [PATCH v5 3/7] firmware: samsung: acpm: Fix dummy stubs to return ERR_PTR
Date: Fri, 29 May 2026 14:09:05 +0200 [thread overview]
Message-ID: <6c77d706-5944-4e7d-8a4a-b3a6cac6a83b@kernel.org> (raw)
In-Reply-To: <03dc9ccc-d819-413e-b8fd-23ccd85675ba@app.fastmail.com>
On 29/05/2026 13:51, Arnd Bergmann wrote:
> On Tue, May 5, 2026, at 15:13, Tudor Ambarus wrote:
>> Sashiko identified a potential NULL pointer dereference [1].
>>
>> The dummy stub implementation for devm_acpm_get_by_node() returns NULL
>> when CONFIG_EXYNOS_ACPM_PROTOCOL is disabled.
>
> I meant to comment on this yesterday as well.
>
> Having stub functions like this return NULL is a common way to
> define optional interfaces, where callers still work when the
> feature is disabled, though this clearly does not work for
> acpm because some callers have a NULL pointer dereference
> when compile testing.
>
> My preferred solution to this type of problem would be to
> just remove the stub helpers and drop the ||COMPILE_TEST
> from the one user that calls them, see below.
>
> The point here is that CONFIG_EXYNOS_ACPM_PROTOCOL already
> supports compile-testing itself, and all (both) drivers using
> it clearly require the support, so this just simplifies
> the option space without losing any build coverage.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
>
Sure, I am fine with it. I'll take your patch with a bit adjusted commit
msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-29 12:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 13:12 [PATCH v5 0/7] firmware: samsung: acpm: Various fixes for sashiko bug reports Tudor Ambarus
2026-05-05 13:12 ` [PATCH v5 1/7] firmware: samsung: acpm: Fix cross-thread RX length corruption Tudor Ambarus
2026-05-06 15:17 ` Alexey Klimov
2026-05-14 16:55 ` Krzysztof Kozlowski
2026-05-05 13:12 ` [PATCH v5 2/7] firmware: samsung: acpm: Fix mailbox channel leak on probe error Tudor Ambarus
2026-05-05 13:13 ` [PATCH v5 3/7] firmware: samsung: acpm: Fix dummy stubs to return ERR_PTR Tudor Ambarus
2026-05-29 11:51 ` Arnd Bergmann
2026-05-29 12:09 ` Krzysztof Kozlowski [this message]
2026-05-29 12:37 ` Tudor Ambarus
2026-05-29 13:38 ` Arnd Bergmann
2026-05-05 13:13 ` [PATCH v5 4/7] firmware: samsung: acpm: Add memory barrier before advancing RX pointer Tudor Ambarus
2026-05-28 17:44 ` Arnd Bergmann
2026-05-29 7:47 ` Krzysztof Kozlowski
2026-05-29 8:25 ` Arnd Bergmann
2026-05-29 11:20 ` Tudor Ambarus
2026-05-29 11:44 ` Arnd Bergmann
2026-05-29 12:10 ` Krzysztof Kozlowski
2026-05-05 13:13 ` [PATCH v5 5/7] firmware: samsung: acpm: Fix false timeouts and Use-After-Free in polling Tudor Ambarus
2026-05-05 13:13 ` [PATCH v5 6/7] firmware: samsung: acpm: Fix missing LKMM barriers in sequence allocator Tudor Ambarus
2026-05-05 13:13 ` [PATCH v5 7/7] firmware: samsung: acpm: Fix infinite loop on sequence number exhaustion Tudor Ambarus
2026-05-06 8:29 ` [PATCH v5 0/7] firmware: samsung: acpm: Various fixes for sashiko bug reports Tudor Ambarus
2026-05-14 16:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c77d706-5944-4e7d-8a4a-b3a6cac6a83b@kernel.org \
--to=krzk@kernel$(echo .)org \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=andre.draszik@linaro$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=jyescas@google$(echo .)com \
--cc=kernel-team@android$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=peter.griffin@linaro$(echo .)org \
--cc=stable@vger$(echo .)kernel.org \
--cc=tudor.ambarus@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox