From: "Arnd Bergmann" <arnd@arndb•de>
To: "Tudor Ambarus" <tudor.ambarus@linaro•org>,
"Krzysztof Kozlowski" <krzk@kernel•org>,
"Alim Akhtar" <alim.akhtar@samsung•com>
Cc: linux-kernel@vger•kernel.org, linux-samsung-soc@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
"Peter Griffin" <peter.griffin@linaro•org>,
"André Draszik" <andre.draszik@linaro•org>,
jyescas@google•com, kernel-team@android•com,
stable@vger•kernel.org
Subject: Re: [PATCH v5 3/7] firmware: samsung: acpm: Fix dummy stubs to return ERR_PTR
Date: Fri, 29 May 2026 15:38:28 +0200 [thread overview]
Message-ID: <d6663bd0-178e-46d6-af3a-69b8be197375@app.fastmail.com> (raw)
In-Reply-To: <a7994860-24a3-4f87-84bf-109ed653dda4@linaro.org>
On Fri, May 29, 2026, at 14:37, Tudor Ambarus wrote:
> On 5/29/26 3:09 PM, Krzysztof Kozlowski wrote:
>> On 29/05/2026 13:51, Arnd Bergmann wrote:
>
> I confirm that the ACPM protocol is mandatory for the clients to
> work, thanks!
>
>>> the option space without losing any build coverage.
>
> nice, I didn't know this. I guess it's a "greedy" algorithm in
> allmodconfig, if the dependency is met the dependents are enabled too.
It's not even that interesting I think: the way I understand it,
the values (=m for allmodconfig, random for randconfig) are
assigned first and then adjusted if dependencies are not
met. This means with my change, anything that would have
CONFIG_EXYNOS_ACPM_PROTOCOL=n and CONFIG_EXYNOS_ACPM_CLK=m now
turns off EXYNOS_ACPM_CLK as well, rather than turning on
CONFIG_EXYNOS_ACPM_PROTOCOL, but this still covers all
the combinations we need to test.
>> Sure, I am fine with it. I'll take your patch with a bit adjusted commit
>> msg.
>>
>
> Thank you! I need to drop the devm_acpm_get_by_phandle dummy stub from:
> https://lore.kernel.org/linux-samsung-soc/a59c6e3a-6092-4114-8961-c2a71a812959@kernel.org/T/#m0ac077507129c37b84443513eecadd70b5eaf8b8
>
> Shall I send again the entire set?
I'll just send my change on top of your 8ad2c29d53e6 ("firmware:
samsung: acpm: Add devm_acpm_get_by_phandle helper"). Since there
is no way to hit the actual bug on a running kernel, it can wait for
the merge window, and that way we don't need a rebase.
Arnd
next prev parent reply other threads:[~2026-05-29 13:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 13:12 [PATCH v5 0/7] firmware: samsung: acpm: Various fixes for sashiko bug reports Tudor Ambarus
2026-05-05 13:12 ` [PATCH v5 1/7] firmware: samsung: acpm: Fix cross-thread RX length corruption Tudor Ambarus
2026-05-06 15:17 ` Alexey Klimov
2026-05-14 16:55 ` Krzysztof Kozlowski
2026-05-05 13:12 ` [PATCH v5 2/7] firmware: samsung: acpm: Fix mailbox channel leak on probe error Tudor Ambarus
2026-05-05 13:13 ` [PATCH v5 3/7] firmware: samsung: acpm: Fix dummy stubs to return ERR_PTR Tudor Ambarus
2026-05-29 11:51 ` Arnd Bergmann
2026-05-29 12:09 ` Krzysztof Kozlowski
2026-05-29 12:37 ` Tudor Ambarus
2026-05-29 13:38 ` Arnd Bergmann [this message]
2026-05-05 13:13 ` [PATCH v5 4/7] firmware: samsung: acpm: Add memory barrier before advancing RX pointer Tudor Ambarus
2026-05-28 17:44 ` Arnd Bergmann
2026-05-29 7:47 ` Krzysztof Kozlowski
2026-05-29 8:25 ` Arnd Bergmann
2026-05-29 11:20 ` Tudor Ambarus
2026-05-29 11:44 ` Arnd Bergmann
2026-05-29 12:10 ` Krzysztof Kozlowski
2026-05-05 13:13 ` [PATCH v5 5/7] firmware: samsung: acpm: Fix false timeouts and Use-After-Free in polling Tudor Ambarus
2026-05-05 13:13 ` [PATCH v5 6/7] firmware: samsung: acpm: Fix missing LKMM barriers in sequence allocator Tudor Ambarus
2026-05-05 13:13 ` [PATCH v5 7/7] firmware: samsung: acpm: Fix infinite loop on sequence number exhaustion Tudor Ambarus
2026-05-06 8:29 ` [PATCH v5 0/7] firmware: samsung: acpm: Various fixes for sashiko bug reports Tudor Ambarus
2026-05-14 16:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6663bd0-178e-46d6-af3a-69b8be197375@app.fastmail.com \
--to=arnd@arndb$(echo .)de \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=andre.draszik@linaro$(echo .)org \
--cc=jyescas@google$(echo .)com \
--cc=kernel-team@android$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=peter.griffin@linaro$(echo .)org \
--cc=stable@vger$(echo .)kernel.org \
--cc=tudor.ambarus@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox