From: khilman@kernel•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] PM / Domains: Let the ->attach_dev() callback return an error code
Date: Wed, 29 Oct 2014 14:10:17 -0700 [thread overview]
Message-ID: <7h1tpq7fba.fsf@deeprootsystems.com> (raw)
In-Reply-To: <CAMuHMdVn2mfk5v8MQshU0gko+dL9xtCT_zBuqyntHHrmxjwfSA@mail.gmail.com> (Geert Uytterhoeven's message of "Tue, 28 Oct 2014 21:31:35 +0100")
Geert Uytterhoeven <geert@linux-m68k•org> writes:
> Hi Ulf, Rafael,
>
> On Tue, Oct 28, 2014 at 3:38 PM, Ulf Hansson <ulf.hansson@linaro•org> wrote:
>> Typically an ->attach_dev() callback would fetch some PM resourses.
>>
>> Those operations, like for example clk_get() may fail with different
>> errors, including -EPROBE_DEFER. Instead of ignoring these errors and
>> potentially only print an error message, let's propagate them to give
>> callers the option to handle them.
>>
>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro•org>
>
> Given that several patch series using ->attach_dev() are already floating
> around and will be in -next soon, what is the plan of getting this in?
Shall we take this as a Reviewed-by or Acked-by for the series? :)
> Doing it ASAP (in v3.18-rc3)?
IMO, this isn't at all appropriate for -rc since it's not fixing a
regression. Also, this series includes other cleanups that are not
really fixes either. At this point of the -rc cycle, we need to focus
only on regression fixes.
> Delaying this to v3.19-rc2, which will require an atomic fixing of its users?
> Any other option?
I don't see any users of this in -next yet, so I think doing a simple
patch to the prototype and fixing up any users before they hit -next is
the right approach. Errors will be ignored, but that's not change from
today. :)
Then the rest of this cleanup and behavior change stuff can continue to
be reviewed and get broader testing before merge.
Kevin
next prev parent reply other threads:[~2014-10-29 21:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 14:38 [PATCH 0/4] PM / Domains: Handle errors from ->attach_dev() callback Ulf Hansson
2014-10-28 14:38 ` [PATCH 1/4] PM / Domains: Remove reference counting for the generic_pm_domain_data Ulf Hansson
2014-10-29 20:44 ` Kevin Hilman
2014-10-28 14:38 ` [PATCH 2/4] PM / Domains: Don't allow an existing generic PM domain data Ulf Hansson
2014-10-29 22:28 ` Kevin Hilman
2014-10-28 14:38 ` [PATCH 3/4] PM / Domains: Improve error handling while adding/removing devices Ulf Hansson
2014-10-29 23:53 ` Kevin Hilman
2014-10-30 11:27 ` Ulf Hansson
2014-10-29 23:57 ` Kevin Hilman
2014-10-30 11:25 ` Ulf Hansson
2014-11-05 7:47 ` Geert Uytterhoeven
2014-11-05 8:03 ` Ulf Hansson
2014-10-28 14:38 ` [PATCH 4/4] PM / Domains: Let the ->attach_dev() callback return an error code Ulf Hansson
2014-10-28 20:31 ` Geert Uytterhoeven
2014-10-29 9:26 ` Ulf Hansson
2014-10-29 9:32 ` Geert Uytterhoeven
2014-10-29 10:14 ` Ulf Hansson
2014-10-29 10:28 ` Geert Uytterhoeven
2014-10-29 21:10 ` Kevin Hilman [this message]
2014-10-29 21:18 ` Geert Uytterhoeven
2014-10-30 11:34 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h1tpq7fba.fsf@deeprootsystems.com \
--to=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox