From: khilman@baylibre•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver
Date: Mon, 16 Jul 2018 08:38:29 -0500 [thread overview]
Message-ID: <7hfu0jmhbe.fsf@baylibre.com> (raw)
In-Reply-To: <1531216472.2708.71.camel@baylibre.com> (Jerome Brunet's message of "Tue, 10 Jul 2018 11:54:32 +0200")
Jerome Brunet <jbrunet@baylibre•com> writes:
> On Tue, 2018-07-10 at 09:21 +0800, Yixun Lan wrote:
>>
>> On 07/10/18 05:53, Martin Blumenstingl wrote:
>> > On Mon, Jul 9, 2018 at 1:14 PM Jian Hu <jian.hu@amlogic•com> wrote:
[...]
>> > > +
>> > > +static const struct of_device_id clkc_match_table[] = {
>> > > + { .compatible = "amlogic,g12a-clkc" },
>> >
>> > I wonder if that should be "amlogic,meson-g12a-clkc" (I know that AXG
>> > and GXBB/GXL/GXM omit the "meson-" prefix, but I am not sure if that's
>> > correct - I'll CC Rob Herring on the dt-bindings patch)
>> >
>>
>> we're fine with either way, since the g12a is recently new added SoC.
>>
>> but I guess those old compatibles which already exist won't be changed,
>> as it will break the DT
>
> Yes, I doubt we are going to change the compatibles. With or without the meson
> prefix, I suppose it going to stay that way.
Correct, we will not change existing compatibles. Adding new ones for
clarity is fine though.
> It is worth thinking about it for new drivers though.
> We already have the "amlogic,", so do we really to prefix even more with "meson-
> "
>
> Also, if we were really strict about that scheme, should meson8b compatible be
>
> "amlogic,meson-meson8b-foo-bar" ... the SoC is meson8b, not just 8b after all ?
>
> For the particular case of the clock controller, I don't care very much, as long
> as the compatible is coherent with documentation.
>
> I might have a preference for the current compatible ... just for consistency
> with the other clock controllers.
In hindsight, I think using the "meson" prefix was a mistake. It's
redunant, IMO, but it's how we've been doing things for all the drivers,
except for drivers/clk, which, honestly, I hadn't even noticed until
now.
As Jerome said, I think consistency is an important goal, so leaving off
the "meson-" for drivers/clk is fine with me.
Also for consistency, for the rest of the drivers, keeping "meson-" is
probably the right thing to do.
However, patches would be welcome to add compatibles without the "meson"
for the rest of the drivers & documentation as well, but please do not
remove any compatibles.
Kevin
next prev parent reply other threads:[~2018-07-16 13:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 11:12 [PATCH 0/3] clk: meson-g12a: Add EE clock controller driver Jian Hu
2018-07-09 11:12 ` [PATCH 1/3] dt-bindings: clk: g12a: New binding for Meson-G12A SoC Jian Hu
2018-07-09 21:57 ` Martin Blumenstingl
2018-07-11 8:10 ` Jian Hu
2018-07-10 9:29 ` Jerome Brunet
2018-07-11 13:04 ` Jian Hu
2018-07-14 14:30 ` Martin Blumenstingl
2018-07-09 11:12 ` [PATCH 2/3] dt-bindings: clk: meson-g12a: Add G12A EE Clock Bindings Jian Hu
2018-07-09 22:13 ` Martin Blumenstingl
2018-07-10 9:26 ` Jerome Brunet
2018-07-11 12:53 ` Jian Hu
2018-07-11 8:22 ` Jian Hu
2018-07-09 11:12 ` [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver Jian Hu
2018-07-09 14:58 ` Stephen Boyd
2018-07-11 6:33 ` Jian Hu
2018-07-09 21:53 ` Martin Blumenstingl
2018-07-10 1:21 ` Yixun Lan
2018-07-10 9:54 ` Jerome Brunet
2018-07-10 12:59 ` Yixun Lan
2018-07-10 15:51 ` Jerome Brunet
2018-07-11 13:41 ` Jian Hu
2018-07-11 13:45 ` Jerome Brunet
2018-07-16 5:58 ` Jian Hu
2018-07-16 13:38 ` Kevin Hilman [this message]
2018-07-17 1:24 ` Yixun Lan
2018-07-19 14:06 ` Kevin Hilman
2018-07-19 14:27 ` Yixun Lan
2018-07-19 14:53 ` Kevin Hilman
2018-07-11 8:05 ` Jian Hu
2018-07-16 13:41 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hfu0jmhbe.fsf@baylibre.com \
--to=khilman@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox