From: khilman@baylibre•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver
Date: Thu, 19 Jul 2018 09:53:03 -0500 [thread overview]
Message-ID: <7hk1prmg4w.fsf@baylibre.com> (raw)
In-Reply-To: <e1f0b672-65de-6afa-cec4-e2d910c58b7c@amlogic.com> (Yixun Lan's message of "Thu, 19 Jul 2018 22:27:55 +0800")
Yixun Lan <yixun.lan@amlogic•com> writes:
> On 07/19/2018 10:06 PM, Kevin Hilman wrote:
>> Yixun Lan <yixun.lan@amlogic•com> writes:
>>
>> [...]
>>
>>>>
>>>> As Jerome said, I think consistency is an important goal, so leaving off
>>>> the "meson-" for drivers/clk is fine with me.
>>>>
>>> ok
>>>
>>>> Also for consistency, for the rest of the drivers, keeping "meson-" is
>>>> probably the right thing to do.
>>>>
>>> ok, for the above, you are talking about the already exist compatible
>>> names? or the patches we will push in the future?
>>
>> I'm talking about future patches.
>>
> ok
>
>>>> However, patches would be welcome to add compatibles without the "meson"
>>>> for the rest of the drivers & documentation as well, but please do not
>>>> remove any compatibles.
>>>>
>>> I assume you are talking about the patches in the future we will push?
>>> to drop the "meson".
>>>
>>> I'm confused here, as the above two paragraphs conflict with each other
>>
>> Yeah, what I wrote is confusing, sorry about that.
>>
>> What I mean is that new patches should stay consistent with compatibles
>> in their existing drivers/subsystems. That means keeping the "meson-"
>> prefix for everything except drivers/clk.
>>
> sounds good to me.
>
>> In addition to that, patches would be welcome for *adding* compatibles
>> without "meson" to all the current drivers.
>>
> not sure if I parse above correctly, so let me rephrase..
>
> for "all the current drivers", do you mean all the drivers which already
> accepted at mainline kernel, which are mmc, uart, spi, i2c ..
Yes.
> all of them follow "amlogic,meson-${SOC}-${FUNCTION}", so do you propose
> to add compatbiles like "amlogic,${SOC}-${FUNCTION}" ?
Yes, but that's an optional future cleanup.
> take i2c for example, there is "amlogic,meson-axg-i2c" already, do you
> want to add another "amlogic,axg-i2c" ? I feel this will adding more
> confusion..
Possibly, but it will provide a path to remove the "meson-" prefix in
the future if we would like.
> How about only following the "amlogic,${SOC}-${FUNCTION}" syntax in the
> new added drivers in the future, for example NAND, PCIE driver which we
> want to push (those drivers doesn't exist in current mainline kernel).
For new drivers, it's fine to not use the "meson-" prefix at all.
Kevin
next prev parent reply other threads:[~2018-07-19 14:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 11:12 [PATCH 0/3] clk: meson-g12a: Add EE clock controller driver Jian Hu
2018-07-09 11:12 ` [PATCH 1/3] dt-bindings: clk: g12a: New binding for Meson-G12A SoC Jian Hu
2018-07-09 21:57 ` Martin Blumenstingl
2018-07-11 8:10 ` Jian Hu
2018-07-10 9:29 ` Jerome Brunet
2018-07-11 13:04 ` Jian Hu
2018-07-14 14:30 ` Martin Blumenstingl
2018-07-09 11:12 ` [PATCH 2/3] dt-bindings: clk: meson-g12a: Add G12A EE Clock Bindings Jian Hu
2018-07-09 22:13 ` Martin Blumenstingl
2018-07-10 9:26 ` Jerome Brunet
2018-07-11 12:53 ` Jian Hu
2018-07-11 8:22 ` Jian Hu
2018-07-09 11:12 ` [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver Jian Hu
2018-07-09 14:58 ` Stephen Boyd
2018-07-11 6:33 ` Jian Hu
2018-07-09 21:53 ` Martin Blumenstingl
2018-07-10 1:21 ` Yixun Lan
2018-07-10 9:54 ` Jerome Brunet
2018-07-10 12:59 ` Yixun Lan
2018-07-10 15:51 ` Jerome Brunet
2018-07-11 13:41 ` Jian Hu
2018-07-11 13:45 ` Jerome Brunet
2018-07-16 5:58 ` Jian Hu
2018-07-16 13:38 ` Kevin Hilman
2018-07-17 1:24 ` Yixun Lan
2018-07-19 14:06 ` Kevin Hilman
2018-07-19 14:27 ` Yixun Lan
2018-07-19 14:53 ` Kevin Hilman [this message]
2018-07-11 8:05 ` Jian Hu
2018-07-16 13:41 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hk1prmg4w.fsf@baylibre.com \
--to=khilman@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox