From: khilman@kernel•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 0/2] clk: improve handling of orphan clocks
Date: Wed, 13 May 2015 07:33:54 -0700 [thread overview]
Message-ID: <7hiobw8s31.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20150513130304.GA4004@lukather> (Maxime Ripard's message of "Wed, 13 May 2015 15:03:04 +0200")
Maxime Ripard <maxime.ripard@free-electrons•com> writes:
> On Tue, May 12, 2015 at 03:35:50PM -0700, Stephen Boyd wrote:
>> On 05/08/15 03:02, Maxime Ripard wrote:
>> > On Thu, May 07, 2015 at 02:03:57PM -0700, Stephen Boyd wrote:
>> >> On 05/07/15 08:17, Kevin Hilman wrote:
>> >>> On Fri, May 1, 2015 at 4:40 PM, Stephen Boyd <sboyd@codeaurora•org> wrote:
>> >>>> On 05/01/15 15:07, Heiko St?bner wrote:
>> >>>>> Am Freitag, 1. Mai 2015, 13:52:47 schrieb Stephen Boyd:
>> >>>>>
>> >>>>>>> Instead I guess we could hook it less deep into clk_get_sys, like in the
>> >>>>>>> following patch?
>> >>>>>> It looks like it will work at least, but still I'd prefer to keep the
>> >>>>>> orphan check contained to clk.c. How about this compile tested only patch?
>> >>>>> I gave this a spin on my rk3288-firefly board. It still boots, the clock tree
>> >>>>> looks the same and it also still defers nicely in the scenario I needed it
>> >>>>> for. The implementation also looks nice - and of course much more compact than
>> >>>>> my check in two places :-) . I don't know if you want to put this as follow-up
>> >>>>> on top or fold it into the original orphan-check, so in any case
>> >>>>>
>> >>>>> Tested-by: Heiko Stuebner <heiko@sntech•de>
>> >>>>> Reviewed-by: Heiko Stuebner <heiko@sntech•de>
>> >>>> Thanks. I'm leaning towards tossing your patch 2/2 and replacing it with
>> >>>> my patch and a note that it's based on an earlier patch from you.
>> >>> It appears this has landed in linux-next in the form of 882667c1fcf1
>> >>> clk: prevent orphan clocks from being used. A bunch of boot failures
>> >>> for sunxi in today's linux-next[1] were bisected down to that patch.
>> >>>
>> >>> I confirmed that reverting that commit on top of next/master gets
>> >>> sunxi booting again.
>> >>>
>> >>>
>> >> Thanks for the report. I've removed the two clk orphan patches from
>> >> clk-next. Would it be possible to try with next-20150507 and
>> >> clk_ignore_unused on the command line?
>> > This makes it work, but it's not really an option.
>> >
>>
>> Hmm.. I thought it didn't fix it for Kevin. Confused.
>
> I'm too, but it does fix things here.
To be more precise on what I tested. I used next-20150507 and tested on
4 different sunxi platforms. First test was "normal" commandline,
second was with clk_ignore_unused appended:
- cubie: fail, fail
- cubie2: fail, fail
- bananpi: fail, pass
- cubietruck: fail, pass
So it seems to have some effect, but by itself, doesn't fix the issue.
Kevin
next prev parent reply other threads:[~2015-05-13 14:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 20:53 [PATCH v3 0/2] clk: improve handling of orphan clocks Heiko Stuebner
2015-04-22 20:53 ` [PATCH v3 1/2] clk: track the orphan status of clocks and their children Heiko Stuebner
2015-04-30 23:20 ` Stephen Boyd
2015-04-22 20:53 ` [PATCH v3 2/2] clk: prevent orphan clocks from being used Heiko Stuebner
2015-04-30 23:20 ` Stephen Boyd
2015-04-25 12:23 ` [PATCH v3 0/2] clk: improve handling of orphan clocks Stefan Wahren
2015-04-25 13:44 ` Heiko Stübner
2015-04-26 19:58 ` Robert Jarzmik
2015-05-01 0:19 ` Stephen Boyd
2015-05-01 19:59 ` Heiko Stübner
2015-05-01 20:52 ` Stephen Boyd
2015-05-01 22:07 ` Heiko Stübner
2015-05-01 23:40 ` Stephen Boyd
2015-05-07 8:22 ` Tero Kristo
2015-05-07 18:18 ` Stephen Boyd
2015-05-08 11:41 ` Tero Kristo
2015-05-07 15:17 ` Kevin Hilman
2015-05-07 21:03 ` Stephen Boyd
2015-05-08 0:27 ` Kevin Hilman
2015-05-08 6:53 ` Stephen Boyd
2015-05-08 8:13 ` Sascha Hauer
2015-05-08 9:30 ` Heiko Stübner
2015-05-08 9:53 ` Sascha Hauer
2015-05-08 10:02 ` Maxime Ripard
2015-05-12 22:35 ` Stephen Boyd
2015-05-13 13:03 ` Maxime Ripard
2015-05-13 14:33 ` Kevin Hilman [this message]
2015-05-13 20:14 ` Maxime Ripard
2015-05-13 20:44 ` Kevin Hilman
2015-05-13 20:51 ` Maxime Ripard
2015-07-27 8:57 ` Heiko Stübner
2015-07-30 10:09 ` Maxime Ripard
2015-08-11 22:34 ` Stephen Boyd
2015-08-12 8:26 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hiobw8s31.fsf@deeprootsystems.com \
--to=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox