* [PATCH 2/2] arm64: meson: remove MESON_IRQ_GPIO selection
2020-10-20 7:25 [PATCH 0/2] irq-meson-gpio: make it possible to build as a module Neil Armstrong
@ 2020-10-20 7:25 ` Neil Armstrong
2020-10-20 23:18 ` Kevin Hilman
0 siblings, 1 reply; 9+ messages in thread
From: Neil Armstrong @ 2020-10-20 7:25 UTC (permalink / raw)
To: maz
Cc: Neil Armstrong, khilman, linux-kernel, linux-amlogic,
linux-arm-kernel, jbrunet
Selecting MESON_IRQ_GPIO forces it as built-in, but we may need to build it
as a module, thus remove it here and let the "default ARCH_MESON" build as
built-in by default with the option to switch it to module.
Signed-off-by: Neil Armstrong <narmstrong@baylibre•com>
---
arch/arm64/Kconfig.platforms | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index cd58f8495c45..dfb66917f665 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -157,7 +157,6 @@ config ARCH_MESON
select COMMON_CLK_GXBB
select COMMON_CLK_AXG
select COMMON_CLK_G12A
- select MESON_IRQ_GPIO
help
This enables support for the arm64 based Amlogic SoCs
such as the s905, S905X/D, S912, A113X/D or S905X/D2
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: meson: remove MESON_IRQ_GPIO selection
2020-10-20 7:25 ` [PATCH 2/2] arm64: meson: remove MESON_IRQ_GPIO selection Neil Armstrong
@ 2020-10-20 23:18 ` Kevin Hilman
0 siblings, 0 replies; 9+ messages in thread
From: Kevin Hilman @ 2020-10-20 23:18 UTC (permalink / raw)
To: Neil Armstrong, maz
Cc: linux-amlogic, Neil Armstrong, linux-kernel, linux-arm-kernel,
jbrunet
Neil Armstrong <narmstrong@baylibre•com> writes:
> Selecting MESON_IRQ_GPIO forces it as built-in, but we may need to build it
> as a module, thus remove it here and let the "default ARCH_MESON" build as
> built-in by default with the option to switch it to module.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre•com>
I'll queue this one via the amlogic tree since we'll likely be removing
the rest of these selects soon too.
Kevin
> ---
> arch/arm64/Kconfig.platforms | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index cd58f8495c45..dfb66917f665 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -157,7 +157,6 @@ config ARCH_MESON
> select COMMON_CLK_GXBB
> select COMMON_CLK_AXG
> select COMMON_CLK_G12A
> - select MESON_IRQ_GPIO
> help
> This enables support for the arm64 based Amlogic SoCs
> such as the s905, S905X/D, S912, A113X/D or S905X/D2
> --
> 2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 0/2] irq-meson-gpio: make it possible to build as a module
@ 2021-09-02 13:49 Neil Armstrong
2021-09-02 13:49 ` [PATCH 1/2] irqchip: " Neil Armstrong
2021-09-02 13:49 ` [PATCH 2/2] arm64: meson: remove MESON_IRQ_GPIO selection Neil Armstrong
0 siblings, 2 replies; 9+ messages in thread
From: Neil Armstrong @ 2021-09-02 13:49 UTC (permalink / raw)
To: maz, tglx, jbrunet
Cc: khilman, lee.jones, saravanak, linux-amlogic, linux-arm-kernel,
linux-kernel, Neil Armstrong
In order to reduce the kernel Image size on multi-platform distributions,
make it possible to build the Amlogic GPIO IRQ controller as a module
by switching it to a platform driver.
The second patch removes MESON_IRQ_GPIO selection from ARCH_MESON to allow
building the driver as module.
Changes since v1:
- makes usage of IRQCHIP_PLATFORM_DRIVER_BEGIN/MATCH/PLATFORM_DRIVER_END
Neil Armstrong (2):
irqchip: irq-meson-gpio: make it possible to build as a module
arm64: meson: remove MESON_IRQ_GPIO selection
arch/arm64/Kconfig.platforms | 1 -
drivers/irqchip/Kconfig | 5 +++--
drivers/irqchip/irq-meson-gpio.c | 15 +++++++++------
3 files changed, 12 insertions(+), 9 deletions(-)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module
2021-09-02 13:49 [PATCH 0/2] irq-meson-gpio: make it possible to build as a module Neil Armstrong
@ 2021-09-02 13:49 ` Neil Armstrong
2021-09-02 17:00 ` Saravana Kannan
2021-09-28 23:27 ` Kevin Hilman
2021-09-02 13:49 ` [PATCH 2/2] arm64: meson: remove MESON_IRQ_GPIO selection Neil Armstrong
1 sibling, 2 replies; 9+ messages in thread
From: Neil Armstrong @ 2021-09-02 13:49 UTC (permalink / raw)
To: maz, tglx, jbrunet
Cc: khilman, lee.jones, saravanak, linux-amlogic, linux-arm-kernel,
linux-kernel, Neil Armstrong
In order to reduce the kernel Image size on multi-platform distributions,
make it possible to build the Amlogic GPIO IRQ controller as a module
by switching it to a platform driver.
Signed-off-by: Neil Armstrong <narmstrong@baylibre•com>
---
drivers/irqchip/Kconfig | 5 +++--
drivers/irqchip/irq-meson-gpio.c | 15 +++++++++------
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 4d5924e9f766..2aba485025fd 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -400,8 +400,9 @@ config IRQ_UNIPHIER_AIDET
Support for the UniPhier AIDET (ARM Interrupt Detector).
config MESON_IRQ_GPIO
- bool "Meson GPIO Interrupt Multiplexer"
- depends on ARCH_MESON
+ tristate "Meson GPIO Interrupt Multiplexer"
+ depends on ARCH_MESON || COMPILE_TEST
+ default ARCH_MESON
select IRQ_DOMAIN_HIERARCHY
help
Support Meson SoC Family GPIO Interrupt Multiplexer
diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c
index e50676ce2ec8..d90ff0b92480 100644
--- a/drivers/irqchip/irq-meson-gpio.c
+++ b/drivers/irqchip/irq-meson-gpio.c
@@ -436,8 +436,7 @@ static const struct irq_domain_ops meson_gpio_irq_domain_ops = {
.translate = meson_gpio_irq_domain_translate,
};
-static int __init meson_gpio_irq_parse_dt(struct device_node *node,
- struct meson_gpio_irq_controller *ctl)
+static int meson_gpio_irq_parse_dt(struct device_node *node, struct meson_gpio_irq_controller *ctl)
{
const struct of_device_id *match;
int ret;
@@ -463,8 +462,7 @@ static int __init meson_gpio_irq_parse_dt(struct device_node *node,
return 0;
}
-static int __init meson_gpio_irq_of_init(struct device_node *node,
- struct device_node *parent)
+static int meson_gpio_irq_of_init(struct device_node *node, struct device_node *parent)
{
struct irq_domain *domain, *parent_domain;
struct meson_gpio_irq_controller *ctl;
@@ -521,5 +519,10 @@ static int __init meson_gpio_irq_of_init(struct device_node *node,
return ret;
}
-IRQCHIP_DECLARE(meson_gpio_intc, "amlogic,meson-gpio-intc",
- meson_gpio_irq_of_init);
+IRQCHIP_PLATFORM_DRIVER_BEGIN(meson_gpio_intc)
+IRQCHIP_MATCH("amlogic,meson-gpio-intc", meson_gpio_irq_of_init)
+IRQCHIP_PLATFORM_DRIVER_END(meson_gpio_intc)
+
+MODULE_AUTHOR("Jerome Brunet <jbrunet@baylibre•com>");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:meson-gpio-intc");
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] arm64: meson: remove MESON_IRQ_GPIO selection
2021-09-02 13:49 [PATCH 0/2] irq-meson-gpio: make it possible to build as a module Neil Armstrong
2021-09-02 13:49 ` [PATCH 1/2] irqchip: " Neil Armstrong
@ 2021-09-02 13:49 ` Neil Armstrong
2021-09-28 23:28 ` Kevin Hilman
1 sibling, 1 reply; 9+ messages in thread
From: Neil Armstrong @ 2021-09-02 13:49 UTC (permalink / raw)
To: maz, tglx, jbrunet
Cc: khilman, lee.jones, saravanak, linux-amlogic, linux-arm-kernel,
linux-kernel, Neil Armstrong
Selecting MESON_IRQ_GPIO forces it as built-in, but we may need to build it
as a module, thus remove it here and let the "default ARCH_MESON" build as
built-in by default with the option to switch it to module.
Signed-off-by: Neil Armstrong <narmstrong@baylibre•com>
---
arch/arm64/Kconfig.platforms | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index b0ce18d4cc98..ff2d83fbbde1 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -167,7 +167,6 @@ config ARCH_MEDIATEK
config ARCH_MESON
bool "Amlogic Platforms"
select COMMON_CLK
- select MESON_IRQ_GPIO
help
This enables support for the arm64 based Amlogic SoCs
such as the s905, S905X/D, S912, A113X/D or S905X/D2
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module
2021-09-02 13:49 ` [PATCH 1/2] irqchip: " Neil Armstrong
@ 2021-09-02 17:00 ` Saravana Kannan
2021-09-28 10:45 ` Lee Jones
2021-09-28 23:27 ` Kevin Hilman
1 sibling, 1 reply; 9+ messages in thread
From: Saravana Kannan @ 2021-09-02 17:00 UTC (permalink / raw)
To: Neil Armstrong
Cc: maz, tglx, jbrunet, khilman, lee.jones, linux-amlogic,
linux-arm-kernel, linux-kernel
On Thu, Sep 2, 2021 at 6:49 AM Neil Armstrong <narmstrong@baylibre•com> wrote:
>
> In order to reduce the kernel Image size on multi-platform distributions,
> make it possible to build the Amlogic GPIO IRQ controller as a module
> by switching it to a platform driver.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre•com>
> ---
> drivers/irqchip/Kconfig | 5 +++--
> drivers/irqchip/irq-meson-gpio.c | 15 +++++++++------
> 2 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 4d5924e9f766..2aba485025fd 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -400,8 +400,9 @@ config IRQ_UNIPHIER_AIDET
> Support for the UniPhier AIDET (ARM Interrupt Detector).
>
> config MESON_IRQ_GPIO
> - bool "Meson GPIO Interrupt Multiplexer"
> - depends on ARCH_MESON
> + tristate "Meson GPIO Interrupt Multiplexer"
> + depends on ARCH_MESON || COMPILE_TEST
> + default ARCH_MESON
> select IRQ_DOMAIN_HIERARCHY
> help
> Support Meson SoC Family GPIO Interrupt Multiplexer
> diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c
> index e50676ce2ec8..d90ff0b92480 100644
> --- a/drivers/irqchip/irq-meson-gpio.c
> +++ b/drivers/irqchip/irq-meson-gpio.c
> @@ -436,8 +436,7 @@ static const struct irq_domain_ops meson_gpio_irq_domain_ops = {
> .translate = meson_gpio_irq_domain_translate,
> };
>
> -static int __init meson_gpio_irq_parse_dt(struct device_node *node,
> - struct meson_gpio_irq_controller *ctl)
> +static int meson_gpio_irq_parse_dt(struct device_node *node, struct meson_gpio_irq_controller *ctl)
> {
> const struct of_device_id *match;
> int ret;
> @@ -463,8 +462,7 @@ static int __init meson_gpio_irq_parse_dt(struct device_node *node,
> return 0;
> }
>
> -static int __init meson_gpio_irq_of_init(struct device_node *node,
> - struct device_node *parent)
> +static int meson_gpio_irq_of_init(struct device_node *node, struct device_node *parent)
> {
> struct irq_domain *domain, *parent_domain;
> struct meson_gpio_irq_controller *ctl;
> @@ -521,5 +519,10 @@ static int __init meson_gpio_irq_of_init(struct device_node *node,
> return ret;
> }
>
> -IRQCHIP_DECLARE(meson_gpio_intc, "amlogic,meson-gpio-intc",
> - meson_gpio_irq_of_init);
> +IRQCHIP_PLATFORM_DRIVER_BEGIN(meson_gpio_intc)
> +IRQCHIP_MATCH("amlogic,meson-gpio-intc", meson_gpio_irq_of_init)
> +IRQCHIP_PLATFORM_DRIVER_END(meson_gpio_intc)
> +
> +MODULE_AUTHOR("Jerome Brunet <jbrunet@baylibre•com>");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:meson-gpio-intc");
> --
Acked-by: Saravana Kannan <saravanak@google•com>
Marc, my mdio-mux patches have landed.
-Saravana
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module
2021-09-02 17:00 ` Saravana Kannan
@ 2021-09-28 10:45 ` Lee Jones
0 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2021-09-28 10:45 UTC (permalink / raw)
To: Saravana Kannan
Cc: Neil Armstrong, maz, tglx, jbrunet, khilman, linux-amlogic,
linux-arm-kernel, linux-kernel
On Thu, 02 Sep 2021, Saravana Kannan wrote:
> On Thu, Sep 2, 2021 at 6:49 AM Neil Armstrong <narmstrong@baylibre•com> wrote:
> >
> > In order to reduce the kernel Image size on multi-platform distributions,
> > make it possible to build the Amlogic GPIO IRQ controller as a module
> > by switching it to a platform driver.
> >
> > Signed-off-by: Neil Armstrong <narmstrong@baylibre•com>
> > ---
> > drivers/irqchip/Kconfig | 5 +++--
> > drivers/irqchip/irq-meson-gpio.c | 15 +++++++++------
> > 2 files changed, 12 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> > index 4d5924e9f766..2aba485025fd 100644
> > --- a/drivers/irqchip/Kconfig
> > +++ b/drivers/irqchip/Kconfig
> > @@ -400,8 +400,9 @@ config IRQ_UNIPHIER_AIDET
> > Support for the UniPhier AIDET (ARM Interrupt Detector).
> >
> > config MESON_IRQ_GPIO
> > - bool "Meson GPIO Interrupt Multiplexer"
> > - depends on ARCH_MESON
> > + tristate "Meson GPIO Interrupt Multiplexer"
> > + depends on ARCH_MESON || COMPILE_TEST
> > + default ARCH_MESON
> > select IRQ_DOMAIN_HIERARCHY
> > help
> > Support Meson SoC Family GPIO Interrupt Multiplexer
> > diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c
> > index e50676ce2ec8..d90ff0b92480 100644
> > --- a/drivers/irqchip/irq-meson-gpio.c
> > +++ b/drivers/irqchip/irq-meson-gpio.c
> > @@ -436,8 +436,7 @@ static const struct irq_domain_ops meson_gpio_irq_domain_ops = {
> > .translate = meson_gpio_irq_domain_translate,
> > };
> >
> > -static int __init meson_gpio_irq_parse_dt(struct device_node *node,
> > - struct meson_gpio_irq_controller *ctl)
> > +static int meson_gpio_irq_parse_dt(struct device_node *node, struct meson_gpio_irq_controller *ctl)
> > {
> > const struct of_device_id *match;
> > int ret;
> > @@ -463,8 +462,7 @@ static int __init meson_gpio_irq_parse_dt(struct device_node *node,
> > return 0;
> > }
> >
> > -static int __init meson_gpio_irq_of_init(struct device_node *node,
> > - struct device_node *parent)
> > +static int meson_gpio_irq_of_init(struct device_node *node, struct device_node *parent)
> > {
> > struct irq_domain *domain, *parent_domain;
> > struct meson_gpio_irq_controller *ctl;
> > @@ -521,5 +519,10 @@ static int __init meson_gpio_irq_of_init(struct device_node *node,
> > return ret;
> > }
> >
> > -IRQCHIP_DECLARE(meson_gpio_intc, "amlogic,meson-gpio-intc",
> > - meson_gpio_irq_of_init);
> > +IRQCHIP_PLATFORM_DRIVER_BEGIN(meson_gpio_intc)
> > +IRQCHIP_MATCH("amlogic,meson-gpio-intc", meson_gpio_irq_of_init)
> > +IRQCHIP_PLATFORM_DRIVER_END(meson_gpio_intc)
> > +
> > +MODULE_AUTHOR("Jerome Brunet <jbrunet@baylibre•com>");
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_ALIAS("platform:meson-gpio-intc");
> > --
>
> Acked-by: Saravana Kannan <saravanak@google•com>
>
> Marc, my mdio-mux patches have landed.
Reviewed-by: Lee Jones <lee.jones@linaro•org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module
2021-09-02 13:49 ` [PATCH 1/2] irqchip: " Neil Armstrong
2021-09-02 17:00 ` Saravana Kannan
@ 2021-09-28 23:27 ` Kevin Hilman
1 sibling, 0 replies; 9+ messages in thread
From: Kevin Hilman @ 2021-09-28 23:27 UTC (permalink / raw)
To: Neil Armstrong, maz, tglx, jbrunet
Cc: lee.jones, saravanak, linux-amlogic, linux-arm-kernel,
linux-kernel, Neil Armstrong
Neil Armstrong <narmstrong@baylibre•com> writes:
> In order to reduce the kernel Image size on multi-platform distributions,
> make it possible to build the Amlogic GPIO IRQ controller as a module
> by switching it to a platform driver.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre•com>
Reviewed-by: Kevin Hilman <khilman@baylibre•com>
Tested-by: Kevin Hilman <khilman@baylibre•com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: meson: remove MESON_IRQ_GPIO selection
2021-09-02 13:49 ` [PATCH 2/2] arm64: meson: remove MESON_IRQ_GPIO selection Neil Armstrong
@ 2021-09-28 23:28 ` Kevin Hilman
0 siblings, 0 replies; 9+ messages in thread
From: Kevin Hilman @ 2021-09-28 23:28 UTC (permalink / raw)
To: Neil Armstrong, maz, tglx, jbrunet
Cc: lee.jones, saravanak, linux-amlogic, linux-arm-kernel,
linux-kernel, Neil Armstrong
Neil Armstrong <narmstrong@baylibre•com> writes:
> Selecting MESON_IRQ_GPIO forces it as built-in, but we may need to build it
> as a module, thus remove it here and let the "default ARCH_MESON" build as
> built-in by default with the option to switch it to module.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre•com>
Reviewed-by: Kevin Hilman <khilman@baylibre•com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-09-28 23:30 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-02 13:49 [PATCH 0/2] irq-meson-gpio: make it possible to build as a module Neil Armstrong
2021-09-02 13:49 ` [PATCH 1/2] irqchip: " Neil Armstrong
2021-09-02 17:00 ` Saravana Kannan
2021-09-28 10:45 ` Lee Jones
2021-09-28 23:27 ` Kevin Hilman
2021-09-02 13:49 ` [PATCH 2/2] arm64: meson: remove MESON_IRQ_GPIO selection Neil Armstrong
2021-09-28 23:28 ` Kevin Hilman
-- strict thread matches above, loose matches on Subject: below --
2020-10-20 7:25 [PATCH 0/2] irq-meson-gpio: make it possible to build as a module Neil Armstrong
2020-10-20 7:25 ` [PATCH 2/2] arm64: meson: remove MESON_IRQ_GPIO selection Neil Armstrong
2020-10-20 23:18 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox