From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 03/12] mmc: tegra: restrict the voltage_switch() callback to the 1.8V case
Date: Thu, 09 Jun 2016 14:27:16 +0200 [thread overview]
Message-ID: <8737omo8d7.fsf@free-electrons.com> (raw)
In-Reply-To: <1465466097.18807.7.camel@lynxeye.de> (Lucas Stach's message of "Thu, 09 Jun 2016 11:54:57 +0200")
Hi Lucas,
On jeu., juin 09 2016, Lucas Stach <dev@lynxeye•de> wrote:
> Am Donnerstag, den 09.06.2016, 09:10 +0200 schrieb Gregory CLEMENT:
>> Given its name the voltage_switch() should be called for any
>> voltage. However currently it is only called for the 1.8V case.
>>
>> That means that the current implementation of the callback could have
>> made this assumption. In order to not adding a regression when the
>> voltage_switch() function will be called for the other voltage
>> targets,
>> this patch ensure that the code of the current callback won't be
>> executed
>> for the other case than 1.8V.
>>
> This isn't necessary, it's fine to re-execute the pad calibration for
> any voltage switch.
Thanks for your feedback, so I can remove this patch from the series.
Gregory
>
> Regards,
> Lucas
>
>> Cc: Lucas Stach <dev@lynxeye•de>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
>> ---
>> ?drivers/mmc/host/sdhci-tegra.c | 4 ++++
>> ?1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-
>> tegra.c
>> index bcc0de47fe7e..01f58296125e 100644
>> --- a/drivers/mmc/host/sdhci-tegra.c
>> +++ b/drivers/mmc/host/sdhci-tegra.c
>> @@ -302,6 +302,10 @@ static void tegra_sdhci_voltage_switch(struct
>> sdhci_host *host)
>> ? struct sdhci_tegra *tegra_host =
>> sdhci_pltfm_priv(pltfm_host);
>> ? const struct sdhci_tegra_soc_data *soc_data = tegra_host-
>> >soc_data;
>> ?
>> + /* initially this function was called only for the 1.8V case
>> */
>> + if (host->mmc->ios.signal_voltage != MMC_SIGNAL_VOLTAGE_180)
>> + return;
>> +
>> ? if (soc_data->nvquirks & NVQUIRK_HAS_PADCALIB)
>> ? tegra_host->pad_calib_required = true;
>> ?}
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2016-06-09 12:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 7:10 [PATCH 00/12] Add SDHCI Xenon driver Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 01/12] mmc: sdhci: add init_card callback to sdhci Gregory CLEMENT
2016-06-13 8:32 ` Adrian Hunter
2016-06-14 7:58 ` Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 02/12] mmc: sdhci_f_sdh30: restrict voltage_switch() callback to the 1.8V case Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 03/12] mmc: tegra: restrict the " Gregory CLEMENT
2016-06-09 9:54 ` Lucas Stach
2016-06-09 12:27 ` Gregory CLEMENT [this message]
2016-06-09 7:10 ` [PATCH 04/12] mmc: sdhci: call voltage_switch callback also for the 3.3V case Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 05/12] mmc: sdhci: add a pre voltage switch callback function Gregory CLEMENT
2016-06-13 8:46 ` Adrian Hunter
2016-06-13 14:04 ` Ziji Hu
2016-06-14 7:07 ` Adrian Hunter
2016-06-14 7:59 ` Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 06/12] mmc: sdhci: add delay adjust feature including phy reset Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 07/12] mmc: core: export the alive operation Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 08/12] dt-bindings: mmc: Add Xenon description Gregory CLEMENT
2016-06-10 14:16 ` Rob Herring
2016-06-14 8:02 ` Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 09/12] mmc: sdhci-xenon: add initial Xenon eMMC driver Gregory CLEMENT
2016-06-09 13:45 ` kbuild test robot
2016-06-09 14:33 ` Gregory CLEMENT
2016-06-09 14:20 ` kbuild test robot
2016-06-09 14:54 ` Gregory CLEMENT
2016-06-09 21:49 ` Arnd Bergmann
2016-06-14 6:52 ` Adrian Hunter
2016-06-14 8:19 ` Gregory CLEMENT
2016-06-14 8:36 ` Adrian Hunter
2016-06-22 11:04 ` Ulf Hansson
2016-06-09 7:10 ` [PATCH 10/12] arm64: dts: marvell: add eMMC support for Armada 37xx Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 11/12] arm64: dts: marvell: add SDIO " Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 12/12] arm64: defconfig: Add Xenon sdhci Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737omo8d7.fsf@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox