From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 08/12] dt-bindings: mmc: Add Xenon description
Date: Tue, 14 Jun 2016 10:02:47 +0200 [thread overview]
Message-ID: <87d1nkci54.fsf@free-electrons.com> (raw)
In-Reply-To: <20160610141603.GA7827@rob-hp-laptop> (Rob Herring's message of "Fri, 10 Jun 2016 09:16:03 -0500")
Hi Rob,
On ven., juin 10 2016, Rob Herring <robh@kernel•org> wrote:
> On Thu, Jun 09, 2016 at 09:10:14AM +0200, Gregory CLEMENT wrote:
>> This patch documents the Xenon SDHCI controller that we can find in the
>> Armada 37xx and the Armada 7K and 8K SoCs.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
>> ---
>> .../devicetree/bindings/mmc/sdhci-xenon.txt | 27 ++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-xenon.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-xenon.txt b/Documentation/devicetree/bindings/mmc/sdhci-xenon.txt
>> new file mode 100644
>> index 000000000000..e8d49fda5f12
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-xenon.txt
>> @@ -0,0 +1,27 @@
>> +* Marvell sdhci-xenon controller
>> +
>> +This file documents differences between the core properties in mmc.txt
>> +and the properties used by the sdhci-xenon drivers.
>
> Bindings don't document drivers...
Sure I missed this one.
>
>> +
>> +Required properties:
>> +- compatible: Should be "marvell,xenon-sdhci".
>
> SoC specific compatible strings please. This one can be fallback.
OK
>
>> +- reg:
>> + one register area for the SDHCI registers.
>> +- interrupts-extended: interrupt number and attributes
>
> Just use interrupts unless you really have a need for
> interrupts-extended. Really, either is valid for any binding, but I
> prefer to just have bindings documented one way.
OK
>
>> +- clocks: array of clocks required for SDHCI.
>
> Missing from the exmaple, and how many clocks and in what order?
I need to figure out it.
>
>> +- bus-width: max bus width in unit of bit, normally should be 1 bit, 4 bits or 8 bits
>
> Isn't this one standard? Just refer back to the common binding.
OK it will simplify the binding dcumentation.
>
>> +
>> +Optional properties:
>> +- non-removable: whether card is non-removable.
>> +- auto-cmd12: whether cmd12 is sent automatically.
>
> Seems strange this would be optional for a specific controller. I'd
> expect either the xenon controller needs this or not.
I have to check it.
Thanks for the review,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2016-06-14 8:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 7:10 [PATCH 00/12] Add SDHCI Xenon driver Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 01/12] mmc: sdhci: add init_card callback to sdhci Gregory CLEMENT
2016-06-13 8:32 ` Adrian Hunter
2016-06-14 7:58 ` Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 02/12] mmc: sdhci_f_sdh30: restrict voltage_switch() callback to the 1.8V case Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 03/12] mmc: tegra: restrict the " Gregory CLEMENT
2016-06-09 9:54 ` Lucas Stach
2016-06-09 12:27 ` Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 04/12] mmc: sdhci: call voltage_switch callback also for the 3.3V case Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 05/12] mmc: sdhci: add a pre voltage switch callback function Gregory CLEMENT
2016-06-13 8:46 ` Adrian Hunter
2016-06-13 14:04 ` Ziji Hu
2016-06-14 7:07 ` Adrian Hunter
2016-06-14 7:59 ` Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 06/12] mmc: sdhci: add delay adjust feature including phy reset Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 07/12] mmc: core: export the alive operation Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 08/12] dt-bindings: mmc: Add Xenon description Gregory CLEMENT
2016-06-10 14:16 ` Rob Herring
2016-06-14 8:02 ` Gregory CLEMENT [this message]
2016-06-09 7:10 ` [PATCH 09/12] mmc: sdhci-xenon: add initial Xenon eMMC driver Gregory CLEMENT
2016-06-09 13:45 ` kbuild test robot
2016-06-09 14:33 ` Gregory CLEMENT
2016-06-09 14:20 ` kbuild test robot
2016-06-09 14:54 ` Gregory CLEMENT
2016-06-09 21:49 ` Arnd Bergmann
2016-06-14 6:52 ` Adrian Hunter
2016-06-14 8:19 ` Gregory CLEMENT
2016-06-14 8:36 ` Adrian Hunter
2016-06-22 11:04 ` Ulf Hansson
2016-06-09 7:10 ` [PATCH 10/12] arm64: dts: marvell: add eMMC support for Armada 37xx Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 11/12] arm64: dts: marvell: add SDIO " Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 12/12] arm64: defconfig: Add Xenon sdhci Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1nkci54.fsf@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox