* [PATCH RFC] MFD: OMAP: USB: Make the runtime functions depend on CONFIG_PM_RUNTIME
@ 2012-01-03 6:42 Shubhrajyoti D
2012-01-04 0:14 ` Kevin Hilman
0 siblings, 1 reply; 3+ messages in thread
From: Shubhrajyoti D @ 2012-01-03 6:42 UTC (permalink / raw)
To: linux-arm-kernel
Currently the runtime functions are compiled regardless
of CONFIG_PM_RUNTIME flag. This patch intends to fix the same by
using SET_RUNTIME_PM_OPS.
Cc : Keshava Munegowda <keshava_mgowda@ti•com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti•com>
---
applies on Tony's ehci branch.
Compile tested only.
drivers/mfd/omap-usb-host.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 3f565ef..ef72ebe 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -887,8 +887,8 @@ static int __devexit usbhs_omap_remove(struct platform_device *pdev)
}
static const struct dev_pm_ops usbhsomap_dev_pm_ops = {
- .runtime_suspend = usbhs_runtime_suspend,
- .runtime_resume = usbhs_runtime_resume,
+ SET_RUNTIME_PM_OPS(usbhs_runtime_suspend,
+ usbhs_runtime_resume, NULL)
};
static struct platform_driver usbhs_omap_driver = {
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH RFC] MFD: OMAP: USB: Make the runtime functions depend on CONFIG_PM_RUNTIME
2012-01-03 6:42 [PATCH RFC] MFD: OMAP: USB: Make the runtime functions depend on CONFIG_PM_RUNTIME Shubhrajyoti D
@ 2012-01-04 0:14 ` Kevin Hilman
2012-01-09 11:30 ` Shubhrajyoti Datta
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2012-01-04 0:14 UTC (permalink / raw)
To: linux-arm-kernel
Shubhrajyoti D <shubhrajyoti@ti•com> writes:
> Currently the runtime functions are compiled regardless
> of CONFIG_PM_RUNTIME flag. This patch intends to fix the same by
> using SET_RUNTIME_PM_OPS.
>
> Cc : Keshava Munegowda <keshava_mgowda@ti•com>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti•com>
> ---
> applies on Tony's ehci branch.
> Compile tested only.
You also should compile test this with runtime PM disabled. I believe
the current patch will lead to 'function defined but not used' warnings.
Kevin
> drivers/mfd/omap-usb-host.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 3f565ef..ef72ebe 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -887,8 +887,8 @@ static int __devexit usbhs_omap_remove(struct platform_device *pdev)
> }
>
> static const struct dev_pm_ops usbhsomap_dev_pm_ops = {
> - .runtime_suspend = usbhs_runtime_suspend,
> - .runtime_resume = usbhs_runtime_resume,
> + SET_RUNTIME_PM_OPS(usbhs_runtime_suspend,
> + usbhs_runtime_resume, NULL)
> };
>
> static struct platform_driver usbhs_omap_driver = {
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH RFC] MFD: OMAP: USB: Make the runtime functions depend on CONFIG_PM_RUNTIME
2012-01-04 0:14 ` Kevin Hilman
@ 2012-01-09 11:30 ` Shubhrajyoti Datta
0 siblings, 0 replies; 3+ messages in thread
From: Shubhrajyoti Datta @ 2012-01-09 11:30 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 4, 2012 at 5:44 AM, Kevin Hilman <khilman@ti•com> wrote:
> Shubhrajyoti D <shubhrajyoti@ti•com> writes:
>
>> Currently the runtime functions are compiled regardless
>> of CONFIG_PM_RUNTIME flag. This patch intends to fix the same by
>> using SET_RUNTIME_PM_OPS.
>>
>> Cc : Keshava Munegowda <keshava_mgowda@ti•com>
>> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti•com>
>> ---
>> applies on Tony's ehci branch.
>> Compile tested only.
>
> You also should compile test this with runtime PM disabled. ?I believe
> the current patch will lead to 'function defined but not used' warnings.
Agree . thanks for pointing out.
>
> Kevin
>
>> ?drivers/mfd/omap-usb-host.c | ? ?4 ++--
>> ?1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
>> index 3f565ef..ef72ebe 100644
>> --- a/drivers/mfd/omap-usb-host.c
>> +++ b/drivers/mfd/omap-usb-host.c
>> @@ -887,8 +887,8 @@ static int __devexit usbhs_omap_remove(struct platform_device *pdev)
>> ?}
>>
>> ?static const struct dev_pm_ops usbhsomap_dev_pm_ops = {
>> - ? ? .runtime_suspend ? ? ? ?= usbhs_runtime_suspend,
>> - ? ? .runtime_resume ? ? ? ? = usbhs_runtime_resume,
>> + ? ? SET_RUNTIME_PM_OPS(usbhs_runtime_suspend,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? usbhs_runtime_resume, NULL)
>> ?};
>>
>> ?static struct platform_driver usbhs_omap_driver = {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-09 11:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-03 6:42 [PATCH RFC] MFD: OMAP: USB: Make the runtime functions depend on CONFIG_PM_RUNTIME Shubhrajyoti D
2012-01-04 0:14 ` Kevin Hilman
2012-01-09 11:30 ` Shubhrajyoti Datta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox