From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH 03/11] arm:omap:am33xx: Add power domain data
Date: Fri, 02 Dec 2011 13:25:08 -0800 [thread overview]
Message-ID: <874nxiis3v.fsf@ti.com> (raw)
In-Reply-To: <DF0F476B391FA8409C78302C7BA518B6039FFA@DBDE01.ent.ti.com> (Sekhar Nori's message of "Fri, 2 Dec 2011 18:14:48 +0000")
"Nori, Sekhar" <nsekhar@ti•com> writes:
> On Thu, Dec 01, 2011 at 06:34:19, Hilman, Kevin wrote:
>> Vaibhav Hiremath <hvaibhav@ti•com> writes:
>>
>> > From: Afzal Mohammed <afzal@ti•com>
>> >
>> > This patch adds AM33XX power domain data,
>> > corresponding API's to access PRM module and
>> > PRM register offsets & bit fields.
>> >
>> > Signed-off-by: Rachna Patil <rachna@ti•com>
>> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti•com>
>> > Signed-off-by: Afzal Mohammed <afzal@ti•com>
>>
>> First some general comments:
>>
>> At first glance, it seems like there could be much more reuse with OMAP4
>> code here. From what I see, AM33x has only one partition compared to
>> several on OMAP4, but that doesn't mean you couldn't reuse the OMAP4
>> functions and just use a single partition.
>>
>> IOW, it seems to me that all the pwrdm_ops could be shared with OMAP4.
>>
>> From what I read (after an admittedly quick glance), the main thing you
>> need is a way to override the PRM offsets due to the fact that some
>> crazy person decided to make each instance different.
>
> If its any consolation, this has been fed back to the chip designers
> and is expected to be corrected for the next AM335x derivative.
Great, Thanks!
Assuming mainline kernel support is a priority for the other SoCs in
this family, keeping SW compatibility with other existing SoCs in the
OMAP family should be a high priority. This is especially true when
large portions of the IP are reused from existing SoCs, as is clearly
the case in AM33x.
Kevin
next prev parent reply other threads:[~2011-12-02 21:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 17:19 [RFC PATCH 00/11] arm:omap:am33xx: Add basic voltage, power, clock & HWMOD data Vaibhav Hiremath
2011-11-20 17:19 ` [RFC PATCH 01/11] arm:omap:am33xx: Add voltage domain data Vaibhav Hiremath
2011-12-01 0:11 ` Kevin Hilman
2011-12-01 11:25 ` Hiremath, Vaibhav
2011-12-01 14:53 ` Kevin Hilman
2011-11-20 17:19 ` [RFC PATCH 02/11] arm:omap:am33xx: Integrate " Vaibhav Hiremath
2011-12-01 0:12 ` Kevin Hilman
2011-12-01 11:25 ` Hiremath, Vaibhav
2011-11-20 17:19 ` [RFC PATCH 03/11] arm:omap:am33xx: Add power " Vaibhav Hiremath
2011-12-01 1:04 ` Kevin Hilman
2011-12-01 11:58 ` Hiremath, Vaibhav
2011-12-01 15:29 ` Kevin Hilman
2011-12-02 5:37 ` Rajendra Nayak
2011-12-02 17:39 ` Kevin Hilman
2011-12-02 18:14 ` Nori, Sekhar
2011-12-02 21:25 ` Kevin Hilman [this message]
2011-12-02 9:19 ` Rajendra Nayak
2011-11-20 17:19 ` [RFC PATCH 04/11] arm:omap:am33xx: Integrate powerdomain to OMAP power framework Vaibhav Hiremath
2011-12-01 1:04 ` Kevin Hilman
2011-12-01 11:26 ` Hiremath, Vaibhav
2011-11-20 17:19 ` [RFC PATCH 06/11] arm:omap:am33xx: Integrate clock & clockdomain to OMAP clock framework Vaibhav Hiremath
2011-11-20 17:19 ` [RFC PATCH 07/11] arm:omap:am33xx: Add irq, dma and module base addr to SoC header files Vaibhav Hiremath
2011-12-01 1:46 ` Kevin Hilman
2011-12-01 12:03 ` Hiremath, Vaibhav
2011-11-20 17:19 ` [RFC PATCH 08/11] arm:omap:am33xx: Add HWMOD data Vaibhav Hiremath
2011-11-20 17:19 ` [RFC PATCH 09/11] arm:omap:am33xx: Integrate AM33XX hwmods to omap HWMOD framework Vaibhav Hiremath
2011-11-20 17:19 ` [RFC PATCH 10/11] ARM:omap:am33xx: Add clock control api's Vaibhav Hiremath
2011-11-20 17:19 ` [RFC PATCH 11/11] arm:omap:am33xx: Add am335x support in generic omap_hwmod Vaibhav Hiremath
2011-12-07 0:09 ` Kevin Hilman
2011-12-01 1:42 ` [RFC PATCH 00/11] arm:omap:am33xx: Add basic voltage, power, clock & HWMOD data Kevin Hilman
2011-12-01 12:02 ` Hiremath, Vaibhav
2011-12-01 12:57 ` Cousson, Benoit
2011-12-01 14:58 ` Kevin Hilman
2011-12-01 15:14 ` Kevin Hilman
2011-12-07 21:25 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nxiis3v.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox