From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH 01/11] arm:omap:am33xx: Add voltage domain data
Date: Wed, 30 Nov 2011 16:11:20 -0800 [thread overview]
Message-ID: <87ipm1w3pz.fsf@ti.com> (raw)
In-Reply-To: <1321809555-13833-2-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Sun, 20 Nov 2011 22:49:05 +0530")
Vaibhav Hiremath <hvaibhav@ti•com> writes:
> From: Afzal Mohammed <afzal@ti•com>
>
> Currently dummy voltage domain data is being created
> in order to succeed boot process.
> Nothing has been done w.r.t actual hardware (voltage control).
>
> Signed-off-by: Afzal Mohammed <afzal@ti•com>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti•com>
[...]
> --- /dev/null
> +++ b/arch/arm/mach-omap2/voltagedomains33xx_data.c
> @@ -0,0 +1,37 @@
> +/*
> + * AM33XX voltage domain data
> + *
> + * Copyright (C) 2011 Texas Instruments, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +#include <linux/kernel.h>
> +#include <linux/init.h>
> +
> +#include "voltage.h"
> +
> +static struct voltagedomain am33xx_voltdm_mpu = {
> + .name = "mpu",
> +};
According to the TRM, there is no MPU voltage domain. Only CORE and RTC
exist.
However, looking at the data manual (SPRS717 Oct 2011), it seems that
some packages have a separate VDD_MPU while others have a combined
VDD_MPU and VDD_CORE.
This should be clarified and documented in the changelog.
> +static struct voltagedomain am33xx_voltdm_core = {
> + .name = "core",
> +};
> +
> +static struct voltagedomain am33xx_voltdm_rtc = {
> + .name = "rtc",
> +};
Won't these basically empty voltage domains fail during voltage init?
At a minimum, it seems they should have '.scaling = false' as well until
voltage scalling is supported.
> +static struct voltagedomain *voltagedomains_am33xx[] __initdata = {
> + &am33xx_voltdm_mpu,
> + &am33xx_voltdm_core,
> + &am33xx_voltdm_rtc,
> + NULL,
> +};
> +
> +void __init am33xx_voltagedomains_init(void)
> +{
> + voltdm_init(voltagedomains_am33xx);
> +}
Kevin
next prev parent reply other threads:[~2011-12-01 0:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 17:19 [RFC PATCH 00/11] arm:omap:am33xx: Add basic voltage, power, clock & HWMOD data Vaibhav Hiremath
2011-11-20 17:19 ` [RFC PATCH 01/11] arm:omap:am33xx: Add voltage domain data Vaibhav Hiremath
2011-12-01 0:11 ` Kevin Hilman [this message]
2011-12-01 11:25 ` Hiremath, Vaibhav
2011-12-01 14:53 ` Kevin Hilman
2011-11-20 17:19 ` [RFC PATCH 02/11] arm:omap:am33xx: Integrate " Vaibhav Hiremath
2011-12-01 0:12 ` Kevin Hilman
2011-12-01 11:25 ` Hiremath, Vaibhav
2011-11-20 17:19 ` [RFC PATCH 03/11] arm:omap:am33xx: Add power " Vaibhav Hiremath
2011-12-01 1:04 ` Kevin Hilman
2011-12-01 11:58 ` Hiremath, Vaibhav
2011-12-01 15:29 ` Kevin Hilman
2011-12-02 5:37 ` Rajendra Nayak
2011-12-02 17:39 ` Kevin Hilman
2011-12-02 18:14 ` Nori, Sekhar
2011-12-02 21:25 ` Kevin Hilman
2011-12-02 9:19 ` Rajendra Nayak
2011-11-20 17:19 ` [RFC PATCH 04/11] arm:omap:am33xx: Integrate powerdomain to OMAP power framework Vaibhav Hiremath
2011-12-01 1:04 ` Kevin Hilman
2011-12-01 11:26 ` Hiremath, Vaibhav
2011-11-20 17:19 ` [RFC PATCH 06/11] arm:omap:am33xx: Integrate clock & clockdomain to OMAP clock framework Vaibhav Hiremath
2011-11-20 17:19 ` [RFC PATCH 07/11] arm:omap:am33xx: Add irq, dma and module base addr to SoC header files Vaibhav Hiremath
2011-12-01 1:46 ` Kevin Hilman
2011-12-01 12:03 ` Hiremath, Vaibhav
2011-11-20 17:19 ` [RFC PATCH 08/11] arm:omap:am33xx: Add HWMOD data Vaibhav Hiremath
2011-11-20 17:19 ` [RFC PATCH 09/11] arm:omap:am33xx: Integrate AM33XX hwmods to omap HWMOD framework Vaibhav Hiremath
2011-11-20 17:19 ` [RFC PATCH 10/11] ARM:omap:am33xx: Add clock control api's Vaibhav Hiremath
2011-11-20 17:19 ` [RFC PATCH 11/11] arm:omap:am33xx: Add am335x support in generic omap_hwmod Vaibhav Hiremath
2011-12-07 0:09 ` Kevin Hilman
2011-12-01 1:42 ` [RFC PATCH 00/11] arm:omap:am33xx: Add basic voltage, power, clock & HWMOD data Kevin Hilman
2011-12-01 12:02 ` Hiremath, Vaibhav
2011-12-01 12:57 ` Cousson, Benoit
2011-12-01 14:58 ` Kevin Hilman
2011-12-01 15:14 ` Kevin Hilman
2011-12-07 21:25 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipm1w3pz.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox