From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341
Date: Fri, 20 Jan 2017 18:21:02 +0100 [thread overview]
Message-ID: <8760l9641t.fsf@free-electrons.com> (raw)
In-Reply-To: <20170120001203.GB31483@lunn.ch> (Andrew Lunn's message of "Fri, 20 Jan 2017 01:12:03 +0100")
Hi Vvien and Andrew,
On ven., janv. 20 2017, Andrew Lunn <andrew@lunn•ch> wrote:
> On Thu, Jan 19, 2017 at 05:26:03PM -0500, Vivien Didelot wrote:
>> Gregory CLEMENT <gregory.clement@free-electrons•com> writes:
>>
>> > +static bool mv88e6xxx_6341_family(struct mv88e6xxx_chip *chip)
>> > +{
>> > + return chip->info->family == MV88E6XXX_FAMILY_6341;
>> > +}
>>
>> I don't want to see these erronous family checks anymore, but I cannot
>> blame you for adding it since not all the code is moved to ops yet ;)
If there a series about to be merged I can rebase my series on it. Else
I propose to keep it and convert the family check to ops when you will
send the series for it.
>>
>> > MV88E6XXX_FAMILY_6165, /* 6123 6161 6165 */
>> > MV88E6XXX_FAMILY_6185, /* 6108 6121 6122 6131 6152 6155 6182 6185 */
>> > MV88E6XXX_FAMILY_6320, /* 6320 6321 */
>> > + MV88E6XXX_FAMILY_6341, /* 6141 6341 */
>>
>> Maybe I missed it, Andrew, can you confirm that 6341 is a proper Marvell
>> family of switch chips?
>
> My understand is that it is. Marvell have not added it to DSDT. There
> is a new SDK called UMSD, also GPLv2 and BSD. They call this family
> Topaz, and the 6390 is Peridot.
I confirm that 6141 and 6341 are called Topaz. Actually I can add the
support for the 6141 too, it is just a matter of adding an ID and maybe
removing some ops as 6141 is a subset of 6341.
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-01-20 17:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 21:49 [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin Gregory CLEMENT
2017-01-19 21:49 ` [PATCH v5 1/2] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports Gregory CLEMENT
2017-01-19 22:13 ` Vivien Didelot
2017-01-20 0:06 ` Andrew Lunn
2017-01-20 1:54 ` Vivien Didelot
2017-01-19 21:49 ` [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 Gregory CLEMENT
2017-01-19 22:26 ` Vivien Didelot
2017-01-20 0:12 ` Andrew Lunn
2017-01-20 1:55 ` Vivien Didelot
2017-01-20 17:21 ` Gregory CLEMENT [this message]
2017-01-20 17:30 ` Vivien Didelot
2017-01-20 23:15 ` Andrew Lunn
2017-01-19 22:06 ` [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin Andrew Lunn
2017-01-19 23:41 ` [EXT] " Jon Pannell
2017-01-20 17:08 ` Gregory CLEMENT
2017-01-20 17:43 ` Andrew Lunn
2017-01-20 22:38 ` Andrew Lunn
2017-01-19 22:07 ` Vivien Didelot
2017-01-19 22:33 ` Vivien Didelot
2017-01-20 19:17 ` David Miller
2017-01-24 16:47 ` Gregory CLEMENT
2017-01-24 18:08 ` Vivien Didelot
2017-01-24 19:57 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760l9641t.fsf@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox