From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin
Date: Fri, 20 Jan 2017 18:08:30 +0100 [thread overview]
Message-ID: <87a8al64mp.fsf@free-electrons.com> (raw)
In-Reply-To: <20170119220607.GA25907@lunn.ch> (Andrew Lunn's message of "Thu, 19 Jan 2017 23:06:07 +0100")
Hi Andrew,
On jeu., janv. 19 2017, Andrew Lunn <andrew@lunn•ch> wrote:
>> While comparing the datasheet and the ops functions used, some
>> question came to me. They should not prevent applying this series,
>> but their answer would help me to have a better understanding of the
>> dsa subsystem.
>>
>> - Are the temperature related operation still useful with dsa2 ?
>
> No. I'm in the process of moving the code into the Marvell PHY driver,
> since the sensor is in the embedded PHYs.
>
> What ID does the embedded PHY use? The 6390 has a blank ID, where as
> older device have a real ID.
Actually I didn't find anything related to the temperature measurement
in the datasheet I have. For the 6390 there is a dedicated datsheet for
the PHY part for the 6352 it is part of the same datasheet.
After a second look I think I don't have anything related to the PHY
part in the datasheets.
What I wanted to do was to test 6390 and 6352 temperature related
functions and to see if one of them worked. That's how I realized it was
not possible to do it with dsa2.
>
>> - Why the setup is done differently between the 6390 and the 6352
>> families when the have exactly the same register?
>
> EDSA on 6390 works differently to 6352, meaning it breaks. So we need
> to run the 6390 with DSA tagging, not EDSA. Maybe this is the source
> of the differences?
>
> It should also be noted that the 6390 support is not yet complete. I
> have a few more patches in my tree to post.
>
>> - On the Port Controller 2, the bit PORT_CONTROL_2_MAP_DA is set for
>> 6352 and not for 6390 whereas the same bit exists in 6360 and the
>> description for this bit is the same for both datasheet.
>
> Humm, it does look like it is missing mv88e6xxx_6390_family(chip).
>
>>
>> - Register PORT_ATU_CONTROL and PORT_PRI_OVERRIDE are reset on 6352
>> and not on 6390. While here again the registers description are
>> the same.
>
> And the same here. I've mostly been working on where the 6390 is
> different. Where it is the same i've mostly ignored it so far :-)
>
> There is also an ongoing effort to remove all these big if statements
> with a list of families.
Thanks for this answers I understand it a little better now.
Gregory
>
> Andrew
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-01-20 17:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 21:49 [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin Gregory CLEMENT
2017-01-19 21:49 ` [PATCH v5 1/2] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports Gregory CLEMENT
2017-01-19 22:13 ` Vivien Didelot
2017-01-20 0:06 ` Andrew Lunn
2017-01-20 1:54 ` Vivien Didelot
2017-01-19 21:49 ` [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 Gregory CLEMENT
2017-01-19 22:26 ` Vivien Didelot
2017-01-20 0:12 ` Andrew Lunn
2017-01-20 1:55 ` Vivien Didelot
2017-01-20 17:21 ` Gregory CLEMENT
2017-01-20 17:30 ` Vivien Didelot
2017-01-20 23:15 ` Andrew Lunn
2017-01-19 22:06 ` [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin Andrew Lunn
2017-01-19 23:41 ` [EXT] " Jon Pannell
2017-01-20 17:08 ` Gregory CLEMENT [this message]
2017-01-20 17:43 ` Andrew Lunn
2017-01-20 22:38 ` Andrew Lunn
2017-01-19 22:07 ` Vivien Didelot
2017-01-19 22:33 ` Vivien Didelot
2017-01-20 19:17 ` David Miller
2017-01-24 16:47 ` Gregory CLEMENT
2017-01-24 18:08 ` Vivien Didelot
2017-01-24 19:57 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8al64mp.fsf@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox