From: arno@natisbad•org (Arnaud Ebalard)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC] Add .dts file for Netgear ReadyNAS 102
Date: Thu, 04 Jul 2013 00:58:10 +0200 [thread overview]
Message-ID: <8761wrp7y5.fsf@natisbad.org> (raw)
In-Reply-To: <20130703222315.GK16785@1wt.eu> (Willy Tarreau's message of "Thu, 4 Jul 2013 00:23:15 +0200")
Hi Willy,
Willy Tarreau <w@1wt•eu> writes:
> The patch it too large (150kB), last time I received a warning from the ML
> because of its size.
>
> [snip]
>
> Feel free to host this driver anywhere if you like, I don't have the
> time to maintain it, and I don't want to see it merged into the kernel,
> we have enough crap and this one certainly qualifies as such.
;-)
> Oh last important point, I found it in the 2.6.35.9-LSP-1.0.2_gw patch.
> If someone finds a more recent one in a more recent kernel, it might be
> worth comparing them.
The version in Netgear kernel (a 3.0.56, 25/Apr/2012 KW40 LSP release
3.1.0-NQ) is almost identical to the one in mirabox 2.6.35 kernel
(24/Nov/2011, KW40 LSP release 1.0.2-NQ) if you remove the fixes for
trailing spaces and tabs:
@@ -1618,7 +1618,9 @@
ret = -ENXIO;
goto fail_free_irq;
}
- if (mtd_has_partitions()) {
+
+
+#ifdef CONFIG_MTD_CMDLINE_PARTS
if (mtd_has_cmdlinepart()) {
static const char *probes[] = { "cmdlinepart", NULL };
struct mtd_partition *parts;
@@ -1627,12 +1629,11 @@
nr_parts = parse_mtd_partitions(mtd, probes, &parts, 0);
if (nr_parts)
- return add_mtd_partitions(mtd, parts, nr_parts);
+ return mtd_device_register(mtd, parts, nr_parts);
}
- return add_mtd_partitions(mtd, pdata->parts, pdata->nr_parts);
- }
-
- return add_mtd_device(mtd) == 1 ? -ENODEV : 0;
+ return mtd_device_register(mtd, pdata->parts, pdata->nr_parts);
+#endif
+ return (mtd_device_register(mtd, pdata->parts, pdata->nr_parts));
fail_free_irq:
free_irq(IRQ_AURORA_NFC, info);
@@ -1661,10 +1662,6 @@
platform_set_drvdata(pdev, NULL);
- del_mtd_device(mtd);
-#ifdef CONFIG_MTD_PARTITIONS
- del_mtd_partitions(mtd);
-#endif
free_irq(IRQ_AURORA_NFC, info);
if (info->use_dma) {
dma_free_writecombine(&pdev->dev, info->data_buff_size,
@@ -1675,7 +1672,10 @@
clk_disable(info->clk);
clk_put(info->clk);
#endif
- kfree(mtd);
+ if (mtd) {
+ mtd_device_unregister(mtd);
+ kfree(mtd);
+ }
return 0;
}
next prev parent reply other threads:[~2013-07-03 22:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-30 20:59 [RFC] Add .dts file for Netgear ReadyNAS 102 Arnaud Ebalard
2013-07-02 12:46 ` Jason Cooper
2013-07-02 13:14 ` Thomas Petazzoni
2013-07-02 13:33 ` Jason Cooper
2013-07-02 13:38 ` Thomas Petazzoni
2013-07-02 13:44 ` Jason Cooper
2013-07-02 13:49 ` Willy Tarreau
2013-07-02 14:24 ` Jason Cooper
2013-07-02 17:22 ` Arnaud Ebalard
2013-07-02 17:41 ` Jason Cooper
2013-07-02 21:48 ` Arnaud Ebalard
[not found] ` <20130702220936.GC10215@1wt.eu>
2013-07-02 23:23 ` Ezequiel Garcia
2013-07-03 4:33 ` Willy Tarreau
2013-07-03 22:33 ` Ezequiel Garcia
2013-07-03 22:38 ` Willy Tarreau
2013-07-03 7:42 ` Thomas Petazzoni
2013-07-03 13:00 ` Ezequiel Garcia
2013-07-03 19:07 ` Willy Tarreau
2013-07-03 19:10 ` Jason Cooper
2013-07-03 19:38 ` Willy Tarreau
2013-07-03 19:39 ` Jason Cooper
2013-07-04 13:59 ` Thomas Petazzoni
2013-07-04 14:01 ` Willy Tarreau
2013-07-04 17:33 ` Jason Cooper
2013-07-03 20:21 ` Jason Cooper
2013-07-03 20:35 ` Willy Tarreau
2013-07-03 20:44 ` Jason Cooper
2013-07-03 21:14 ` Willy Tarreau
2013-07-03 22:23 ` Willy Tarreau
2013-07-03 22:58 ` Arnaud Ebalard [this message]
2013-07-04 6:15 ` Willy Tarreau
2013-07-03 21:05 ` Arnaud Ebalard
2013-07-02 17:21 ` Arnaud Ebalard
2013-07-02 17:38 ` Jason Cooper
2013-07-02 13:48 ` Sebastian Hesselbarth
2013-07-02 23:27 ` Arnaud Ebalard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761wrp7y5.fsf@natisbad.org \
--to=arno@natisbad$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox