From: arno@natisbad•org (Arnaud Ebalard)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC] Add .dts file for Netgear ReadyNAS 102
Date: Wed, 03 Jul 2013 01:27:31 +0200 [thread overview]
Message-ID: <87vc4stue4.fsf@natisbad.org> (raw)
In-Reply-To: <51D2DA18.3020905@gmail.com> (Sebastian Hesselbarth's message of "Tue, 02 Jul 2013 15:48:08 +0200")
Hi,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com> writes:
>> + pinctrl {
>> + power_led_pin: power-led-pin {
>> + marvell,pins = "mpp57";
>> + marvell,function = "gpio";
>> + };
>> + sata1_led_pin: sata1-led-pin {
>> + marvell,pins = "mpp15";
>> + marvell,function = "gpio";
>> + };
>> +
>> + sata2_led_pin: sata2-led-pin {
>> + marvell,pins = "mpp14";
>> + marvell,function = "gpio";
>> + };
>> +
>> + backup_led_pin: backup-led-pin {
>> + marvell,pins = "mpp56";
>> + marvell,function = "gpio";
>> + };
>> + };
>> +
>> + gpio_leds {
>
> Arnaud,
>
> gpio_leds, gpio_keys, and clocks nodes shouldn't be children of
> soc/internal-regs. I suggest to move them up as siblings of soc,
> memory, and chosen instead.
Will do that in next round. Thanks for pointing it.
Cheers,
a+
prev parent reply other threads:[~2013-07-02 23:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-30 20:59 [RFC] Add .dts file for Netgear ReadyNAS 102 Arnaud Ebalard
2013-07-02 12:46 ` Jason Cooper
2013-07-02 13:14 ` Thomas Petazzoni
2013-07-02 13:33 ` Jason Cooper
2013-07-02 13:38 ` Thomas Petazzoni
2013-07-02 13:44 ` Jason Cooper
2013-07-02 13:49 ` Willy Tarreau
2013-07-02 14:24 ` Jason Cooper
2013-07-02 17:22 ` Arnaud Ebalard
2013-07-02 17:41 ` Jason Cooper
2013-07-02 21:48 ` Arnaud Ebalard
[not found] ` <20130702220936.GC10215@1wt.eu>
2013-07-02 23:23 ` Ezequiel Garcia
2013-07-03 4:33 ` Willy Tarreau
2013-07-03 22:33 ` Ezequiel Garcia
2013-07-03 22:38 ` Willy Tarreau
2013-07-03 7:42 ` Thomas Petazzoni
2013-07-03 13:00 ` Ezequiel Garcia
2013-07-03 19:07 ` Willy Tarreau
2013-07-03 19:10 ` Jason Cooper
2013-07-03 19:38 ` Willy Tarreau
2013-07-03 19:39 ` Jason Cooper
2013-07-04 13:59 ` Thomas Petazzoni
2013-07-04 14:01 ` Willy Tarreau
2013-07-04 17:33 ` Jason Cooper
2013-07-03 20:21 ` Jason Cooper
2013-07-03 20:35 ` Willy Tarreau
2013-07-03 20:44 ` Jason Cooper
2013-07-03 21:14 ` Willy Tarreau
2013-07-03 22:23 ` Willy Tarreau
2013-07-03 22:58 ` Arnaud Ebalard
2013-07-04 6:15 ` Willy Tarreau
2013-07-03 21:05 ` Arnaud Ebalard
2013-07-02 17:21 ` Arnaud Ebalard
2013-07-02 17:38 ` Jason Cooper
2013-07-02 13:48 ` Sebastian Hesselbarth
2013-07-02 23:27 ` Arnaud Ebalard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vc4stue4.fsf@natisbad.org \
--to=arno@natisbad$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox