From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH-V5 3/3] ARM: OMAP: Make OMAP clocksource source selection using kernel param
Date: Tue, 01 May 2012 10:03:49 -0700 [thread overview]
Message-ID: <8762cfj0ju.fsf@ti.com> (raw)
In-Reply-To: <79CD15C6BA57404B839C016229A409A83EA000B5@DBDE01.ent.ti.com> (Vaibhav Hiremath's message of "Fri, 27 Apr 2012 05:31:07 +0000")
"Hiremath, Vaibhav" <hvaibhav@ti•com> writes:
> On Fri, Apr 27, 2012 at 04:08:07, Paul Walmsley wrote:
>> On Thu, 26 Apr 2012, Paul Walmsley wrote:
>>
>> > Okay, thanks for testing. Please do update this patch to use
>> > omap_hwmod_enable(), etc.; see for example omap_dm_timer_init_one().
>>
>> And, just to be explicit, the ioremap(), clk_get(), and clk_enable()
>> should no longer be needed for OMAP2+, once you add the
>> omap_hwmod_enable().
>>
>
> What about OMAP1 architecture? Will it work?
You'll need to move the ioremap/clk* usage into OMAP1 code
(mach-omap1/timer32k.c), and move the omap_hwmod_enable() into OMAP2+
code (mach-omap2/timer.c).
Then make the omap_init_clocksource_32k() just take the base address.
If counter_32k were a real driver (and it should be) this is how things
would work. For example, the GPIO driver is shared between OMAP1 and
OMAP2+ and any SoC specific init is done in the SoC specific device init
code instead of the driver.
Hope this helps,
Kevin
next prev parent reply other threads:[~2012-05-01 17:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 13:58 [PATCH-V5 0/3] ARM: OMAP: Make OMAP clocksource source selection runtime Vaibhav Hiremath
2012-04-25 13:58 ` [PATCH-V5 1/3] ARM: OMAP2/3: Add idle_st bits for ST_32KSYNC timer to prcm-common header Vaibhav Hiremath
2012-04-26 19:25 ` Paul Walmsley
2012-04-25 13:58 ` [PATCH-V5 2/3] ARM: OMAP2/3: hwmod data: Add 32k-sync timer data to hwmod database Vaibhav Hiremath
2012-04-26 19:26 ` Paul Walmsley
2012-04-25 13:59 ` [PATCH-V5 3/3] ARM: OMAP: Make OMAP clocksource source selection using kernel param Vaibhav Hiremath
2012-04-26 15:10 ` Paul Walmsley
2012-04-26 16:20 ` Hiremath, Vaibhav
2012-04-26 16:40 ` Hiremath, Vaibhav
2012-04-26 19:30 ` Paul Walmsley
2012-04-26 22:38 ` Paul Walmsley
2012-04-27 5:31 ` Hiremath, Vaibhav
2012-05-01 17:03 ` Kevin Hilman [this message]
2012-04-26 22:26 ` Kevin Hilman
2012-04-27 5:51 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762cfj0ju.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox