* [PATCH] arm64: dt marvell: extend AP806 system controller size @ 2017-09-15 7:50 Baruch Siach 2017-09-19 14:25 ` Gregory CLEMENT 2017-09-19 14:39 ` Gregory CLEMENT 0 siblings, 2 replies; 5+ messages in thread From: Baruch Siach @ 2017-09-15 7:50 UTC (permalink / raw) To: linux-arm-kernel Extend the container size to 0x2000 to include the gpio controller at offset 0x1040. While at it, add start address notation to the gpio node name to match its 'offset' property. Signed-off-by: Baruch Siach <baruch@tkos•co.il> --- arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi index 4d360713ed12..30d48ecf46e0 100644 --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi @@ -254,7 +254,7 @@ ap_syscon: system-controller at 6f4000 { compatible = "syscon", "simple-mfd"; - reg = <0x6f4000 0x1000>; + reg = <0x6f4000 0x2000>; ap_clk: clock { compatible = "marvell,ap806-clock"; @@ -265,7 +265,7 @@ compatible = "marvell,ap806-pinctrl"; }; - ap_gpio: gpio { + ap_gpio: gpio at 1040 { compatible = "marvell,armada-8k-gpio"; offset = <0x1040>; ngpios = <20>; -- 2.14.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] arm64: dt marvell: extend AP806 system controller size 2017-09-15 7:50 [PATCH] arm64: dt marvell: extend AP806 system controller size Baruch Siach @ 2017-09-19 14:25 ` Gregory CLEMENT 2017-09-19 16:08 ` Baruch Siach 2017-09-19 14:39 ` Gregory CLEMENT 1 sibling, 1 reply; 5+ messages in thread From: Gregory CLEMENT @ 2017-09-19 14:25 UTC (permalink / raw) To: linux-arm-kernel Hi Baruch, On ven., sept. 15 2017, Baruch Siach <baruch@tkos•co.il> wrote: > Extend the container size to 0x2000 to include the gpio controller at > offset 0x1040. > > While at it, add start address notation to the gpio node name to match > its 'offset' property. > > Signed-off-by: Baruch Siach <baruch@tkos•co.il> I made a quick test on a mcbin and I confirm that the watchdog is here and usable. Tested-by: Gregory CLEMENT <gregory.clement@free-electrons•com> and Applied on mvebu/dt64 Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > index 4d360713ed12..30d48ecf46e0 100644 > --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > @@ -254,7 +254,7 @@ > > ap_syscon: system-controller at 6f4000 { > compatible = "syscon", "simple-mfd"; > - reg = <0x6f4000 0x1000>; > + reg = <0x6f4000 0x2000>; > > ap_clk: clock { > compatible = "marvell,ap806-clock"; > @@ -265,7 +265,7 @@ > compatible = "marvell,ap806-pinctrl"; > }; > > - ap_gpio: gpio { > + ap_gpio: gpio at 1040 { > compatible = "marvell,armada-8k-gpio"; > offset = <0x1040>; > ngpios = <20>; > -- > 2.14.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: dt marvell: extend AP806 system controller size 2017-09-19 14:25 ` Gregory CLEMENT @ 2017-09-19 16:08 ` Baruch Siach 2017-09-20 7:51 ` Gregory CLEMENT 0 siblings, 1 reply; 5+ messages in thread From: Baruch Siach @ 2017-09-19 16:08 UTC (permalink / raw) To: linux-arm-kernel Hi Gregory, On Tue, Sep 19, 2017 at 04:25:58PM +0200, Gregory CLEMENT wrote: > On ven., sept. 15 2017, Baruch Siach <baruch@tkos•co.il> wrote: > > > Extend the container size to 0x2000 to include the gpio controller at > > offset 0x1040. > > > > While at it, add start address notation to the gpio node name to match > > its 'offset' property. > > > > Signed-off-by: Baruch Siach <baruch@tkos•co.il> > > I made a quick test on a mcbin and I confirm that the watchdog is here > and usable. > > Tested-by: Gregory CLEMENT <gregory.clement@free-electrons•com> > and > Applied on mvebu/dt64 This is meant to be a reply to https://patchwork.kernel.org/patch/9947525/, right? Anyway, I see the right patch[1] at mvebu/dt64. Thanks, baruch [1] http://git.infradead.org/linux-mvebu.git/commitdiff/e34ffe32f6e7ae9191d14226ff9d8c0c47400a71 > > --- > > arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > > index 4d360713ed12..30d48ecf46e0 100644 > > --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > > +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > > @@ -254,7 +254,7 @@ > > > > ap_syscon: system-controller at 6f4000 { > > compatible = "syscon", "simple-mfd"; > > - reg = <0x6f4000 0x1000>; > > + reg = <0x6f4000 0x2000>; > > > > ap_clk: clock { > > compatible = "marvell,ap806-clock"; > > @@ -265,7 +265,7 @@ > > compatible = "marvell,ap806-pinctrl"; > > }; > > > > - ap_gpio: gpio { > > + ap_gpio: gpio at 1040 { > > compatible = "marvell,armada-8k-gpio"; > > offset = <0x1040>; > > ngpios = <20>; -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: dt marvell: extend AP806 system controller size 2017-09-19 16:08 ` Baruch Siach @ 2017-09-20 7:51 ` Gregory CLEMENT 0 siblings, 0 replies; 5+ messages in thread From: Gregory CLEMENT @ 2017-09-20 7:51 UTC (permalink / raw) To: linux-arm-kernel Hi Baruch, On mar., sept. 19 2017, Baruch Siach <baruch@tkos•co.il> wrote: > Hi Gregory, > > On Tue, Sep 19, 2017 at 04:25:58PM +0200, Gregory CLEMENT wrote: >> On ven., sept. 15 2017, Baruch Siach <baruch@tkos•co.il> wrote: >> >> > Extend the container size to 0x2000 to include the gpio controller at >> > offset 0x1040. >> > >> > While at it, add start address notation to the gpio node name to match >> > its 'offset' property. >> > >> > Signed-off-by: Baruch Siach <baruch@tkos•co.il> >> >> I made a quick test on a mcbin and I confirm that the watchdog is here >> and usable. >> >> Tested-by: Gregory CLEMENT <gregory.clement@free-electrons•com> >> and >> Applied on mvebu/dt64 > > This is meant to be a reply to https://patchwork.kernel.org/patch/9947525/, > right? Yes! Sorry for hte confusion. > > Anyway, I see the right patch[1] at mvebu/dt64. > > Thanks, > baruch > > [1] http://git.infradead.org/linux-mvebu.git/commitdiff/e34ffe32f6e7ae9191d14226ff9d8c0c47400a71 > >> > --- >> > arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi >> > index 4d360713ed12..30d48ecf46e0 100644 >> > --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi >> > +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi >> > @@ -254,7 +254,7 @@ >> > >> > ap_syscon: system-controller at 6f4000 { >> > compatible = "syscon", "simple-mfd"; >> > - reg = <0x6f4000 0x1000>; >> > + reg = <0x6f4000 0x2000>; >> > >> > ap_clk: clock { >> > compatible = "marvell,ap806-clock"; >> > @@ -265,7 +265,7 @@ >> > compatible = "marvell,ap806-pinctrl"; >> > }; >> > >> > - ap_gpio: gpio { >> > + ap_gpio: gpio at 1040 { >> > compatible = "marvell,armada-8k-gpio"; >> > offset = <0x1040>; >> > ngpios = <20>; > > -- > http://baruch.siach.name/blog/ ~. .~ Tk Open Systems > =}------------------------------------------------ooO--U--Ooo------------{= > - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: dt marvell: extend AP806 system controller size 2017-09-15 7:50 [PATCH] arm64: dt marvell: extend AP806 system controller size Baruch Siach 2017-09-19 14:25 ` Gregory CLEMENT @ 2017-09-19 14:39 ` Gregory CLEMENT 1 sibling, 0 replies; 5+ messages in thread From: Gregory CLEMENT @ 2017-09-19 14:39 UTC (permalink / raw) To: linux-arm-kernel Hi Baruch, On ven., sept. 15 2017, Baruch Siach <baruch@tkos•co.il> wrote: > Extend the container size to 0x2000 to include the gpio controller at > offset 0x1040. > Actually it is a fix as I don't see how we can use the gpio if it is not in the range. So I amended your patch by adding: Fixes: 63dac0f4924b ("arm64: dts: marvell: add gpio support for Armada 7K/8K") Cc: <stable@vger•kernel.org> And I also modified the title to: arm64: dt marvell: Fix AP806 system controller size > While at it, add start address notation to the gpio node name to match > its 'offset' property. > > Signed-off-by: Baruch Siach <baruch@tkos•co.il> Applied on mvebu/fixes Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > index 4d360713ed12..30d48ecf46e0 100644 > --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > @@ -254,7 +254,7 @@ > > ap_syscon: system-controller at 6f4000 { > compatible = "syscon", "simple-mfd"; > - reg = <0x6f4000 0x1000>; > + reg = <0x6f4000 0x2000>; > > ap_clk: clock { > compatible = "marvell,ap806-clock"; > @@ -265,7 +265,7 @@ > compatible = "marvell,ap806-pinctrl"; > }; > > - ap_gpio: gpio { > + ap_gpio: gpio at 1040 { > compatible = "marvell,armada-8k-gpio"; > offset = <0x1040>; > ngpios = <20>; > -- > 2.14.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-20 7:51 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-09-15 7:50 [PATCH] arm64: dt marvell: extend AP806 system controller size Baruch Siach 2017-09-19 14:25 ` Gregory CLEMENT 2017-09-19 16:08 ` Baruch Siach 2017-09-20 7:51 ` Gregory CLEMENT 2017-09-19 14:39 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox