From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 1/4] gpio: mvebu: Add limited PWM support
Date: Wed, 31 May 2017 14:36:21 +0200 [thread overview]
Message-ID: <87bmq9td8a.fsf@free-electrons.com> (raw)
In-Reply-To: <20170531142614.5f32fca6@gmail.com> (Ralph Sennhauser's message of "Wed, 31 May 2017 14:26:14 +0200")
Hi Ralph,
On mer., mai 31 2017, Ralph Sennhauser <ralph.sennhauser@gmail•com> wrote:
> On Tue, 30 May 2017 17:35:33 +0200
> Richard Genoud <richard.genoud@gmail•com> wrote:
>
>> Hi Ralph,
>>
>> I have the functional spec (no NDA needed, but it's not the full
>> one) : A38x-Functional-Spec-PU0A.pdf
>> https://marvellcorp.wufoo.com/forms/marvell-armada-38x-functional-specifications/
>> (just an email needed, no blood signing nor chicken slaughtering)
>> There are the GPIO Blink Counter A/B is ON/OFF Duration Registers as
>> well as the Blink Enable Registers.
>>
>
> Hi Richard,
>
> Thanks for the link, as the terms only talk about materials obtained
> from www.marvell.com this one from wufoo.com should be exempt ;)
> Also at a glance looks like the complete one. Also says "Functional
> Specifications ? Unrestricted". Maybe you want to re-download it.
>
> Regardless, as you said the blinking registers are all described. So
> it's probably safe to assume 39x will have them as well.
I guess you meant 38x. (But I suppose it is also true for 39x)
>
>> I've done a pwm with different periods (8ms, 4ms, 100ns).
>> Looking at the scope, it seems to work pretty well :)
>>
>> >>
>> >> And it makes me realized that I missed the bad naming of the
>> >> compatible string. We don't use family name for the compatible
>> >> string, but the name of the first SoC compatible with. So in this
>> >> case we should use "marvell,armada-370", as it is still in rc and
>> >> not yet deployed. What about fixing the name now?
>
> Gregory,
>
> Knowing it's not limited to 370/XP makes "marvell,armada-370-gpio" an
> obviously better choice for the compatible string. Guess you didn't
> mean to drop the "-gpio" suffix.
You're right I meant "marvell,armada-370-gpio".
>
> Will work on a patch changing the compatible string / documentation for
> 4.12 and an updated patch for armada 370/XP dtsi as well as a patch
> adding the properties to 38x for 4.13+. Expect them tomorrow, probably
> won't get around to it today anymore.
Great!
Thanks,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-05-31 12:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 15:40 [PATCH v5 0/4] gpio: mvebu: Add PWM fan support Ralph Sennhauser
2017-04-14 15:40 ` [PATCH v6 1/4] gpio: mvebu: Add limited PWM support Ralph Sennhauser
2017-04-24 9:18 ` Linus Walleij
2017-05-30 13:40 ` Gregory CLEMENT
2017-05-30 14:51 ` Ralph Sennhauser
2017-05-30 15:35 ` Richard Genoud
2017-05-31 12:26 ` Ralph Sennhauser
2017-05-31 12:36 ` Gregory CLEMENT [this message]
2017-04-14 15:40 ` [PATCH v6 2/4] ARM: dts: mvebu: Add PWM properties to .dtsi files Ralph Sennhauser
2017-04-24 9:19 ` Linus Walleij
2017-05-05 7:41 ` Ralph Sennhauser
2017-05-05 8:09 ` Gregory CLEMENT
2017-05-05 8:15 ` Ralph Sennhauser
2017-05-23 13:53 ` Gregory CLEMENT
2017-04-14 15:40 ` [PATCH v6 3/4] ARM: mvebu: Enable SENSORS_PWM_FAN in defconfig Ralph Sennhauser
2017-04-24 9:20 ` Linus Walleij
2017-05-23 14:00 ` Gregory CLEMENT
2017-04-14 15:40 ` [PATCH v6 4/4] ARM: dts: armada-xp: Use pwm-fan rather than gpio-fan Ralph Sennhauser
2017-04-24 9:20 ` Linus Walleij
2017-05-23 13:53 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmq9td8a.fsf@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox