From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 1/4] gpio: mvebu: Add limited PWM support
Date: Tue, 30 May 2017 15:40:00 +0200 [thread overview]
Message-ID: <87tw42tqdr.fsf@free-electrons.com> (raw)
In-Reply-To: <CACRpkdYPp6pBemTT_a4V6a-Qbk2475qOOxWJOhfVaEz=cojOvA@mail.gmail.com> (Linus Walleij's message of "Mon, 24 Apr 2017 11:18:30 +0200")
Hi Ralph and Linus,
I resurrect this thread following the series post by Richard Genoud:
http://lists.infradead.org/pipermail/linux-arm-kernel/2017-May/509461.html
On lun., avril 24 2017, Linus Walleij <linus.walleij@linaro•org> wrote:
> On Fri, Apr 14, 2017 at 5:40 PM, Ralph Sennhauser
> <ralph.sennhauser@gmail•com> wrote:
>
>> From: Andrew Lunn <andrew@lunn•ch>
>>
>> Armada 370/XP devices can 'blink' GPIO lines with a configurable on
>> and off period. This can be modelled as a PWM.
>>
>> However, there are only two sets of PWM configuration registers for
>> all the GPIO lines. This driver simply allows a single GPIO line per
>> GPIO chip of 32 lines to be used as a PWM. Attempts to use more return
>> EBUSY.
>>
>> Due to the interleaving of registers it is not simple to separate the
>> PWM driver from the GPIO driver. Thus the GPIO driver has been
>> extended with a PWM driver.
>>
>> Signed-off-by: Andrew Lunn <andrew@lunn•ch>
>> URL: https://patchwork.ozlabs.org/patch/427287/
>> URL: https://patchwork.ozlabs.org/patch/427295/
>> [Ralph Sennhauser:
>> * Port forward
>> * Merge PWM portion into gpio-mvebu.c
>> * Switch to atomic PWM API
>> * Add new compatible string marvell,armada-370-xp-gpio
The fact that Richard managed to run the code on Armada 38x draw my
attention on the documentation that need to be amend.
And it makes me realized that I missed the bad naming of the compatible
string. We don't use family name for the compatible string, but the name
of the first SoC compatible with. So in this case we should use
"marvell,armada-370", as it is still in rc and not yet deployed. What
about fixing the name now?
I can send a patch for it if you want and fix the dts that are still in
my mvebu branch.
Thanks,
Gregory
>> * Update and merge documentation patch
>> * Update MAINTAINERS]
>> Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail•com>
>> Tested-by: Andrew Lunn <andrew@lunn•ch>
>> Acked-by: Thierry Reding <thierry.reding@gmail•com>
>> Acked-by: Rob Herring <robh@kernel•org>
>
> Patch applied.
>
> Yours,
> Linus Walleij
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-05-30 13:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 15:40 [PATCH v5 0/4] gpio: mvebu: Add PWM fan support Ralph Sennhauser
2017-04-14 15:40 ` [PATCH v6 1/4] gpio: mvebu: Add limited PWM support Ralph Sennhauser
2017-04-24 9:18 ` Linus Walleij
2017-05-30 13:40 ` Gregory CLEMENT [this message]
2017-05-30 14:51 ` Ralph Sennhauser
2017-05-30 15:35 ` Richard Genoud
2017-05-31 12:26 ` Ralph Sennhauser
2017-05-31 12:36 ` Gregory CLEMENT
2017-04-14 15:40 ` [PATCH v6 2/4] ARM: dts: mvebu: Add PWM properties to .dtsi files Ralph Sennhauser
2017-04-24 9:19 ` Linus Walleij
2017-05-05 7:41 ` Ralph Sennhauser
2017-05-05 8:09 ` Gregory CLEMENT
2017-05-05 8:15 ` Ralph Sennhauser
2017-05-23 13:53 ` Gregory CLEMENT
2017-04-14 15:40 ` [PATCH v6 3/4] ARM: mvebu: Enable SENSORS_PWM_FAN in defconfig Ralph Sennhauser
2017-04-24 9:20 ` Linus Walleij
2017-05-23 14:00 ` Gregory CLEMENT
2017-04-14 15:40 ` [PATCH v6 4/4] ARM: dts: armada-xp: Use pwm-fan rather than gpio-fan Ralph Sennhauser
2017-04-24 9:20 ` Linus Walleij
2017-05-23 13:53 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw42tqdr.fsf@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox