From: khilman@linaro•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 3/3] ARM: DTS: TWL4030: fix mux and wakeup for SYS_NIRQ line
Date: Fri, 07 Jun 2013 09:59:14 -0700 [thread overview]
Message-ID: <87fvwtn9gd.fsf@linaro.org> (raw)
In-Reply-To: <20130606234201.GA26919@kahuna> (Nishanth Menon's message of "Thu, 6 Jun 2013 18:42:01 -0500")
Nishanth Menon <nm@ti•com> writes:
> On 16:27-20130606, Kevin Hilman wrote:
>> On most OMAP3 platforms, the twl4030 IRQ line is connected to the
>> SYS_NIRQ line on OMAP. Add another DTS include file
>> (twl4030_omap3_mux.dtsi) for boards that hook up the twl4030 this way
>> to include.
>>
>> This allows RTC wake from off-mode to work again on OMAP3-based
>> platforms with twl4030. Tested on 3530/Beagle, 3730/Beagle-xM,
>> 3530/Overo, 3730/Overo-STORM.
>>
>> Special thanks to Florian Vaussard for suggesting use of preprocessor
>> feature.
>>
>> Cc: Florian Vaussard <florian.vaussard@epfl•ch>
>> Cc: Benoit Cousson <b-cousson@ti•com>
>> Signed-off-by: Kevin Hilman <khilman@linaro•org>
>> ---
>> v2: Updated to change board files instead of twl4030 file.
>>
>> arch/arm/boot/dts/omap3-beagle-xm.dts | 1 +
>> arch/arm/boot/dts/omap3-beagle.dts | 1 +
>> arch/arm/boot/dts/omap3-devkit8000.dts | 1 +
>> arch/arm/boot/dts/omap3-evm.dts | 1 +
>> arch/arm/boot/dts/omap3-igep.dtsi | 1 +
>> arch/arm/boot/dts/omap3-overo.dtsi | 1 +
>> arch/arm/boot/dts/omap3430-sdp.dts | 1 +
>> arch/arm/boot/dts/twl4030_omap3_mux.dtsi | 17 +++++++++++++++++
> minor comment:
> can we do twl4030_omap3 instead? That way, I can add in twl4030 VP
> specific parameters which are OMAP3 specific?
Good idea, I'll rename it to twl4030_omap3.dtsi
[...]
>> diff --git a/arch/arm/boot/dts/twl4030_omap3_mux.dtsi b/arch/arm/boot/dts/twl4030_omap3_mux.dtsi
>> new file mode 100644
>> index 0000000..1bd0f9f
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/twl4030_omap3_mux.dtsi
>> @@ -0,0 +1,17 @@
> some license text?
oops
>> +&twl {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&twl4030_pins>;
>> +};
>> +
>> +&omap3_pmx_core {
>> + /*
>> + * On most OMAP3 platforms, the twl4030 IRQ line is connected
>> + * to the SYS_NIRQ line on OMAP. Therefore, configure the
>> + * defaults for the SYS_NIRQ pin here.
> ^^^ tab?
good catch.
Thanks for the review, will make the changes and resubmit.
Kevin
next prev parent reply other threads:[~2013-06-07 16:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 22:45 [PATCH 0/3] ARM: DTS: misc. OMAP3 fixes for proper wakeup Kevin Hilman
2013-05-31 22:45 ` [PATCH 1/3] ARM: DTS: OMAP3: beagle/overo: mux console UART, enable wakeup Kevin Hilman
2013-06-03 9:36 ` Florian Vaussard
2013-06-03 21:26 ` Kevin Hilman
2013-05-31 22:45 ` [PATCH 2/3] ARM: DTS: OMAP3: beagle: enable user button via gpio_keys, " Kevin Hilman
2013-06-03 9:40 ` Florian Vaussard
2013-05-31 22:45 ` [PATCH 3/3] ARM: DTS: TWL4030: fix mux and wakeup for SYS_NIRQ line Kevin Hilman
2013-06-03 9:48 ` Florian Vaussard
2013-06-03 22:19 ` Kevin Hilman
2013-06-03 22:39 ` Jason Cooper
2013-06-04 17:58 ` Kevin Hilman
2013-06-04 18:05 ` Jason Cooper
2013-06-05 7:41 ` Florian Vaussard
2013-06-05 13:52 ` Benoit Cousson
2013-06-05 14:26 ` Kevin Hilman
2013-06-06 23:27 ` [PATCH v2 " Kevin Hilman
2013-06-06 23:42 ` Nishanth Menon
2013-06-07 16:59 ` Kevin Hilman [this message]
2013-06-07 18:31 ` [PATCH v3] " Kevin Hilman
2013-06-07 19:31 ` Nishanth Menon
2013-06-10 9:22 ` Benoit Cousson
2013-06-10 16:40 ` Kevin Hilman
2013-06-11 11:33 ` Cousson, Benoit
2013-06-11 11:43 ` Benoit Cousson
2013-06-11 14:30 ` Kevin Hilman
2013-06-19 1:25 ` Benoit Cousson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvwtn9gd.fsf@linaro.org \
--to=khilman@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox