From: khilman@linaro•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] ARM: DTS: TWL4030: fix mux and wakeup for SYS_NIRQ line
Date: Wed, 05 Jun 2013 07:26:41 -0700 [thread overview]
Message-ID: <87mwr4zl9a.fsf@linaro.org> (raw)
In-Reply-To: <51AF4289.50602@ti.com> (Benoit Cousson's message of "Wed, 5 Jun 2013 15:52:09 +0200")
Benoit Cousson <b-cousson@ti•com> writes:
> Salut Kevin,
>
> On 06/04/2013 12:19 AM, Kevin Hilman wrote:
>> Florian Vaussard <florian.vaussard@epfl•ch> writes:
>>
>>> Hello Kevin,
>>>
>>> On 06/01/2013 12:45 AM, Kevin Hilman wrote:
>>>> On most OMAP3 platforms, the twl4030 IRQ line is connected to the
>>>> SYS_NIRQ line on OMAP. Therefore, configure the defaults for the
>>>> SYS_NIRQ pin in the twl4030 DTS file.
>>>>
>>>> Boards that hook up the twl4030 differently can easily override this
>>>> in their board-specific DTS file.
>>>>
>>>> This allows RTC wake from off-mode to work again on OMAP3-based
>>>> platforms with twl4030. Tested on 3530/Beagle, 3730/Beagle-xM,
>>>> 3530/Overo, 3730/Overo-STORM.
>>>>
>>>> Signed-off-by: Kevin Hilman <khilman@linaro•org>
>>>> ---
>>>> arch/arm/boot/dts/twl4030.dtsi | 17 +++++++++++++++++
>>>> 1 file changed, 17 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi
>>>> index b3034da..c7fe9f6 100644
>>>> --- a/arch/arm/boot/dts/twl4030.dtsi
>>>> +++ b/arch/arm/boot/dts/twl4030.dtsi
>>>> @@ -13,6 +13,8 @@
>>>> compatible = "ti,twl4030";
>>>> interrupt-controller;
>>>> #interrupt-cells = <1>;
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&twl4030_pins>;
>>>>
>>>> rtc {
>>>> compatible = "ti,twl4030-rtc";
>>>> @@ -92,3 +94,18 @@
>>>> #pwm-cells = <2>;
>>>> };
>>>> };
>>>> +
>>>> +&omap3_pmx_core {
>>>
>>> Here you are making the TWL4030 to explicitly depend on OMAP3. Could
>>> this chip be used by another target? If the case, I would put this
>>> piece of code in the files including twl4030. Otherwise it's ok here.
>>
>> I talked this over with Tony before posting. In theorry, it could be
>> used on other platforms. In practice, it's only used on OMAP. We can
>> easily move this to board files if needed later, but thought it would be
>> simpler to put it here. I'll let Benoit decide.
>
> Yeah, I don't like that either. Some twl variants are used on other
> platform. And these variants might include the original twl4030 as a
> base. None of them are in mainline for sure, but anyway adding SoC stuff
> in external IC file is not a good practice.
>
> I don't want people in the future using that as an excuse for similar hacks.
>
> The easiest way is to create an extra file including the platform free
> twl4030 file and adding the OMAP3 specific config on top of that.
> Every OMAP3 boards will the used that file. Otherwise you can hack each
> boards.
Yeah, somehow I knew you would say that. I'll respin.
Kevin
next prev parent reply other threads:[~2013-06-05 14:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 22:45 [PATCH 0/3] ARM: DTS: misc. OMAP3 fixes for proper wakeup Kevin Hilman
2013-05-31 22:45 ` [PATCH 1/3] ARM: DTS: OMAP3: beagle/overo: mux console UART, enable wakeup Kevin Hilman
2013-06-03 9:36 ` Florian Vaussard
2013-06-03 21:26 ` Kevin Hilman
2013-05-31 22:45 ` [PATCH 2/3] ARM: DTS: OMAP3: beagle: enable user button via gpio_keys, " Kevin Hilman
2013-06-03 9:40 ` Florian Vaussard
2013-05-31 22:45 ` [PATCH 3/3] ARM: DTS: TWL4030: fix mux and wakeup for SYS_NIRQ line Kevin Hilman
2013-06-03 9:48 ` Florian Vaussard
2013-06-03 22:19 ` Kevin Hilman
2013-06-03 22:39 ` Jason Cooper
2013-06-04 17:58 ` Kevin Hilman
2013-06-04 18:05 ` Jason Cooper
2013-06-05 7:41 ` Florian Vaussard
2013-06-05 13:52 ` Benoit Cousson
2013-06-05 14:26 ` Kevin Hilman [this message]
2013-06-06 23:27 ` [PATCH v2 " Kevin Hilman
2013-06-06 23:42 ` Nishanth Menon
2013-06-07 16:59 ` Kevin Hilman
2013-06-07 18:31 ` [PATCH v3] " Kevin Hilman
2013-06-07 19:31 ` Nishanth Menon
2013-06-10 9:22 ` Benoit Cousson
2013-06-10 16:40 ` Kevin Hilman
2013-06-11 11:33 ` Cousson, Benoit
2013-06-11 11:43 ` Benoit Cousson
2013-06-11 14:30 ` Kevin Hilman
2013-06-19 1:25 ` Benoit Cousson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwr4zl9a.fsf@linaro.org \
--to=khilman@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox