From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 16/16] ARM: omap: disable cpuidle for OMAP3 platforms
Date: Wed, 08 Feb 2012 15:30:44 -0800 [thread overview]
Message-ID: <87haz0ykbf.fsf@ti.com> (raw)
In-Reply-To: <87ipjg3osg.fsf@ti.com> (Kevin Hilman's message of "Wed, 08 Feb 2012 15:09:51 -0800")
Kevin Hilman <khilman@ti•com> writes:
> Tony Lindgren <tony@atomide•com> writes:
>
>> * Russell King - ARM Linux <linux@arm•linux.org.uk> [120208 08:10]:
>>> Commit 2fd149645eb4 (ARM: OMAP2+: UART: Remove omap_uart_can_sleep and add pm_qos)
>>> has caused a regression on OMAP3 platforms.
>>>
>>> When the UART is trying to transmit data, if we enter a low power mode,
>>> transmission stops, which makes serial on OMAP3 unusable - a 'dmesg'
>>> takes five minutes to be output at 115200 baud, at a rate of around a
>>> block of 16 characters every couple of seconds.
>>>
>>> Unfortunately, the commit above can't be reverted because of many other
>>> changes in this area, so this implements a dirty fix by disabling
>>> CPU idle in the places the original commit does, irrespective of the
>>> UART state.
>> ...
>>
>>> --- a/arch/arm/mach-omap2/pm34xx.c
>>> +++ b/arch/arm/mach-omap2/pm34xx.c
>>> @@ -421,7 +421,7 @@ static void omap3_pm_idle(void)
>>> local_irq_disable();
>>> local_fiq_disable();
>>>
>>> - if (omap_irq_pending() || need_resched())
>>> + if (omap_irq_pending() || need_resched() || 1)
>>> goto out;
>>>
>>> trace_power_start(POWER_CSTATE, 1, smp_processor_id());
>>
>> Argh, this is just too ugly. There has got to be a better fix for the
>> -rc series.
>>
>> Looks like the patches to fix omap-serial.c are queued for v3.4,
>> so that won't help.
>>
>> Kevin, what do you have for the -rc fix here to avoid the if (1)
>> hack?
>
> There was confusion with Greg about this serial fixes which were
> supposed to be for -rc.
>
> He pulled the original series in to -rc, and reverted them when Paul
> updated the series. Then he decided to queue the updated series for
> 3.4. :(
>
> I've now asked Greg if he can queue that series for 3.3.
And he refused (on the 34xx thread). :(
It is a very targetted set of fixes that directly address the problems
in the UART driver, but he has decided they should wait because we went
through a couple revisions.
Maybe you can respond to Greg saying that we really need them for 3.3?
Kevin
next prev parent reply other threads:[~2012-02-08 23:30 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 16:35 [PATCH 00/16] rmk's patch series for fixing OMAP Russell King - ARM Linux
2012-02-08 16:36 ` [PATCH 01/16] ARM: omap: fix oops in arch/arm/mach-omap2/vp.c when pmic is not found Russell King - ARM Linux
2012-02-08 18:33 ` Tony Lindgren
2012-02-08 23:46 ` Tony Lindgren
2012-02-09 16:44 ` Russell King - ARM Linux
2012-02-09 16:51 ` Tony Lindgren
2012-02-08 16:37 ` [PATCH 04/16] ARM: omap: fix prm44xx.c OMAP44XX_IRQ_PRCM build error Russell King - ARM Linux
2012-02-08 18:39 ` Tony Lindgren
2012-02-09 18:58 ` Cousson, Benoit
2012-02-08 16:37 ` [PATCH 05/16] ARM: omap: fix vc.c PMIC error message Russell King - ARM Linux
2012-02-08 18:45 ` Tony Lindgren
2012-02-08 23:06 ` Kevin Hilman
2012-02-08 23:53 ` Tony Lindgren
2012-02-08 23:56 ` Russell King - ARM Linux
2012-02-09 0:09 ` Kevin Hilman
2012-02-09 0:11 ` Russell King - ARM Linux
2012-02-09 0:20 ` Kevin Hilman
2012-02-09 0:40 ` Tony Lindgren
2012-02-09 16:49 ` Russell King - ARM Linux
2012-02-09 17:18 ` Tony Lindgren
2012-02-09 17:27 ` Tony Lindgren
2012-02-09 17:59 ` Russell King - ARM Linux
2012-02-09 18:06 ` Tony Lindgren
2012-02-09 18:46 ` Tony Lindgren
2012-02-08 23:57 ` Tony Lindgren
2012-02-09 0:11 ` Kevin Hilman
2012-02-08 16:37 ` [PATCH 06/16] ARM: omap: fix uninformative vc/i2c configuration " Russell King - ARM Linux
2012-02-08 18:46 ` Tony Lindgren
2012-02-08 23:07 ` Kevin Hilman
2012-02-08 16:38 ` [PATCH 08/16] ARM: omap: fix section mismatch warning in mux.c Russell King - ARM Linux
2012-02-08 18:47 ` Tony Lindgren
2012-02-08 16:38 ` [PATCH 09/16] ARM: omap: preemptively fix section mismatch in omap4_sdp4430_wifi_mux_init() Russell King - ARM Linux
2012-02-08 18:48 ` Tony Lindgren
2012-02-08 16:39 ` [PATCH 10/16] ARM: omap: fix section mismatch warning for omap_secondary_startup() Russell King - ARM Linux
2012-02-08 18:48 ` Tony Lindgren
2012-02-08 16:39 ` [PATCH 11/16] ARM: omap: fix section mismatch error for omap_4430sdp_display_init() Russell King - ARM Linux
2012-02-08 18:48 ` Tony Lindgren
2012-02-08 16:39 ` [PATCH 12/16] ARM: omap: fix section mismatch warning for sdp3430_twl_gpio_setup() Russell King - ARM Linux
2012-02-08 18:49 ` Tony Lindgren
2012-02-08 16:40 ` [PATCH 13/16] ARM: omap: fix section mismatch warnings in mux.c caused by hsmmc.c Russell King - ARM Linux
2012-02-08 18:50 ` Tony Lindgren
2012-02-08 16:40 ` [PATCH 14/16] ARM: omap: fix wrapped error messages in omap_hwmod.c Russell King - ARM Linux
2012-02-08 17:40 ` Paul Walmsley
2012-02-08 18:54 ` Tony Lindgren
2012-02-08 19:25 ` Paul Walmsley
2012-02-08 19:31 ` Tony Lindgren
2012-02-08 16:40 ` [PATCH 15/16] ARM: omap: resolve nebulous 'Error setting wl12xx data' Russell King - ARM Linux
2012-02-08 18:56 ` Tony Lindgren
2012-02-08 16:41 ` [PATCH 16/16] ARM: omap: disable cpuidle for OMAP3 platforms Russell King - ARM Linux
2012-02-08 18:59 ` Tony Lindgren
2012-02-08 22:59 ` Russell King - ARM Linux
2012-02-08 23:09 ` Kevin Hilman
2012-02-08 23:30 ` Kevin Hilman [this message]
2012-02-08 19:06 ` [PATCH 00/16] rmk's patch series for fixing OMAP Tony Lindgren
2012-02-08 20:31 ` Florian Tobias Schandinat
2012-02-09 0:53 ` Russell King - ARM Linux
2012-02-09 7:02 ` Tomi Valkeinen
2012-02-09 8:30 ` Teresa Gamez
2012-02-09 10:24 ` Tomi Valkeinen
2012-02-09 18:00 ` [PATCH 01] ARM: omap: fix oops in arch/arm/mach-omap2/vp.c when pmic is not found Russell King - ARM Linux
2012-02-09 18:01 ` [PATCH 05] ARM: omap: fix vc.c PMIC error message Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haz0ykbf.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox