From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 05/16] ARM: omap: fix vc.c PMIC error message
Date: Wed, 08 Feb 2012 16:11:19 -0800 [thread overview]
Message-ID: <87mx8sx3vc.fsf@ti.com> (raw)
In-Reply-To: <20120208235716.GE16877@atomide.com> (Tony Lindgren's message of "Wed, 8 Feb 2012 15:57:16 -0800")
Tony Lindgren <tony@atomide•com> writes:
> * Tony Lindgren <tony@atomide•com> [120208 15:22]:
>> * Kevin Hilman <khilman@ti•com> [120208 14:35]:
>> > Tony Lindgren <tony@atomide•com> writes:
>> >
>> > > * Russell King - ARM Linux <linux@arm•linux.org.uk> [120208 08:06]:
>> > >> While testing on my OMAP3430 platform, this error message was emitted:
>> > >>
>> > >> omap_vc_init_channel: PMIC info requried to configure vc forvdd_core not populated.Hence cannot initialize vc
>> > >>
>> > >> Trying to find this message was difficult because it was wrapped across
>> > >> several lines. It also mis-spells "required", doesn't read very well,
>> > >> and has spaces lacking. Let's replace it with a more concise:
>> > >>
>> > >> omap_vc_init_channel: No PMIC info for vdd_core
>> > >>
>> > >> While we're here, fix a simple spelling error in a comment.
>> > >>
>> > >> Signed-off-by: Russell King <rmk+kernel@arm•linux.org.uk>
>> > >
>> > > Acked-by: Tony Lindgren <tony@atomide•com>
>> >
>> > NAK.
>> >
>> > Tony, please use the patches already in your cleanup branch (that came
>> > from my for_3.3/cleanup/pm) that fix this and also fix a similar problem
>> > for VP.
>>
>> Ah OK, there's the VP part there too.
>>
>> So that would be the following two patches then for me to
>> move to fixes from cleanup:
>>
>> cd63040e00ea83729673acfea1675d85fde6ea59 ARM: OMAP: voltage: cleanup VC/VP error messages
>> af9a2ed9667b49e7e125eac526d8f655183ce53e ARM: OMAP2+: voltage: add check for missing PMIC info in VP init
>>
>> And patches 1 and 5 for Russell to drop then.
>>
>> Everybody OK with that?
>
> Also, what about this one in the cleanup branch:
>
> d269914ece0498f31603ecd85ed3d7a586b3cbcd ARM: OMAP2+: PM: only register TWL with voltage layer when device is present
>
> Should that be a fix too?
>
Yes.
The AM35xx devices that don't use TWL PMICs have the problem fixed by
this patch.
Looking back, I'm not sure why I called this a cleaup branch when all
the patches are fixes.
Kevin
next prev parent reply other threads:[~2012-02-09 0:11 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 16:35 [PATCH 00/16] rmk's patch series for fixing OMAP Russell King - ARM Linux
2012-02-08 16:36 ` [PATCH 01/16] ARM: omap: fix oops in arch/arm/mach-omap2/vp.c when pmic is not found Russell King - ARM Linux
2012-02-08 18:33 ` Tony Lindgren
2012-02-08 23:46 ` Tony Lindgren
2012-02-09 16:44 ` Russell King - ARM Linux
2012-02-09 16:51 ` Tony Lindgren
2012-02-08 16:37 ` [PATCH 04/16] ARM: omap: fix prm44xx.c OMAP44XX_IRQ_PRCM build error Russell King - ARM Linux
2012-02-08 18:39 ` Tony Lindgren
2012-02-09 18:58 ` Cousson, Benoit
2012-02-08 16:37 ` [PATCH 05/16] ARM: omap: fix vc.c PMIC error message Russell King - ARM Linux
2012-02-08 18:45 ` Tony Lindgren
2012-02-08 23:06 ` Kevin Hilman
2012-02-08 23:53 ` Tony Lindgren
2012-02-08 23:56 ` Russell King - ARM Linux
2012-02-09 0:09 ` Kevin Hilman
2012-02-09 0:11 ` Russell King - ARM Linux
2012-02-09 0:20 ` Kevin Hilman
2012-02-09 0:40 ` Tony Lindgren
2012-02-09 16:49 ` Russell King - ARM Linux
2012-02-09 17:18 ` Tony Lindgren
2012-02-09 17:27 ` Tony Lindgren
2012-02-09 17:59 ` Russell King - ARM Linux
2012-02-09 18:06 ` Tony Lindgren
2012-02-09 18:46 ` Tony Lindgren
2012-02-08 23:57 ` Tony Lindgren
2012-02-09 0:11 ` Kevin Hilman [this message]
2012-02-08 16:37 ` [PATCH 06/16] ARM: omap: fix uninformative vc/i2c configuration " Russell King - ARM Linux
2012-02-08 18:46 ` Tony Lindgren
2012-02-08 23:07 ` Kevin Hilman
2012-02-08 16:38 ` [PATCH 08/16] ARM: omap: fix section mismatch warning in mux.c Russell King - ARM Linux
2012-02-08 18:47 ` Tony Lindgren
2012-02-08 16:38 ` [PATCH 09/16] ARM: omap: preemptively fix section mismatch in omap4_sdp4430_wifi_mux_init() Russell King - ARM Linux
2012-02-08 18:48 ` Tony Lindgren
2012-02-08 16:39 ` [PATCH 10/16] ARM: omap: fix section mismatch warning for omap_secondary_startup() Russell King - ARM Linux
2012-02-08 18:48 ` Tony Lindgren
2012-02-08 16:39 ` [PATCH 11/16] ARM: omap: fix section mismatch error for omap_4430sdp_display_init() Russell King - ARM Linux
2012-02-08 18:48 ` Tony Lindgren
2012-02-08 16:39 ` [PATCH 12/16] ARM: omap: fix section mismatch warning for sdp3430_twl_gpio_setup() Russell King - ARM Linux
2012-02-08 18:49 ` Tony Lindgren
2012-02-08 16:40 ` [PATCH 13/16] ARM: omap: fix section mismatch warnings in mux.c caused by hsmmc.c Russell King - ARM Linux
2012-02-08 18:50 ` Tony Lindgren
2012-02-08 16:40 ` [PATCH 14/16] ARM: omap: fix wrapped error messages in omap_hwmod.c Russell King - ARM Linux
2012-02-08 17:40 ` Paul Walmsley
2012-02-08 18:54 ` Tony Lindgren
2012-02-08 19:25 ` Paul Walmsley
2012-02-08 19:31 ` Tony Lindgren
2012-02-08 16:40 ` [PATCH 15/16] ARM: omap: resolve nebulous 'Error setting wl12xx data' Russell King - ARM Linux
2012-02-08 18:56 ` Tony Lindgren
2012-02-08 16:41 ` [PATCH 16/16] ARM: omap: disable cpuidle for OMAP3 platforms Russell King - ARM Linux
2012-02-08 18:59 ` Tony Lindgren
2012-02-08 22:59 ` Russell King - ARM Linux
2012-02-08 23:09 ` Kevin Hilman
2012-02-08 23:30 ` Kevin Hilman
2012-02-08 19:06 ` [PATCH 00/16] rmk's patch series for fixing OMAP Tony Lindgren
2012-02-08 20:31 ` Florian Tobias Schandinat
2012-02-09 0:53 ` Russell King - ARM Linux
2012-02-09 7:02 ` Tomi Valkeinen
2012-02-09 8:30 ` Teresa Gamez
2012-02-09 10:24 ` Tomi Valkeinen
2012-02-09 18:00 ` [PATCH 01] ARM: omap: fix oops in arch/arm/mach-omap2/vp.c when pmic is not found Russell King - ARM Linux
2012-02-09 18:01 ` [PATCH 05] ARM: omap: fix vc.c PMIC error message Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx8sx3vc.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox