* [PATCH, FIX] ARM: mvebu: fix ReadyNAS 102 Power button GPIO to make it active high
@ 2013-09-29 18:36 Arnaud Ebalard
2013-09-30 14:09 ` Jason Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Arnaud Ebalard @ 2013-09-29 18:36 UTC (permalink / raw)
To: linux-arm-kernel
NETGEAR ReadyNAS 102 Power button definition in .dts file flags
associated GPIO active low instead of active high. This results
in reversed events reported by input subsystem (0 returned when
the button is pressed, 1 when released). This patch makes
associated GPIO active high to recover correct behaviour.
Signed-off-by: Arnaud Ebalard <arno@natisbad•org>
---
RN102 .dts file sits in Linus tree only since 3.12-rc1 so I guess
no one has currently relied on current reversed behaviour, i.e.
this can be fixed w/o impact on any userspace program. As a side
note, the initial error is mine.
arch/arm/boot/dts/armada-370-netgear-rn102.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/armada-370-netgear-rn102.dts b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
index 05e4485..396949d 100644
--- a/arch/arm/boot/dts/armada-370-netgear-rn102.dts
+++ b/arch/arm/boot/dts/armada-370-netgear-rn102.dts
@@ -160,7 +160,7 @@
button at 1 {
label = "Power Button";
linux,code = <116>; /* KEY_POWER */
- gpios = <&gpio1 30 1>;
+ gpios = <&gpio1 30 0>;
};
button at 2 {
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH, FIX] ARM: mvebu: fix ReadyNAS 102 Power button GPIO to make it active high
2013-09-29 18:36 [PATCH, FIX] ARM: mvebu: fix ReadyNAS 102 Power button GPIO to make it active high Arnaud Ebalard
@ 2013-09-30 14:09 ` Jason Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Jason Cooper @ 2013-09-30 14:09 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Sep 29, 2013 at 08:36:41PM +0200, Arnaud Ebalard wrote:
>
> NETGEAR ReadyNAS 102 Power button definition in .dts file flags
> associated GPIO active low instead of active high. This results
> in reversed events reported by input subsystem (0 returned when
> the button is pressed, 1 when released). This patch makes
> associated GPIO active high to recover correct behaviour.
>
> Signed-off-by: Arnaud Ebalard <arno@natisbad•org>
> ---
> RN102 .dts file sits in Linus tree only since 3.12-rc1 so I guess
> no one has currently relied on current reversed behaviour, i.e.
> this can be fixed w/o impact on any userspace program. As a side
> note, the initial error is mine.
>
> arch/arm/boot/dts/armada-370-netgear-rn102.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to mvebu/fixes
thx,
Jason.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-30 14:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-29 18:36 [PATCH, FIX] ARM: mvebu: fix ReadyNAS 102 Power button GPIO to make it active high Arnaud Ebalard
2013-09-30 14:09 ` Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox