From: robert.jarzmik@free•fr (Robert Jarzmik)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: dove: fix legacy dove IRQ numbers for 3.18
Date: Sat, 13 Dec 2014 13:26:47 +0100 [thread overview]
Message-ID: <87sigjag6w.fsf@free.fr> (raw)
In-Reply-To: <E1XyOJv-0003kd-2y@rmk-PC.arm.linux.org.uk> (Russell King's message of "Tue, 09 Dec 2014 17:11:31 +0000")
Russell King <rmk+kernel@arm•linux.org.uk> writes:
> v3.18 changed handle_IRQ() to call __handle_domain_irq(), which now
> rejects attempts to deliver IRQ0. Since IRQ 0 is used as the timer
> interrupt (just like the PIT on x86), this causes boot to fail as the
> bogomips calibration never completes.
>
> Fix this by shuffling all interrupts up by one.
Hi Russell,
I was curious why shift by "one".
Why not shift by for example NR_IRQS_LEGACY ?
And even if you judge 1 is the right number, wouldn't it be better to define a
constant "IRQ_OFS" and have each define be "#define IRQ_xxxx (IRQ_OFS + <n>) ?
Cheers.
--
Robert
next prev parent reply other threads:[~2014-12-13 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 17:11 [PATCH] ARM: dove: fix legacy dove IRQ numbers for 3.18 Russell King
2014-12-13 12:26 ` Robert Jarzmik [this message]
2014-12-21 13:51 ` Andrew Lunn
2014-12-21 15:59 ` Russell King - ARM Linux
2014-12-21 16:38 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sigjag6w.fsf@free.fr \
--to=robert.jarzmik@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox