From: arnaud.patard@rtp-net•org (Arnaud Patard (Rtp))
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver
Date: Tue, 19 Feb 2013 09:32:28 +0100 [thread overview]
Message-ID: <87vc9ok8kj.fsf@lebrac.rtp-net.org> (raw)
In-Reply-To: <20130219072438.GQ20212@lunn.ch> (Andrew Lunn's message of "Tue, 19 Feb 2013 08:24:38 +0100")
Andrew Lunn <andrew@lunn•ch> writes:
Hi,
[...]
>> > +
>> > +static const char hcd_name[] = "ehci-orion";
[...]
>> > }
>> >
>> > -MODULE_ALIAS("platform:orion-ehci");
>> > -
>> > static const struct of_device_id ehci_orion_dt_ids[] = {
>> > { .compatible = "marvell,orion-ehci", },
orion-ehci here ...
>> > {},
>> > @@ -336,8 +307,31 @@ static struct platform_driver ehci_orion_driver = {
>> > .remove = __exit_p(ehci_orion_drv_remove),
>> > .shutdown = usb_hcd_platform_shutdown,
>> > .driver = {
>> > - .name = "orion-ehci",
>> > + .name = hcd_name,
... and ehci-orion here. This would explain why only DT case seems to
work. I'm wondering why it has not been changed given that it has been
changed everywhere else, breaking stuff.
>>
>> Is this really what you want -- changing the driver name from
>> "orion-ehci" to "ehci-orion"? Is that liable to cause trouble?
>>
>> > +MODULE_DESCRIPTION(DRIVER_DESC);
>> > +MODULE_ALIAS("platform:ehci-orion");
>>
>> And is this really what you want -- changing the alias from
>> "platform:orion-ehci" to "platform:ehci-orion"?
>
> Hi Manjunath
>
> I can confirm that this breaks non DT based kirkwood systems. The
> driver does not get loaded.
>
> Sorry for not testing and finding this case earlier, i just tested a
> DT based system.
Maybe doing a mass renaming from orion-ehci to ehci-orion in
arch/arm/* files would be enough ? [ well, not necessary everywhere, I'm
not sure if changing the clock name in mach-kirkwood/board-dt.c would be
a good idea given the of node didn't change its name ]
Arnaud
next prev parent reply other threads:[~2013-02-19 8:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 10:24 [V2 0/8] usb: ehci: more bus glues as separate modules Manjunath Goudar
2013-02-15 16:10 ` Arnd Bergmann
2013-02-15 18:07 ` Greg KH
2013-02-15 21:58 ` Arnd Bergmann
2013-02-15 22:12 ` [PATCH 1/2] USB: EHCI: make ehci-vt8500 a separate driver Arnd Bergmann
2013-02-15 22:12 ` [PATCH 2/2] USB: EHCI: make ehci-orion " Arnd Bergmann
2013-02-15 22:38 ` Jason Cooper
2013-02-16 8:42 ` Andrew Lunn
2013-02-16 14:19 ` Ezequiel Garcia
2013-02-16 23:03 ` [PATCH] USB: update host controller Kconfig entries Arnd Bergmann
2013-02-18 22:34 ` [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver Alan Stern
2013-02-19 7:24 ` Andrew Lunn
2013-02-19 8:32 ` Arnaud Patard (Rtp) [this message]
2013-02-20 18:28 ` Greg KH
2013-02-20 18:44 ` Arnd Bergmann
[not found] ` <CAJFYCKGCNDTSq9OYZUYXx8XNSgSHD=p=hw+9_7N=EhM=bUu=bg@mail.gmail.com>
2013-02-19 10:56 ` Arnd Bergmann
2013-02-19 15:26 ` Alan Stern
2013-02-20 16:02 ` Alan Stern
2013-02-20 16:27 ` Arnd Bergmann
2013-02-20 16:54 ` Jason Cooper
2013-02-15 22:21 ` [PATCH 1/2] USB: EHCI: make ehci-vt8500 " Tony Prisk
2013-02-15 16:47 ` [V2 0/8] usb: ehci: more bus glues as separate modules Ezequiel Garcia
[not found] ` <1360923853-7875-3-git-send-email-manjunath.goudar@linaro.org>
2013-02-18 9:44 ` [V2 2/8] USB: EHCI: make ehci-atmel a separate driver Bo Shen
2013-02-18 10:12 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vc9ok8kj.fsf@lebrac.rtp-net.org \
--to=arnaud.patard@rtp-net$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox