From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 17/18][V3] ARM: OMAP3/4: consolidate cpuidle Makefile
Date: Thu, 03 May 2012 13:34:14 -0700 [thread overview]
Message-ID: <87wr4tj96h.fsf@ti.com> (raw)
In-Reply-To: <1335276339-11135-18-git-send-email-daniel.lezcano@linaro.org> (Daniel Lezcano's message of "Tue, 24 Apr 2012 16:05:38 +0200")
Daniel Lezcano <daniel.lezcano@linaro•org> writes:
> Define a CPU_IDLE section in the makefile, declare the functions in
> the header files conforming to the kernel coding rules and remove the
> 'define's in the C files.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro•org>
> Reviewed-by: Jean Pihet <j-pihet@ti•com>
This patch breaks compilation for the !CONFIG_PM case:
arch/arm/mach-omap2/built-in.o: In function `__omap3_enter_idle':
/work/kernel/omap/pm/arch/arm/mach-omap2/cpuidle34xx.c:121: undefined reference to `omap_sram_idle'
Since you moved this stuff out of a CONFIG_PM conditional part of the
Makefile, it broke because pm34xx.c is still compiled conditionally on
CONFIG_PM.
When changing Makefile/Kconfig dependencies like this, please
be sure to at least compile test with the various options
enabled/disabled.
For now, I've dropped this patch from the series. Feel free to
update/retest/resend since the idea is fine.
Kevin
next prev parent reply other threads:[~2012-05-03 20:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 14:05 [PATCH 00/18][V3] ARM: OMAP3/4 : cpuidle34xx and cpuidle44xx cleanups Daniel Lezcano
2012-04-24 14:05 ` [PATCH 01/18][V3] ARM: OMAP4: cpuidle - Remove unused valid field Daniel Lezcano
2012-04-24 14:05 ` [PATCH 02/18][V3] ARM: OMAP4: cpuidle - Declare the states with the driver declaration Daniel Lezcano
2012-04-24 14:05 ` [PATCH 03/18][V3] ARM: OMAP4: cpuidle - Remove the cpuidle_params_table table Daniel Lezcano
2012-04-24 14:05 ` [PATCH 04/18][V3] ARM: OMAP4: cpuidle - fix static omap4_idle_data declaration Daniel Lezcano
2012-04-24 14:05 ` [PATCH 05/18][V3] ARM: OMAP4: cpuidle - Initialize omap4_idle_data at compile time Daniel Lezcano
2012-04-24 14:05 ` [PATCH 06/18][V3] ARM: OMAP4: cpuidle - use the omap4_idle_data variable directly Daniel Lezcano
2012-04-24 14:05 ` [PATCH 07/18][V3] ARM: OMAP4: cpuidle - remove omap4_idle_data initialization at boot time Daniel Lezcano
2012-04-24 14:05 ` [PATCH 08/18][V3] ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table Daniel Lezcano
2012-04-24 14:05 ` [PATCH 09/18][V3] ARM: OMAP3: define cpuidle statically Daniel Lezcano
2012-04-24 14:05 ` [PATCH 10/18][V3] ARM: OMAP3: cpuidle - remove errata check in the init function Daniel Lezcano
2012-04-24 14:05 ` [PATCH 11/18][V3] ARM: OMAP3: cpuidle - remove the 'valid' field Daniel Lezcano
2012-05-03 20:19 ` Kevin Hilman
2012-05-03 20:29 ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 12/18][V3] ARM: OMAP3: cpuidle - remove cpuidle_params_table Daniel Lezcano
2012-04-24 14:05 ` [PATCH 13/18][V3] ARM: OMAP3: define statically the omap3_idle_data Daniel Lezcano
2012-04-24 14:05 ` [PATCH 14/18][V3] ARM: OMAP3: cpuidle - use omap3_idle_data directly Daniel Lezcano
2012-04-24 14:05 ` [PATCH 15/18][V3] ARM: OMAP3: cpuidle - simplify next_valid_state Daniel Lezcano
2012-04-24 14:05 ` [PATCH 16/18][V3] ARM: OMAP3: set omap3_idle_data as static Daniel Lezcano
2012-04-24 14:05 ` [PATCH 17/18][V3] ARM: OMAP3/4: consolidate cpuidle Makefile Daniel Lezcano
2012-05-03 20:34 ` Kevin Hilman [this message]
2012-05-03 23:03 ` Daniel Lezcano
2012-04-24 14:05 ` [PATCH 18/18][V3] ARM: OMAP3: cpuidle - set global variables static Daniel Lezcano
2012-05-03 20:26 ` Kevin Hilman
2012-05-03 23:02 ` Daniel Lezcano
2012-04-25 22:00 ` [PATCH 00/18][V3] ARM: OMAP3/4 : cpuidle34xx and cpuidle44xx cleanups Daniel Lezcano
2012-04-30 22:58 ` Kevin Hilman
2012-05-01 8:16 ` Daniel Lezcano
2012-05-01 9:25 ` Amit Kucheria
[not found] ` <CAMQu2gzK=u1kkbv9nzRyO3xbqVhZkf0KP=ceCyNteSituBZPrg@mail.gmail.com>
2012-05-01 10:20 ` Daniel Lezcano
2012-05-02 6:20 ` Shilimkar, Santosh
2012-05-03 20:39 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wr4tj96h.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox