From: khilman@ti•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators
Date: Thu, 08 Mar 2012 13:26:12 -0800 [thread overview]
Message-ID: <87y5raaiob.fsf@ti.com> (raw)
In-Reply-To: <20120308210825.GY12083@atomide.com> (Tony Lindgren's message of "Thu, 8 Mar 2012 13:08:26 -0800")
Tony Lindgren <tony@atomide•com> writes:
> * Kevin Hilman <khilman@ti•com> [120307 11:05]:
>> >
>> > I don't think the second smsc911x on the Overo, "smsc911x.1", would
>> > find it due to the dev_id.
>>
>> It's not about finding the second regulator. As stated in the
>> changelog, it's about the duplicate attempt to register the exact same
>> platform_device.
>>
>> Duplicate attempts to register the exact same platform_device cause
>> kobject to panic and give up[1]. So, any platform that calls
>> gpmc_smsc911x_init() twice (Overo and T35 in mainline) will panic on
>> boot.
>>
>> This patch fixes those platforms so they can boot.
>
> Yeah but I guess the second smsc911x instance still would not work,
> or am I missing something?
I don't know since my Overo expansion boards don't have a 2nd NIC, but I
suspect you're right.
However, my fix isn't addressing that. I am fixing a problem where
mainline today will panic on some boards due to duplicate registration.
If the 2nd interface doesn't work, then the original patch that added
the regulators needs a rethink. My patch to prevent the panic() is
needed for mainline.
Kevin
next prev parent reply other threads:[~2012-03-08 21:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 14:16 [PATCH v3] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators Matt Porter
2012-03-01 20:36 ` Kevin Hilman
2012-03-01 20:45 ` Felipe Balbi
2012-03-05 18:18 ` Kevin Hilman
2012-03-07 16:00 ` Russ Dill
2012-03-07 17:21 ` Tony Lindgren
2012-03-07 19:36 ` Kevin Hilman
2012-03-08 21:08 ` Tony Lindgren
2012-03-08 21:26 ` Kevin Hilman [this message]
2012-03-09 0:06 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5raaiob.fsf@ti.com \
--to=khilman@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox