* [PATCH v2 1/3] dt-bindings: display: msm: qcm2290: Add Shikra MDSS
2026-06-04 12:30 [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Nabige Aala
@ 2026-06-04 12:30 ` Nabige Aala
2026-06-04 12:51 ` Krzysztof Kozlowski
2026-06-04 12:51 ` Dmitry Baryshkov
2026-06-04 12:30 ` [PATCH v2 2/3] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
` (2 subsequent siblings)
3 siblings, 2 replies; 11+ messages in thread
From: Nabige Aala @ 2026-06-04 12:30 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Krishna Manikandan,
Loic Poulain, Bjorn Andersson, Konrad Dybcio, Will Deacon,
Robin Murphy, Joerg Roedel (AMD)
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
iommu, linux-arm-kernel, Nabige Aala
Shikra SoC uses the same MDSS/DPU/DSI hardware as QCM2290 (DPU 6.5),
sharing the same register layout, DSI controller and 14nm DSI PHY.
Add qcom,shikra-mdss to the qcm2290-mdss binding compatible enum
rather than introducing a separate binding file.
Register qcom,shikra-dsi-ctrl in dsi-controller-main.yaml alongside
qcom,qcm2290-dsi-ctrl, and update the qcm2290-mdss patternProperties
to accept both SoC-specific DPU and DSI controller compatibles.
Signed-off-by: Nabige Aala <nabige.aala@oss•qualcomm.com>
---
.../bindings/display/msm/dsi-controller-main.yaml | 1 +
.../bindings/display/msm/qcom,qcm2290-dpu.yaml | 7 ++--
.../bindings/display/msm/qcom,qcm2290-mdss.yaml | 38 ++++++++++++++++++----
3 files changed, 37 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index dbc0613e427e..a2f3e91104af 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -33,6 +33,7 @@ properties:
- qcom,sdm660-dsi-ctrl
- qcom,sdm670-dsi-ctrl
- qcom,sdm845-dsi-ctrl
+ - qcom,shikra-dsi-ctrl
- qcom,sm6115-dsi-ctrl
- qcom,sm6125-dsi-ctrl
- qcom,sm6150-dsi-ctrl
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-dpu.yaml
index be6cd8adb3b6..e166a73651df 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-dpu.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-dpu.yaml
@@ -13,8 +13,11 @@ $ref: /schemas/display/msm/dpu-common.yaml#
properties:
compatible:
- const: qcom,qcm2290-dpu
-
+ oneOf:
+ - const: qcom,qcm2290-dpu
+ - items:
+ - const: qcom,shikra-dpu
+ - const: qcom,qcm2290-dpu
reg:
items:
- description: Address offset and size for mdp register set
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
index bb09ecd1a5b4..7184b09a8774 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
@@ -4,21 +4,36 @@
$id: http://devicetree.org/schemas/display/msm/qcom,qcm2290-mdss.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Qualcomm QCM220 Display MDSS
+title: Qualcomm QCM2290 and Shikra Display MDSS
maintainers:
- Loic Poulain <loic.poulain@linaro•org>
+ - Nabige Aala <nabige.aala@oss•qualcomm.com>
description:
Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
sub-blocks like DPU display controller and DSI. Device tree bindings of MDSS
- are mentioned for QCM2290 target.
+ are mentioned for QCM2290 and Shikra targets. Shikra uses the same MDSS/DPU/DSI
+ hardware as QCM2290 (DPU 6.5) and shares the same register layout.
$ref: /schemas/display/msm/mdss-common.yaml#
+select:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,qcm2290-mdss
+ required:
+ - compatible
+
properties:
compatible:
- const: qcom,qcm2290-mdss
+ oneOf:
+ - const: qcom,qcm2290-mdss
+ - items:
+ - const: qcom,shikra-mdss
+ - const: qcom,qcm2290-mdss
clocks:
items:
@@ -52,7 +67,11 @@ patternProperties:
properties:
compatible:
- const: qcom,qcm2290-dpu
+ oneOf:
+ - const: qcom,qcm2290-dpu
+ - items:
+ - const: qcom,shikra-dpu
+ - const: qcom,qcm2290-dpu
"^dsi@[0-9a-f]+$":
type: object
@@ -60,9 +79,14 @@ patternProperties:
properties:
compatible:
- items:
- - const: qcom,qcm2290-dsi-ctrl
- - const: qcom,mdss-dsi-ctrl
+ oneOf:
+ - items:
+ - const: qcom,qcm2290-dsi-ctrl
+ - const: qcom,mdss-dsi-ctrl
+ - items:
+ - const: qcom,shikra-dsi-ctrl
+ - const: qcom,qcm2290-dsi-ctrl
+ - const: qcom,mdss-dsi-ctrl
"^phy@[0-9a-f]+$":
type: object
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: display: msm: qcm2290: Add Shikra MDSS
2026-06-04 12:30 ` [PATCH v2 1/3] dt-bindings: display: msm: qcm2290: Add Shikra MDSS Nabige Aala
@ 2026-06-04 12:51 ` Krzysztof Kozlowski
2026-06-04 12:51 ` Dmitry Baryshkov
1 sibling, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-04 12:51 UTC (permalink / raw)
To: Nabige Aala, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Krishna Manikandan, Loic Poulain, Bjorn Andersson, Konrad Dybcio,
Will Deacon, Robin Murphy, Joerg Roedel (AMD)
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
iommu, linux-arm-kernel
On 04/06/2026 14:30, Nabige Aala wrote:
>
> +select:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,qcm2290-mdss
> + required:
> + - compatible
Why do you need this select? None of the bindings have it, I think.
> +
> properties:
> compatible:
> - const: qcom,qcm2290-mdss
> + oneOf:
> + - const: qcom,qcm2290-mdss
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: display: msm: qcm2290: Add Shikra MDSS
2026-06-04 12:30 ` [PATCH v2 1/3] dt-bindings: display: msm: qcm2290: Add Shikra MDSS Nabige Aala
2026-06-04 12:51 ` Krzysztof Kozlowski
@ 2026-06-04 12:51 ` Dmitry Baryshkov
1 sibling, 0 replies; 11+ messages in thread
From: Dmitry Baryshkov @ 2026-06-04 12:51 UTC (permalink / raw)
To: Nabige Aala
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Krishna Manikandan,
Loic Poulain, Bjorn Andersson, Konrad Dybcio, Will Deacon,
Robin Murphy, Joerg Roedel (AMD), linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel, iommu, linux-arm-kernel
On Thu, Jun 04, 2026 at 06:00:47PM +0530, Nabige Aala wrote:
> Shikra SoC uses the same MDSS/DPU/DSI hardware as QCM2290 (DPU 6.5),
> sharing the same register layout, DSI controller and 14nm DSI PHY.
> Add qcom,shikra-mdss to the qcm2290-mdss binding compatible enum
> rather than introducing a separate binding file.
>
> Register qcom,shikra-dsi-ctrl in dsi-controller-main.yaml alongside
> qcom,qcm2290-dsi-ctrl, and update the qcm2290-mdss patternProperties
> to accept both SoC-specific DPU and DSI controller compatibles.
>
> Signed-off-by: Nabige Aala <nabige.aala@oss•qualcomm.com>
> ---
> .../bindings/display/msm/dsi-controller-main.yaml | 1 +
> .../bindings/display/msm/qcom,qcm2290-dpu.yaml | 7 ++--
> .../bindings/display/msm/qcom,qcm2290-mdss.yaml | 38 ++++++++++++++++++----
> 3 files changed, 37 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index dbc0613e427e..a2f3e91104af 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -33,6 +33,7 @@ properties:
> - qcom,sdm660-dsi-ctrl
> - qcom,sdm670-dsi-ctrl
> - qcom,sdm845-dsi-ctrl
> + - qcom,shikra-dsi-ctrl
It is the same as QCM2290. Why didn't you follow the pattern and add it
using qcm2290 one as a fallback?
> - qcom,sm6115-dsi-ctrl
> - qcom,sm6125-dsi-ctrl
> - qcom,sm6150-dsi-ctrl
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-dpu.yaml
> index be6cd8adb3b6..e166a73651df 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-dpu.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-dpu.yaml
> @@ -13,8 +13,11 @@ $ref: /schemas/display/msm/dpu-common.yaml#
>
> properties:
> compatible:
> - const: qcom,qcm2290-dpu
> -
> + oneOf:
> + - const: qcom,qcm2290-dpu
> + - items:
> + - const: qcom,shikra-dpu
> + - const: qcom,qcm2290-dpu
> reg:
> items:
> - description: Address offset and size for mdp register set
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> index bb09ecd1a5b4..7184b09a8774 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> @@ -4,21 +4,36 @@
> $id: http://devicetree.org/schemas/display/msm/qcom,qcm2290-mdss.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Qualcomm QCM220 Display MDSS
> +title: Qualcomm QCM2290 and Shikra Display MDSS
>
> maintainers:
> - Loic Poulain <loic.poulain@linaro•org>
> + - Nabige Aala <nabige.aala@oss•qualcomm.com>
Nope.
>
> description:
> Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
> sub-blocks like DPU display controller and DSI. Device tree bindings of MDSS
> - are mentioned for QCM2290 target.
> + are mentioned for QCM2290 and Shikra targets. Shikra uses the same MDSS/DPU/DSI
> + hardware as QCM2290 (DPU 6.5) and shares the same register layout.
>
> $ref: /schemas/display/msm/mdss-common.yaml#
>
> +select:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,qcm2290-mdss
> + required:
> + - compatible
Why do you need this?
> +
> properties:
> compatible:
> - const: qcom,qcm2290-mdss
> + oneOf:
> + - const: qcom,qcm2290-mdss
> + - items:
> + - const: qcom,shikra-mdss
> + - const: qcom,qcm2290-mdss
>
> clocks:
> items:
> @@ -52,7 +67,11 @@ patternProperties:
>
> properties:
> compatible:
> - const: qcom,qcm2290-dpu
> + oneOf:
> + - const: qcom,qcm2290-dpu
> + - items:
> + - const: qcom,shikra-dpu
> + - const: qcom,qcm2290-dpu
>
> "^dsi@[0-9a-f]+$":
> type: object
> @@ -60,9 +79,14 @@ patternProperties:
>
> properties:
> compatible:
> - items:
> - - const: qcom,qcm2290-dsi-ctrl
> - - const: qcom,mdss-dsi-ctrl
> + oneOf:
> + - items:
> + - const: qcom,qcm2290-dsi-ctrl
> + - const: qcom,mdss-dsi-ctrl
> + - items:
> + - const: qcom,shikra-dsi-ctrl
> + - const: qcom,qcm2290-dsi-ctrl
> + - const: qcom,mdss-dsi-ctrl
Change this to contains:qcom,qcm2290-dsi-ctrl
>
> "^phy@[0-9a-f]+$":
> type: object
>
> --
> 2.34.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 2/3] arm64: defconfig: Enable ILI7807S DSI panel driver
2026-06-04 12:30 [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Nabige Aala
2026-06-04 12:30 ` [PATCH v2 1/3] dt-bindings: display: msm: qcm2290: Add Shikra MDSS Nabige Aala
@ 2026-06-04 12:30 ` Nabige Aala
2026-06-04 12:53 ` Krzysztof Kozlowski
2026-06-04 12:54 ` Dmitry Baryshkov
2026-06-04 12:30 ` [PATCH v2 3/3] soc: qcom: ubwc: Add Shikra UBWC config Nabige Aala
2026-06-04 13:03 ` [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Dmitry Baryshkov
3 siblings, 2 replies; 11+ messages in thread
From: Nabige Aala @ 2026-06-04 12:30 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Krishna Manikandan,
Loic Poulain, Bjorn Andersson, Konrad Dybcio, Will Deacon,
Robin Murphy, Joerg Roedel (AMD)
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
iommu, linux-arm-kernel, Nabige Aala
Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module,
used on the Shikra CQM EVK board.
Signed-off-by: Nabige Aala <nabige.aala@oss•qualcomm.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 909f3c188e75..a6d72ff63e57 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1005,6 +1005,7 @@ CONFIG_DRM_MXSFB=m
CONFIG_DRM_IMX_LCDIF=m
CONFIG_DRM_NOUVEAU=m
CONFIG_DRM_PANEL_BOE_TV101WUM_NL6=m
+CONFIG_DRM_PANEL_ILITEK_ILI7807S=m
CONFIG_DRM_PANEL_LVDS=m
CONFIG_DRM_PANEL_HIMAX_HX8279=m
CONFIG_DRM_PANEL_HIMAX_HX83112A=m
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/3] arm64: defconfig: Enable ILI7807S DSI panel driver
2026-06-04 12:30 ` [PATCH v2 2/3] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
@ 2026-06-04 12:53 ` Krzysztof Kozlowski
2026-06-04 16:12 ` Krzysztof Kozlowski
2026-06-04 12:54 ` Dmitry Baryshkov
1 sibling, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-04 12:53 UTC (permalink / raw)
To: Nabige Aala, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Krishna Manikandan, Loic Poulain, Bjorn Andersson, Konrad Dybcio,
Will Deacon, Robin Murphy, Joerg Roedel (AMD)
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
iommu, linux-arm-kernel
On 04/06/2026 14:30, Nabige Aala wrote:
> Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module,
> used on the Shikra CQM EVK board.
Does Samsung Shikra CQM EVK have it? I guess no.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/3] arm64: defconfig: Enable ILI7807S DSI panel driver
2026-06-04 12:53 ` Krzysztof Kozlowski
@ 2026-06-04 16:12 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-04 16:12 UTC (permalink / raw)
To: Nabige Aala, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Krishna Manikandan, Loic Poulain, Bjorn Andersson, Konrad Dybcio,
Will Deacon, Robin Murphy, Joerg Roedel (AMD)
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
iommu, linux-arm-kernel
On 04/06/2026 14:53, Krzysztof Kozlowski wrote:
> On 04/06/2026 14:30, Nabige Aala wrote:
>> Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module,
>> used on the Shikra CQM EVK board.
>
>
> Does Samsung Shikra CQM EVK have it? I guess no.
... and now I see this was already sent, so wasn't this reviewed?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/3] arm64: defconfig: Enable ILI7807S DSI panel driver
2026-06-04 12:30 ` [PATCH v2 2/3] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
2026-06-04 12:53 ` Krzysztof Kozlowski
@ 2026-06-04 12:54 ` Dmitry Baryshkov
1 sibling, 0 replies; 11+ messages in thread
From: Dmitry Baryshkov @ 2026-06-04 12:54 UTC (permalink / raw)
To: Nabige Aala
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Krishna Manikandan,
Loic Poulain, Bjorn Andersson, Konrad Dybcio, Will Deacon,
Robin Murphy, Joerg Roedel (AMD), linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel, iommu, linux-arm-kernel
On Thu, Jun 04, 2026 at 06:00:48PM +0530, Nabige Aala wrote:
> Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module,
> used on the Shikra CQM EVK board.
>
> Signed-off-by: Nabige Aala <nabige.aala@oss•qualcomm.com>
> ---
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Move it to the series adding corresponding panel driver.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 3/3] soc: qcom: ubwc: Add Shikra UBWC config
2026-06-04 12:30 [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Nabige Aala
2026-06-04 12:30 ` [PATCH v2 1/3] dt-bindings: display: msm: qcm2290: Add Shikra MDSS Nabige Aala
2026-06-04 12:30 ` [PATCH v2 2/3] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
@ 2026-06-04 12:30 ` Nabige Aala
2026-06-04 13:04 ` Dmitry Baryshkov
2026-06-04 13:03 ` [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Dmitry Baryshkov
3 siblings, 1 reply; 11+ messages in thread
From: Nabige Aala @ 2026-06-04 12:30 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Krishna Manikandan,
Loic Poulain, Bjorn Andersson, Konrad Dybcio, Will Deacon,
Robin Murphy, Joerg Roedel (AMD)
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
iommu, linux-arm-kernel, Nabige Aala
Add UBWC configuration for the Shikra platform. Shikra shares the
same hardware as QCM2290 (Agatti), so reuse qcm2290_data for the
UBWC settings
Signed-off-by: Nabige Aala <nabige.aala@oss•qualcomm.com>
---
drivers/soc/qcom/ubwc_config.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c
index 3fe47d8f0f63..1a2e54c6480d 100644
--- a/drivers/soc/qcom/ubwc_config.c
+++ b/drivers/soc/qcom/ubwc_config.c
@@ -278,6 +278,7 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = {
{ .compatible = "qcom,sdm660", .data = &msm8937_data },
{ .compatible = "qcom,sdm670", .data = &sdm670_data, },
{ .compatible = "qcom,sdm845", .data = &sdm845_data, },
+ { .compatible = "qcom,shikra", .data = &qcm2290_data, },
{ .compatible = "qcom,sm4250", .data = &sm6115_data, },
{ .compatible = "qcom,sm6115", .data = &sm6115_data, },
{ .compatible = "qcom,sm6125", .data = &sm6125_data, },
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 3/3] soc: qcom: ubwc: Add Shikra UBWC config
2026-06-04 12:30 ` [PATCH v2 3/3] soc: qcom: ubwc: Add Shikra UBWC config Nabige Aala
@ 2026-06-04 13:04 ` Dmitry Baryshkov
0 siblings, 0 replies; 11+ messages in thread
From: Dmitry Baryshkov @ 2026-06-04 13:04 UTC (permalink / raw)
To: Nabige Aala
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Krishna Manikandan,
Loic Poulain, Bjorn Andersson, Konrad Dybcio, Will Deacon,
Robin Murphy, Joerg Roedel (AMD), linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel, iommu, linux-arm-kernel
On Thu, Jun 04, 2026 at 06:00:49PM +0530, Nabige Aala wrote:
> Add UBWC configuration for the Shikra platform. Shikra shares the
> same hardware as QCM2290 (Agatti), so reuse qcm2290_data for the
> UBWC settings
>
> Signed-off-by: Nabige Aala <nabige.aala@oss•qualcomm.com>
> ---
> drivers/soc/qcom/ubwc_config.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss•qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support
2026-06-04 12:30 [PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Nabige Aala
` (2 preceding siblings ...)
2026-06-04 12:30 ` [PATCH v2 3/3] soc: qcom: ubwc: Add Shikra UBWC config Nabige Aala
@ 2026-06-04 13:03 ` Dmitry Baryshkov
3 siblings, 0 replies; 11+ messages in thread
From: Dmitry Baryshkov @ 2026-06-04 13:03 UTC (permalink / raw)
To: Nabige Aala
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Krishna Manikandan,
Loic Poulain, Bjorn Andersson, Konrad Dybcio, Will Deacon,
Robin Murphy, Joerg Roedel (AMD), linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel, iommu, linux-arm-kernel
On Thu, Jun 04, 2026 at 06:00:46PM +0530, Nabige Aala wrote:
[PATCH v2 0/3] Subject: [PATCH 0/3] Add Shikra (QCM2390) display support
The subject line is wrong. Please use the tools properly (I'd strongly
recommend using the b4 tool).
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 11+ messages in thread