From: Andrzej Pietrasiewicz <andrzej.p@collabora•com>
To: Marek Szyprowski <m.szyprowski@samsung•com>,
linux-pm@vger•kernel.org, linux-acpi@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-iio@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-samsung-soc@vger•kernel.org, linux-input@vger•kernel.org,
linux-tegra@vger•kernel.org, patches@opensource•cirrus.com,
ibm-acpi-devel@lists•sourceforge.net,
platform-driver-x86@vger•kernel.org
Cc: kernel@collabora•com, Nick Dyer <nick@shmanahar•org>,
Laxman Dewangan <ldewangan@nvidia•com>,
Peter Meerwald-Stadler <pmeerw@pmeerw•net>,
Peter Hutterer <peter.hutterer@redhat•com>,
Fabio Estevam <festevam@gmail•com>,
Lars-Peter Clausen <lars@metafoo•de>,
Krzysztof Kozlowski <krzk@kernel•org>,
Jonathan Hunter <jonathanh@nvidia•com>,
Kukjin Kim <kgene@kernel•org>, NXP Linux Team <linux-imx@nxp•com>,
Sylvain Lemieux <slemieux.tyco@gmail•com>,
Len Brown <lenb@kernel•org>,
Michael Hennerich <michael.hennerich@analog•com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>,
Sascha Hauer <s.hauer@pengutronix•de>,
Henrique de Moraes Holschuh <ibm-acpi@hmh•eng.br>,
Vladimir Zapolskiy <vz@mleia•com>,
Hans de Goede <hdegoede@redhat•com>,
Barry Song <baohua@kernel•org>, Ferruh Yigit <fery@cypress•com>,
Dmitry Torokhov <dmitry.torokhov@gmail•com>,
"Rafael J . Wysocki" <rjw@rjwysocki•net>,
Thierry Reding <thierry.reding@gmail•com>,
Sangwon Jee <jeesw@melfas•com>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Hartmut Knaack <knaack.h@gmx•de>, Shawn Guo <shawnguo@kernel•org>,
Jonathan Cameron <jic23@kernel•org>
Subject: Re: [PATCH v4 2/7] Input: use input_device_enabled()
Date: Mon, 7 Dec 2020 16:50:03 +0100 [thread overview]
Message-ID: <9c784a23-eade-eacd-3e67-d344a5758b83@collabora.com> (raw)
In-Reply-To: <27ce1176-6318-45aa-4e22-3dec9f3df15d@samsung.com>
Hi Marek,
W dniu 07.12.2020 o 14:32, Marek Szyprowski pisze:
> Hi Andrzej,
>
> On 08.06.2020 13:22, Andrzej Pietrasiewicz wrote:
>> Use the newly added helper in relevant input drivers.
>>
>> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora•com>
>
> This patch landed recently in linux-next as commit d69f0a43c677 ("Input:
> use input_device_enabled()"). Sadly it causes following warning during
> system suspend/resume cycle on ARM 32bit Samsung Exynos5250-based Snow
> Chromebook with kernel compiled from exynos_defconfig:
>
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 1777 at drivers/input/input.c:2230
> input_device_enabled+0x68/0x6c
> Modules linked in: cmac bnep mwifiex_sdio mwifiex sha256_generic
> libsha256 sha256_arm cfg80211 btmrvl_sdio btmrvl bluetooth s5p_mfc
> exynos_gsc v4l2_mem2mem videob
> CPU: 0 PID: 1777 Comm: rtcwake Not tainted
> 5.10.0-rc6-next-20201207-00001-g49a0dc04c46d-dirty #9902
> Hardware name: Samsung Exynos (Flattened Device Tree)
> [<c0111718>] (unwind_backtrace) from [<c010d050>] (show_stack+0x10/0x14)
> [<c010d050>] (show_stack) from [<c0b32810>] (dump_stack+0xb4/0xd4)
> [<c0b32810>] (dump_stack) from [<c0126e24>] (__warn+0xd8/0x11c)
> [<c0126e24>] (__warn) from [<c0126f18>] (warn_slowpath_fmt+0xb0/0xb8)
> [<c0126f18>] (warn_slowpath_fmt) from [<c07fa2fc>]
> (input_device_enabled+0x68/0x6c)
> [<c07fa2fc>] (input_device_enabled) from [<c080a0f8>]
Apparently you are hitting this line of code in drivers/input/input.c:
lockdep_assert_held(&dev->mutex);
Inspecting input device's "users" member should happen under dev's lock.
Regards,
Andrzej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-07 15:52 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200506002746.GB89269@dtor-ws>
2020-05-15 16:49 ` [PATCHv2 0/7] Support inhibiting input devices Andrzej Pietrasiewicz
2020-05-15 16:51 ` [PATCHv2 1/7] Input: add input_device_enabled() Andrzej Pietrasiewicz
2020-05-15 16:51 ` [PATCHv2 2/7] Input: use input_device_enabled() Andrzej Pietrasiewicz
2020-05-15 16:52 ` [PATCHv2 4/7] iio: adc: exynos: Use input_device_enabled() Andrzej Pietrasiewicz
2020-05-15 16:52 ` [PATCHv2 6/7] Input: Add "inhibited" property Andrzej Pietrasiewicz
2020-05-15 18:19 ` [PATCHv2 0/7] Support inhibiting input devices Hans de Goede
2020-05-17 22:55 ` Peter Hutterer
2020-05-18 2:40 ` Dmitry Torokhov
2020-05-18 7:36 ` Hans de Goede
2020-05-22 15:35 ` Andrzej Pietrasiewicz
2020-05-27 6:13 ` Peter Hutterer
2020-05-18 10:48 ` Andrzej Pietrasiewicz
2020-05-18 12:24 ` Hans de Goede
2020-05-18 13:49 ` Andrzej Pietrasiewicz
2020-05-18 14:23 ` Hans de Goede
2020-05-19 9:02 ` Andrzej Pietrasiewicz
2020-05-19 9:36 ` Hans de Goede
2020-05-27 6:34 ` Dmitry Torokhov
2020-06-02 16:56 ` Andrzej Pietrasiewicz
2020-06-02 17:52 ` Dmitry Torokhov
2020-06-02 18:50 ` Andrzej Pietrasiewicz
2020-06-02 20:19 ` Hans de Goede
2020-06-03 13:07 ` Andrzej Pietrasiewicz
2020-06-03 17:38 ` Hans de Goede
2020-06-03 17:54 ` Andrzej Pietrasiewicz
2020-06-03 19:37 ` Hans de Goede
2020-06-04 7:28 ` Dmitry Torokhov
2020-06-05 17:33 ` [PATCH v3 " Andrzej Pietrasiewicz
2020-06-05 17:33 ` [PATCH v3 1/7] Input: add input_device_enabled() Andrzej Pietrasiewicz
2020-06-05 17:33 ` [PATCH v3 2/7] Input: use input_device_enabled() Andrzej Pietrasiewicz
2020-06-05 17:33 ` [PATCH v3 3/7] ACPI: button: Access input device's users under appropriate mutex Andrzej Pietrasiewicz
2020-06-05 17:33 ` [PATCH v3 4/7] ACPI: button: Use input_device_enabled() helper Andrzej Pietrasiewicz
2020-06-05 17:33 ` [PATCH v3 5/7] iio: adc: exynos: Use input_device_enabled() Andrzej Pietrasiewicz
2020-06-05 19:49 ` Michał Mirosław
2020-06-05 17:33 ` [PATCH v3 6/7] platform/x86: thinkpad_acpi: " Andrzej Pietrasiewicz
2020-06-05 17:33 ` [PATCH v3 7/7] Input: Add "inhibited" property Andrzej Pietrasiewicz
2020-06-05 17:41 ` Hans de Goede
2020-06-08 11:22 ` [PATCH v4 0/7] Support inhibiting input devices Andrzej Pietrasiewicz
2020-06-08 11:22 ` [PATCH v4 1/7] Input: add input_device_enabled() Andrzej Pietrasiewicz
2020-12-03 6:25 ` Dmitry Torokhov
2020-06-08 11:22 ` [PATCH v4 2/7] Input: use input_device_enabled() Andrzej Pietrasiewicz
2020-12-03 6:26 ` Dmitry Torokhov
2020-12-07 13:32 ` Marek Szyprowski
2020-12-07 15:50 ` Andrzej Pietrasiewicz [this message]
2020-12-08 10:05 ` Marek Szyprowski
2020-12-09 6:37 ` Dmitry Torokhov
2020-12-11 7:09 ` [PATCH] Input: cyapa - do not call input_device_enabled from power mode handler Dmitry Torokhov
2020-12-11 8:22 ` Marek Szyprowski
2020-12-11 8:31 ` Dmitry Torokhov
2020-06-08 11:22 ` [PATCH v4 3/7] ACPI: button: Access input device's users under appropriate mutex Andrzej Pietrasiewicz
2020-06-24 15:00 ` Rafael J. Wysocki
2020-06-25 5:23 ` Dmitry Torokhov
2020-06-25 10:55 ` Rafael J. Wysocki
2020-10-05 5:08 ` Dmitry Torokhov
2020-06-08 11:22 ` [PATCH v4 4/7] ACPI: button: Use input_device_enabled() helper Andrzej Pietrasiewicz
2020-06-25 5:24 ` Dmitry Torokhov
2020-10-05 5:06 ` Dmitry Torokhov
2020-06-08 11:22 ` [PATCH v4 5/7] iio: adc: exynos: Use input_device_enabled() Andrzej Pietrasiewicz
2020-06-10 1:28 ` Michał Mirosław
2020-06-10 7:52 ` [FIXED PATCH " Andrzej Pietrasiewicz
2020-06-08 11:22 ` [PATCH v4 6/7] platform/x86: thinkpad_acpi: " Andrzej Pietrasiewicz
2020-06-08 11:22 ` [PATCH v4 7/7] Input: Add "inhibited" property Andrzej Pietrasiewicz
2020-10-05 18:10 ` Dmitry Torokhov
2020-10-06 13:04 ` Andrzej Pietrasiewicz
2020-10-07 1:11 ` Dmitry Torokhov
2020-10-07 1:12 ` Dmitry Torokhov
2020-12-03 6:26 ` Dmitry Torokhov
2020-06-10 9:49 ` [PATCH v4 0/7] Support inhibiting input devices Hans de Goede
2020-06-10 10:38 ` Rafael J. Wysocki
2020-06-10 13:12 ` Andrzej Pietrasiewicz
2020-06-10 13:21 ` Hans de Goede
2020-06-10 13:41 ` Andrzej Pietrasiewicz
2020-06-12 8:30 ` Hans de Goede
2020-06-12 8:47 ` Andrzej Pietrasiewicz
2020-06-16 17:29 ` [PATCH] Input: document inhibiting Andrzej Pietrasiewicz
2020-06-16 17:38 ` Randy Dunlap
2020-06-17 7:44 ` Hans de Goede
2020-06-17 10:18 ` [PATCH v2] " Andrzej Pietrasiewicz
2020-06-17 10:21 ` Hans de Goede
2020-06-17 16:52 ` Randy Dunlap
2020-12-03 6:27 ` Dmitry Torokhov
2020-06-10 14:01 ` [PATCH v4 0/7] Support inhibiting input devices Rafael J. Wysocki
2020-06-10 13:52 ` Hans de Goede
2020-06-10 18:28 ` Dmitry Torokhov
2020-06-12 8:14 ` Hans de Goede
2020-06-12 8:17 ` Hans de Goede
2020-08-03 14:40 ` Andrzej Pietrasiewicz
2020-06-07 20:24 ` [PATCH v3 " Pavel Machek
2020-06-08 5:37 ` Dmitry Torokhov
2020-06-08 9:28 ` Andrzej Pietrasiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c784a23-eade-eacd-3e67-d344a5758b83@collabora.com \
--to=andrzej.p@collabora$(echo .)com \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=baohua@kernel$(echo .)org \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=fery@cypress$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=hdegoede@redhat$(echo .)com \
--cc=ibm-acpi-devel@lists$(echo .)sourceforge.net \
--cc=ibm-acpi@hmh$(echo .)eng.br \
--cc=jeesw@melfas$(echo .)com \
--cc=jic23@kernel$(echo .)org \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kernel@collabora$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=kgene@kernel$(echo .)org \
--cc=knaack.h@gmx$(echo .)de \
--cc=krzk@kernel$(echo .)org \
--cc=lars@metafoo$(echo .)de \
--cc=ldewangan@nvidia$(echo .)com \
--cc=lenb@kernel$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=michael.hennerich@analog$(echo .)com \
--cc=nick@shmanahar$(echo .)org \
--cc=patches@opensource$(echo .)cirrus.com \
--cc=peter.hutterer@redhat$(echo .)com \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
--cc=pmeerw@pmeerw$(echo .)net \
--cc=rjw@rjwysocki$(echo .)net \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=slemieux.tyco@gmail$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=vz@mleia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox