From: punit.agrawal@arm•com (Punit Agrawal)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] drivers: CCI: Correct use of ! and &
Date: Tue, 29 Jul 2014 12:34:17 +0100 [thread overview]
Message-ID: <9hhvbqg1jra.fsf@arm.com> (raw)
In-Reply-To: <20140723150518.GD27677@arm.com> (Will Deacon's message of "Wed, 23 Jul 2014 16:05:18 +0100")
Hi Arnd,
Will Deacon <will.deacon@arm•com> writes:
> On Wed, Jul 23, 2014 at 04:01:56PM +0100, Punit Agrawal wrote:
>> > diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
>> > index 5a86da9..7af78df 100644
>> > --- a/drivers/bus/arm-cci.c
>> > +++ b/drivers/bus/arm-cci.c
>> > @@ -397,7 +397,8 @@ static irqreturn_t pmu_handle_irq(int irq_num, void *dev)
>> > hw_counter = &event->hw;
>> >
>> > /* Did this counter overflow? */
>> > - if (!pmu_read_register(idx, CCI_PMU_OVRFLW) & CCI_PMU_OVRFLW_FLAG)
>> > + if (!(pmu_read_register(idx, CCI_PMU_OVRFLW) &
>> > + CCI_PMU_OVRFLW_FLAG))
>> > continue;
>>
>>
>> Going back to the manual, this fix looks correct.
>>
>> Acked-by: Punit Agrawal <punit.agrawal@arm•com>
>>
>> Will, would this go via your tree?
>
> Given that you're happy with it, I don't mind which tree it goes in.
> Probably deserves a CC stable on it too.
The CCI PMU patches went via arm-soc. Are you happy to pick this fix with
the Ack and a Cc to stable.
Cheers,
Punit
>
> If you get stuck, put it in rmk's patch system.
>
> Will
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-07-29 11:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140707140538.GA4204@himangi-Dell>
2014-07-23 15:01 ` [PATCH] drivers: CCI: Correct use of ! and & Punit Agrawal
2014-07-23 15:05 ` Will Deacon
2014-07-29 11:34 ` Punit Agrawal [this message]
2014-07-29 16:41 ` Olof Johansson
2014-07-30 10:32 ` Punit Agrawal
2014-07-30 10:37 Punit Agrawal
2014-07-30 19:54 ` Olof Johansson
2014-07-31 6:00 ` Olof Johansson
2014-07-31 15:38 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9hhvbqg1jra.fsf@arm.com \
--to=punit.agrawal@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox