From: punit.agrawal@arm•com (Punit Agrawal)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] drivers: CCI: Correct use of ! and &
Date: Wed, 23 Jul 2014 16:01:56 +0100 [thread overview]
Message-ID: <9hhwqb42k63.fsf@arm.com> (raw)
In-Reply-To: <20140707140538.GA4204@himangi-Dell> (Himangi Saraogi's message of "Mon, 7 Jul 2014 19:35:38 +0530")
Adding alkml and Will
Hi Himangi,
In future it would help if you send the patch to the the maintainers by
running the get_maintainers.pl script on the patch.
Himangi Saraogi <himangi774@gmail•com> writes:
> In commit ae91d60ba88ef0bdb1b5e9b2363bd52fc45d2af7, a bug was fixed that
> involved converting !x & y to !(x & y). The code below shows the same
> pattern, and thus should perhaps be fixed in the same way.
>
> The Coccinelle semantic patch that makes this change is as follows:
>
> // <smpl>
> @@ expression E1,E2; @@
> (
> !E1 & !E2
> |
> - !E1 & E2
> + !(E1 & E2)
> )
> // </smpl>
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail•com>
> Acked-by: Julia Lawall <julia.lawall@lip6•fr>
> ---
> This is not tested and clearly changes the semantics, so it is only
> something to consider.
> drivers/bus/arm-cci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> index 5a86da9..7af78df 100644
> --- a/drivers/bus/arm-cci.c
> +++ b/drivers/bus/arm-cci.c
> @@ -397,7 +397,8 @@ static irqreturn_t pmu_handle_irq(int irq_num, void *dev)
> hw_counter = &event->hw;
>
> /* Did this counter overflow? */
> - if (!pmu_read_register(idx, CCI_PMU_OVRFLW) & CCI_PMU_OVRFLW_FLAG)
> + if (!(pmu_read_register(idx, CCI_PMU_OVRFLW) &
> + CCI_PMU_OVRFLW_FLAG))
> continue;
Going back to the manual, this fix looks correct.
Acked-by: Punit Agrawal <punit.agrawal@arm•com>
Will, would this go via your tree?
>
> pmu_write_register(CCI_PMU_OVRFLW_FLAG, idx, CCI_PMU_OVRFLW);
next parent reply other threads:[~2014-07-23 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140707140538.GA4204@himangi-Dell>
2014-07-23 15:01 ` Punit Agrawal [this message]
2014-07-23 15:05 ` [PATCH] drivers: CCI: Correct use of ! and & Will Deacon
2014-07-29 11:34 ` Punit Agrawal
2014-07-29 16:41 ` Olof Johansson
2014-07-30 10:32 ` Punit Agrawal
2014-07-30 10:37 Punit Agrawal
2014-07-30 19:54 ` Olof Johansson
2014-07-31 6:00 ` Olof Johansson
2014-07-31 15:38 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9hhwqb42k63.fsf@arm.com \
--to=punit.agrawal@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox