Re: [PATCH 6/9] arm64: dts: qcom: sc7280: Update reserved memory map

From: Bjorn Andersson <bjorn.andersson@linaro•org>
To: Sibi Sankar <sibis@codeaurora•org>
Cc: Matthias Kaehlcke <mka@chromium•org>,
	robh+dt@kernel•org, will@kernel•org,
	saiprakash.ranjan@codeaurora•org, ohad@wizery•com,
	agross@kernel•org, mathieu.poirier@linaro•org,
	robin.murphy@arm•com, joro@8bytes•org, p.zabel@pengutronix•de,
	linux-arm-msm@vger•kernel.org, linux-remoteproc@vger•kernel.org,
	devicetree@vger•kernel.org, linux-kernel@vger•kernel.org,
	linux-arm-kernel@lists•infradead.org, evgreen@chromium•org,
	dianders@chromium•org, swboyd@chromium•org
Subject: Re: [PATCH 6/9] arm64: dts: qcom: sc7280: Update reserved memory map
Date: Fri, 30 Jul 2021 13:24:58 -0500	[thread overview]
Message-ID: <YQRD+va2mn9e+QKJ@builder.lan> (raw)
In-Reply-To: <f74c03b939dfd83a1013906e1c771666@codeaurora.org>

On Wed 30 Jun 15:02 CDT 2021, Sibi Sankar wrote:

> On 2021-06-28 23:41, Matthias Kaehlcke wrote:
> > On Fri, Jun 25, 2021 at 01:17:35AM +0530, Sibi Sankar wrote:
> > 
> > > Subject: arm64: dts: qcom: sc7280: Update reserved memory map
> > 
> > That's very vague. Also personally I'm not a fan of patches that touch
> > SoC and board files with a commit message that only mentions the SoC, as
> > is frequently done for IDP boards. Why not split this in (at least) two,
> > one for adding the missing memory regions to the SoC, and one for the
> > IDP.
> > 
> 
> sure will split this up.
> 
> > > Add missing regions and remove unused regions from the reserved memory
> > > map, as described in version 1.
> > 
> > What is this 'version 1'?
> 
> lol, it's the memory map version number
> and it's not entirely internal to qc so
> we have been mentioning them in commit
> messages from older SoCs. I'll just drop
> it when I re-spin the series since it
> doesn't add much value.
> 

Every now and then we run into issues with the reserved-memory layout,
where knowing were the numbers comes from is useful information to have
in order to characterize the issue and come up with a fix.

So including information about where those numbers came from is useful,
even if it's referencing a version of a document that's not public.

Regards,
Bjorn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel