public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse•de>
To: Daniel Palmer <daniel@0x0f•com>
Cc: Linus Walleij <linus.walleij@linaro•org>,
	Masahiro Yamada <yamada.masahiro@socionext•com>,
	Daniel Palmer <daniel@thingy•jp>,
	Benjamin Gaignard <benjamin.gaignard@linaro•org>,
	Sam Ravnborg <sam@ravnborg•org>, Ard Biesheuvel <ardb@kernel•org>,
	Stephan Gerhold <stephan@gerhold•net>,
	Jonathan Corbet <corbet@lwn•net>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel•org>,
	Heiko Stuebner <heiko.stuebner@theobroma-systems•com>,
	Russell King <linux@armlinux•org.uk>,
	Bartosz Golaszewski <bgolaszewski@baylibre•com>,
	linux-arm-kernel@lists•infradead.org,
	Nathan Huckleberry <nhuck15@gmail•com>,
	devicetree@vger•kernel.org, Arnd Bergmann <arnd@arndb•de>,
	allen <allen.chen@ite•com.tw>,
	tim.bird@sony•com, Will Deacon <will@kernel•org>,
	Maxime Ripard <mripard@kernel•org>,
	Lubomir Rintel <lkundrak@v3•sk>, Rob Herring <robh+dt@kernel•org>,
	Gregory Fong <gregory.0xf0@gmail•com>,
	Doug Anderson <armlinux@m•disordat.com>,
	Nathan Chancellor <natechancellor@gmail•com>,
	k@japko•eu, Christian Lamparter <chunkeey@gmail•com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
	Nick Desaulniers <ndesaulniers@google•com>,
	linux-kernel@vger•kernel.org, Mark Brown <broonie@kernel•org>,
	Marc Zyngier <maz@kernel•org>,
	Andrew Morton <akpm@linux-foundation•org>,
	"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH v2 5/5] ARM: mstar: Add dts for 70mai midrive d08
Date: Thu, 11 Jun 2020 15:54:38 +0200	[thread overview]
Message-ID: <a626d8a5-16c2-8f0a-b131-c124c06b0317@suse.de> (raw)
In-Reply-To: <20200610090421.3428945-6-daniel@0x0f.com>

BTW I think the subject convention has been "ARM: dts: ...", with "ARM: 
mstar: ..." more for mach-mstar.

Am 10.06.20 um 11:04 schrieb Daniel Palmer:
> Adds inital support for the 70mai midrive d08 dash camera.
> 
> Signed-off-by: Daniel Palmer <daniel@0x0f•com>
> ---
>   arch/arm/boot/dts/Makefile                    |  3 ++-
>   .../boot/dts/mercury5-ssc8336n-midrive08.dts  | 25 +++++++++++++++++++
>   2 files changed, 27 insertions(+), 1 deletion(-)
>   create mode 100644 arch/arm/boot/dts/mercury5-ssc8336n-midrive08.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 4a5f8075a4f6..35c7ecc52c60 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1344,7 +1344,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += \
>   dtb-$(CONFIG_ARCH_MILBEAUT) += milbeaut-m10v-evb.dtb
>   dtb-$(CONFIG_ARCH_MSTARV7) += \
>   	infinity-msc313-breadbee_crust.dtb \
> -	infinity3-msc313e-breadbee.dtb
> +	infinity3-msc313e-breadbee.dtb \
> +	mercury5-ssc8336n-midrive08.dtb
>   dtb-$(CONFIG_ARCH_ZX) += zx296702-ad1.dtb
>   dtb-$(CONFIG_ARCH_ASPEED) += \
>   	aspeed-ast2500-evb.dtb \
> diff --git a/arch/arm/boot/dts/mercury5-ssc8336n-midrive08.dts b/arch/arm/boot/dts/mercury5-ssc8336n-midrive08.dts
> new file mode 100644
> index 000000000000..4ee50ecf6ab1
> --- /dev/null
> +++ b/arch/arm/boot/dts/mercury5-ssc8336n-midrive08.dts
> @@ -0,0 +1,25 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2019 thingy.jp.
> + * Author: Daniel Palmer <daniel@thingy•jp>
> + */
> +
> +/dts-v1/;
> +#include "mercury5-ssc8336n.dtsi"
> +
> +/ {
> +	model = "midrive d08";

Couldn't find this on their website. Should this be "70mai midrive ..." 
or is "midrive" a different brand?

> +	compatible = "70mai,midrived08", "mstar,mercury5";

Have you considered naming it "70mai,midrive-d08" for better 
readability? (affects 1/5)

> +
> +	aliases {
> +		serial0 = &pm_uart;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +};
> +
> +&pm_uart {
> +	status = "okay";

clock-frequency?

> +};

Regards,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-06-11 13:54 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14  6:15 [PATCH 1/4] dt-bindings: arm: Initial MStar vendor prefixes and compatible strings Daniel Palmer
2019-10-14  6:15 ` [PATCH 2/4] ARM: mstar: Add machine for MStar infinity family SoCs Daniel Palmer
2019-10-14 11:19   ` Arnd Bergmann
2019-10-16 20:32     ` Daniel Palmer
2019-10-17 13:02       ` Arnd Bergmann
2019-10-17 21:15         ` Daniel Palmer
2020-06-10  9:03   ` [PATCH v2 0/5] Initial MStar/Sigmastar ARMv7 SoC support Daniel Palmer
2020-06-12 13:00     ` [PATCH v3 00/12] Initial MStar/Sigmastar Armv7 " Daniel Palmer
2020-06-12 13:00       ` [PATCH v3 01/12] dt-bindings: vendor-prefixes: Add mstar vendor prefix Daniel Palmer
2020-06-16 12:15         ` [PATCH v4 00/12] Initial MStar/Sigmastar ARMv7 SoC support Daniel Palmer
2020-06-16 12:15           ` [PATCH v4 01/12] dt-bindings: vendor-prefixes: Add mstar vendor prefix Daniel Palmer
2020-07-09 23:04             ` Rob Herring
2020-06-16 12:15           ` [PATCH v4 02/12] dt-bindings: vendor-prefixes: Add sstar " Daniel Palmer
2020-07-09 23:04             ` Rob Herring
2020-06-16 12:15           ` [PATCH v4 03/12] dt-bindings: vendor-prefixes: Add 70mai " Daniel Palmer
2020-07-09 23:05             ` Rob Herring
2020-06-16 12:15           ` [PATCH v4 04/12] dt-bindings: vendor-prefixes: Add thingy.jp prefix Daniel Palmer
2020-07-09 23:05             ` Rob Herring
2020-06-16 12:15           ` [PATCH v4 05/12] dt-bindings: arm: Add mstar YAML schema Daniel Palmer
2020-07-09 23:04             ` Rob Herring
2020-06-16 12:15           ` [PATCH v4 06/12] ARM: mstar: Add machine for MStar/Sigmastar Armv7 SoCs Daniel Palmer
2020-06-16 12:15           ` [PATCH v4 07/12] ARM: mstar: Add binding details for mstar,l3bridge Daniel Palmer
2020-07-09 23:06             ` Rob Herring
2020-06-16 12:15           ` [PATCH v4 08/12] ARM: mstar: Add Armv7 base dtsi Daniel Palmer
2020-06-16 12:15           ` [PATCH v4 09/12] ARM: mstar: Add infinity/infinity3 family dtsis Daniel Palmer
2020-06-16 12:15           ` [PATCH v4 10/12] ARM: mstar: Add mercury5 series dtsis Daniel Palmer
2020-06-16 12:15           ` [PATCH v4 11/12] ARM: mstar: Add dts for msc313(e) based BreadBee boards Daniel Palmer
2020-06-16 12:15           ` [PATCH v4 12/12] ARM: mstar: Add dts for 70mai midrive d08 Daniel Palmer
2020-06-12 13:00       ` [PATCH v3 02/12] dt-bindings: vendor-prefixes: Add sstar vendor prefix Daniel Palmer
2020-06-12 13:00       ` [PATCH v3 03/12] dt-bindings: vendor-prefixes: Add 70mai " Daniel Palmer
2020-06-12 13:00       ` [PATCH v3 04/12] dt-bindings: vendor-prefixes: Add thingy.jp prefix Daniel Palmer
2020-06-12 13:00       ` [PATCH v3 05/12] dt-bindings: dt-bindings: arm: Add mstar YAML schema Daniel Palmer
2020-06-12 22:07         ` Rob Herring
2020-06-12 13:00       ` [PATCH v3 06/12] ARM: mstar: Add machine for MStar/Sigmastar Armv7 SoCs Daniel Palmer
2020-06-12 13:00       ` [PATCH v3 07/12] ARM: mstar: Add binding details for mstar,l3bridge Daniel Palmer
2020-06-12 13:00       ` [PATCH v3 08/12] ARM: mstar: Add Armv7 base dtsi Daniel Palmer
2020-06-12 13:00       ` [PATCH v3 09/12] ARM: mstar: Add infinity/infinity3 family dtsis Daniel Palmer
2020-06-12 13:00       ` [PATCH v3 10/12] ARM: mstar: Add mercury5 series dtsis Daniel Palmer
2020-06-12 13:00       ` [PATCH v3 11/12] ARM: mstar: Add dts for msc313(e) based BreadBee boards Daniel Palmer
2020-06-12 13:00       ` [PATCH v3 12/12] ARM: mstar: Add dts for 70mai midrive d08 Daniel Palmer
2020-06-10  9:03   ` [PATCH v2 1/5] dt-bindings: arm: Initial MStar vendor prefixes and compatible strings Daniel Palmer
2020-06-10  9:35     ` Andreas Färber
2020-06-10 10:29       ` Daniel Palmer
2020-06-11 15:00     ` Andreas Färber
2020-06-10  9:04   ` [PATCH v2 2/5] ARM: mstar: Add machine for MStar/Sigmastar infinity/mercury family ARMv7 SoCs Daniel Palmer
2020-06-10  9:43     ` Arnd Bergmann
2020-06-11 12:49     ` Andreas Färber
2020-06-11 13:01       ` Daniel Palmer
2020-06-11 14:27         ` Andreas Färber
2020-06-11 14:58           ` Daniel Palmer
2020-06-11 12:58     ` Andreas Färber
2020-06-11 13:18       ` Daniel Palmer
2020-06-10  9:04   ` [PATCH v2 3/5] ARM: mstar: Add infinity/mercury series dtsi Daniel Palmer
2020-06-10  9:35     ` Marc Zyngier
2020-06-11 13:39     ` Andreas Färber
2020-06-11 14:19       ` Daniel Palmer
2020-06-11 14:39         ` Andreas Färber
2020-06-11 15:07           ` Daniel Palmer
2020-06-10  9:04   ` [PATCH v2 4/5] ARM: mstar: Add dts for msc313(e) based BreadBee boards Daniel Palmer
2020-06-11 13:45     ` Andreas Färber
2020-06-11 14:26       ` Daniel Palmer
2020-06-10  9:04   ` [PATCH v2 5/5] ARM: mstar: Add dts for 70mai midrive d08 Daniel Palmer
2020-06-11 13:54     ` Andreas Färber [this message]
2020-06-11 14:38       ` Daniel Palmer
2019-10-14  6:15 ` [PATCH 3/4] ARM: mstar: Add infinity series dtsi Daniel Palmer
2019-10-14  6:15 ` [PATCH 4/4] ARM: mstar: Add dts for msc313e based BreadBee board Daniel Palmer
2019-10-23 20:02 ` [PATCH 1/4] dt-bindings: arm: Initial MStar vendor prefixes and compatible strings Rob Herring
2019-10-23 22:43   ` Daniel Palmer
2019-10-23 23:45     ` Rob Herring
2019-10-24  1:47       ` Daniel Palmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a626d8a5-16c2-8f0a-b131-c124c06b0317@suse.de \
    --to=afaerber@suse$(echo .)de \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=allen.chen@ite$(echo .)com.tw \
    --cc=ardb@kernel$(echo .)org \
    --cc=armlinux@m$(echo .)disordat.com \
    --cc=arnd@arndb$(echo .)de \
    --cc=benjamin.gaignard@linaro$(echo .)org \
    --cc=bgolaszewski@baylibre$(echo .)com \
    --cc=broonie@kernel$(echo .)org \
    --cc=chunkeey@gmail$(echo .)com \
    --cc=corbet@lwn$(echo .)net \
    --cc=daniel@0x0f$(echo .)com \
    --cc=daniel@thingy$(echo .)jp \
    --cc=davem@davemloft$(echo .)net \
    --cc=devicetree@vger$(echo .)kernel.org \
    --cc=gregkh@linuxfoundation$(echo .)org \
    --cc=gregory.0xf0@gmail$(echo .)com \
    --cc=heiko.stuebner@theobroma-systems$(echo .)com \
    --cc=k@japko$(echo .)eu \
    --cc=linus.walleij@linaro$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux@armlinux$(echo .)org.uk \
    --cc=lkundrak@v3$(echo .)sk \
    --cc=maz@kernel$(echo .)org \
    --cc=mchehab+huawei@kernel$(echo .)org \
    --cc=mripard@kernel$(echo .)org \
    --cc=natechancellor@gmail$(echo .)com \
    --cc=ndesaulniers@google$(echo .)com \
    --cc=nhuck15@gmail$(echo .)com \
    --cc=robh+dt@kernel$(echo .)org \
    --cc=sam@ravnborg$(echo .)org \
    --cc=stephan@gerhold$(echo .)net \
    --cc=tim.bird@sony$(echo .)com \
    --cc=will@kernel$(echo .)org \
    --cc=yamada.masahiro@socionext$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox