From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Andrew Lunn <andrew@lunn•ch>, Jakub Kicinski <kuba@kernel•org>
Cc: Alexandre Torgue <alexandre.torgue@foss•st.com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
linux-arm-kernel@lists•infradead.org,
linux-arm-msm@vger•kernel.org, linux-phy@lists•infradead.org,
linux-stm32@st-md-mailman•stormreply.com,
Mohd Ayaan Anwar <mohd.anwar@oss•qualcomm.com>,
Neil Armstrong <neil.armstrong@linaro•org>,
netdev@vger•kernel.org, Paolo Abeni <pabeni@redhat•com>,
Vinod Koul <vkoul@kernel•org>
Subject: Re: [PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation
Date: Sat, 28 Feb 2026 00:11:29 +0000 [thread overview]
Message-ID: <aaIysVxy-WxbiJz9@shell.armlinux.org.uk> (raw)
In-Reply-To: <aaDSJAc-x2-klvHJ@shell.armlinux.org.uk>
On Thu, Feb 26, 2026 at 11:07:16PM +0000, Russell King (Oracle) wrote:
> This is part 2 of the qcom-ethqos series, part 1 has now been merged.
>
> This part of the series focuses on the generic PHY driver, but these
> changes have dependencies on the ethernet driver, hence why
> it will need to go via net-next. Furthermore, subsequent changes
> depend on these patches.
>
> The underlying ideas here are:
>
> - get rid of the driver using phy_set_speed() with SPEED_1000 and
> SPEED_2500 which makes no sense for an ethernet SerDes due to the
> PCS 8B10B data encoding, which inflates the data rate at the SerDes
> compared to the MAC. This is replaced with phy_set_mode_ext().
> - allow phy_power_on() / phy_set_mode*() to be called in any order.
>
> Mohd has tested this series, but it would be great to get acks/reviews
> from the generic PHY maintainers.
So, PW says "changes requested" - please let me know what changes have
been requested.
The AI review for patch 7 says:
This commit fixes a bug but lacks a Fixes: tag. The commit modifies
behavior introduced in 360000820ae2 ("phy: qcom-sgmii-eth: add
.set_mode() and .validate() methods") by making phy_power_on() call
qcom_dwmac_sgmii_phy_calibrate() to restore the previous setup, and by
making qcom_dwmac_sgmii_phy_set_mode() check if the PHY is powered on
before attempting calibration.
Should this commit include:
Fixes: 360000820ae2 ("phy: qcom-sgmii-eth: add .set_mode() and .validate() methods")
which is _wrong_, this isn't a bug fix.
So, in light of AI review being incorrect, my comment about re-sending
due to the AI review is no longer relevant, and no changes are required.
The only thing that's necessary is to have Vinod's ack added to patches
4, 5, 6 and 7, as he gave them against the very first posting of these
on Wednesday. This is despite waiting the required 24h before sending
the first resend.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-02-28 0:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 23:07 [PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation Russell King (Oracle)
2026-02-26 23:09 ` [PATCH RESEND2 net-next 1/8] net: stmmac: qcom-ethqos: move ethqos_set_serdes_speed() Russell King (Oracle)
2026-02-26 23:09 ` [PATCH RESEND2 net-next 2/8] phy: qcom-sgmii-eth: add .set_mode() and .validate() methods Russell King (Oracle)
2026-02-26 23:09 ` [PATCH RESEND2 net-next 3/8] net: stmmac: qcom-ethqos: convert to use phy_set_mode_ext() Russell King (Oracle)
2026-02-26 23:09 ` [PATCH RESEND2 net-next 4/8] phy: qcom-sgmii-eth: remove .set_speed() implementation Russell King (Oracle)
2026-02-27 15:39 ` Vladimir Oltean
2026-02-26 23:09 ` [PATCH RESEND2 net-next 5/8] phy: qcom-sgmii-eth: use PHY interface mode for SerDes settings Russell King (Oracle)
2026-02-27 15:40 ` Vladimir Oltean
2026-02-26 23:09 ` [PATCH RESEND2 net-next 6/8] phy: qcom-sgmii-eth: remove qcom_dwmac_sgmii_phy_interface() Russell King (Oracle)
2026-02-27 15:42 ` Vladimir Oltean
2026-02-26 23:09 ` [PATCH RESEND2 net-next 7/8] phy: qcom-sgmii-eth: relax order of .power_on() vs .set_mode*() Russell King (Oracle)
2026-02-27 15:37 ` Vladimir Oltean
2026-02-26 23:09 ` [PATCH RESEND2 net-next 8/8] net: stmmac: qcom-ethqos: remove phy_set_mode_ext() after phy_power_on() Russell King (Oracle)
2026-02-27 15:31 ` Vladimir Oltean
2026-02-27 1:26 ` [PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation Jakub Kicinski
2026-02-27 15:48 ` Vladimir Oltean
2026-02-28 0:11 ` Russell King (Oracle) [this message]
2026-02-28 0:55 ` Jakub Kicinski
2026-02-28 16:31 ` Jakub Kicinski
2026-03-01 0:14 ` Vladimir Oltean
2026-03-01 0:32 ` Jakub Kicinski
2026-03-01 12:08 ` Vladimir Oltean
2026-03-02 23:29 ` Jakub Kicinski
2026-03-01 13:42 ` Russell King (Oracle)
2026-03-01 14:10 ` Vladimir Oltean
2026-03-01 13:39 ` Russell King (Oracle)
2026-03-02 23:57 ` Jakub Kicinski
2026-03-09 15:44 ` Vladimir Oltean
2026-03-09 23:51 ` Jakub Kicinski
2026-03-03 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaIysVxy-WxbiJz9@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-phy@lists$(echo .)infradead.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mohd.anwar@oss$(echo .)qualcomm.com \
--cc=neil.armstrong@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=vkoul@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox