From: Nicolin Chen <nicolinc@nvidia•com>
To: Qinxin Xia <xiaqinxin@huawei•com>
Cc: <robin.murphy@arm•com>, <will@kernel•org>, <jpb@kernel•org>,
<linux-arm-kernel@lists•infradead.org>, <iommu@lists•linux.dev>,
<wangzhou1@hisilicon•com>, <prime.zeng@hisilicon•com>,
<fanghao11@huawei•com>, <jonathan.cameron@huawei•com>,
<wuyifan50@huawei•com>, <linuxarm@huawei•com>
Subject: Re: [RFC PATCH v2 2/5] iommu/arm-smmu-v3: Add register display to debugfs
Date: Mon, 30 Mar 2026 04:25:57 -0700 [thread overview]
Message-ID: <acpdxdjFQl1V0b5k@nvidia.com> (raw)
In-Reply-To: <20260328101706.3448655-3-xiaqinxin@huawei.com>
On Sat, Mar 28, 2026 at 06:17:03PM +0800, Qinxin Xia wrote:
> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-debugfs.c
> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-debugfs.c
> @@ -5,13 +5,18 @@
> * Directory Structure:
> * /sys/kernel/debug/iommu/arm_smmu_v3/
> * └── smmu<ioaddr>/
> - * └── capabilities # SMMU feature capabilities and configuration
Nit: perhaps the last line in every patch could start with '|-',
so we wouldn't need to update it every time.
> + * ├── capabilities # SMMU feature capabilities and configuration
> + * └── registers # SMMU Key registers
Maybe replace '\t' with whitespaces? The final file doesn't seem
to have this line properly aligned with others also.
Nicolin
next prev parent reply other threads:[~2026-03-30 11:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 10:17 [RFC PATCH v2 0/5] Add debugfs support for ARM SMMUv3 Qinxin Xia
2026-03-28 10:17 ` [RFC PATCH v2 1/5] iommu/arm-smmu-v3: Add basic debugfs framework Qinxin Xia
2026-03-30 10:46 ` Nicolin Chen
2026-04-02 3:50 ` Qinxin Xia
2026-03-28 10:17 ` [RFC PATCH v2 2/5] iommu/arm-smmu-v3: Add register display to debugfs Qinxin Xia
2026-03-30 11:25 ` Nicolin Chen [this message]
2026-03-28 10:17 ` [RFC PATCH v2 3/5] iommu/arm-smmu-v3: Add Stream Table Entry " Qinxin Xia
2026-04-04 5:43 ` Nicolin Chen
2026-03-28 10:17 ` [RFC PATCH v2 4/5] iommu/arm-smmu-v3: Add device symlink in stream table debugfs Qinxin Xia
2026-03-28 10:17 ` [RFC PATCH v2 5/5] iommu/arm-smmu-v3: Add Context Descriptor display to debugfs Qinxin Xia
2026-05-20 6:37 ` [PATCH 0/5] Add debugfs support for ARM SMMUv3 Qinxin Xia
2026-05-20 6:37 ` [PATCH 1/5] iommu/arm-smmu-v3: Add basic debugfs framework Qinxin Xia
2026-05-27 0:41 ` Nicolin Chen
2026-05-20 6:37 ` [PATCH 2/5] iommu/arm-smmu-v3: Add register display to debugfs Qinxin Xia
2026-05-27 1:28 ` Nicolin Chen
2026-05-20 6:37 ` [PATCH 3/5] iommu/arm-smmu-v3: Add Stream Table Entry " Qinxin Xia
2026-05-27 2:18 ` Nicolin Chen
2026-05-27 2:43 ` Nicolin Chen
2026-05-20 6:37 ` [PATCH 4/5] iommu/arm-smmu-v3: Add device symlink in stream table debugfs Qinxin Xia
2026-05-20 6:37 ` [PATCH 5/5] iommu/arm-smmu-v3: Add Context Descriptor display to debugfs Qinxin Xia
2026-05-27 2:40 ` Nicolin Chen
2026-05-27 0:07 ` [PATCH 0/5] Add debugfs support for ARM SMMUv3 Nicolin Chen
-- strict thread matches above, loose matches on Subject: below --
2026-03-28 10:09 [RFC PATCH v2 " Qinxin Xia
2026-03-28 10:09 ` [RFC PATCH v2 2/5] iommu/arm-smmu-v3: Add register display to debugfs Qinxin Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acpdxdjFQl1V0b5k@nvidia.com \
--to=nicolinc@nvidia$(echo .)com \
--cc=fanghao11@huawei$(echo .)com \
--cc=iommu@lists$(echo .)linux.dev \
--cc=jonathan.cameron@huawei$(echo .)com \
--cc=jpb@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linuxarm@huawei$(echo .)com \
--cc=prime.zeng@hisilicon$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=wangzhou1@hisilicon$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=wuyifan50@huawei$(echo .)com \
--cc=xiaqinxin@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox