From: Andrea della Porta <andrea.porta@suse•com>
To: Krzysztof Kozlowski <krzk@kernel•org>
Cc: "Andrea della Porta" <andrea.porta@suse•com>,
"Uwe Kleine-König" <ukleinek@kernel•org>,
linux-pwm@vger•kernel.org, "Rob Herring" <robh@kernel•org>,
"Krzysztof Kozlowski" <krzk+dt@kernel•org>,
"Conor Dooley" <conor+dt@kernel•org>,
"Florian Fainelli" <florian.fainelli@broadcom•com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom•com>,
devicetree@vger•kernel.org, linux-rpi-kernel@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org,
"Naushir Patuck" <naush@raspberrypi•com>,
"Stanimir Varbanov" <svarbanov@suse•de>
Subject: Re: [PATCH 1/3] dt-bindings: pwm: Add Raspberry Pi RP1 PWM controller
Date: Tue, 7 Apr 2026 10:29:09 +0200 [thread overview]
Message-ID: <adTAVQddjxHgoh9k@apocalypse> (raw)
In-Reply-To: <20260405-enormous-glittering-avocet-285f82@quoll>
Hi Krzysztof,
On 09:52 Sun 05 Apr , Krzysztof Kozlowski wrote:
> On Fri, Apr 03, 2026 at 04:31:54PM +0200, Andrea della Porta wrote:
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > +
>
> Missing ref to pwm.yaml.
The reference to pwm.yaml is at line 13, as follows:
allOf:
- $ref: pwm.yaml#
currently right after the maintainers: block. Are you
suggesting to move it after the required: block?
>
> > +additionalProperties: false
>
> and this should be unevaluatedProperties. See other files.
Ack.
Many thanks,
Andrea
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-04-07 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 14:31 [PATCH 0/3] Add RP1 PWM controller support Andrea della Porta
2026-04-03 14:31 ` [PATCH 1/3] dt-bindings: pwm: Add Raspberry Pi RP1 PWM controller Andrea della Porta
2026-04-05 7:52 ` Krzysztof Kozlowski
2026-04-07 8:29 ` Andrea della Porta [this message]
2026-04-03 14:31 ` [PATCH 2/3] pwm: rp1: Add RP1 PWM controller driver Andrea della Porta
2026-04-05 21:45 ` Uwe Kleine-König
2026-04-09 16:16 ` Andrea della Porta
2026-04-10 6:27 ` Uwe Kleine-König
2026-04-10 10:27 ` Andrea della Porta
2026-04-10 10:47 ` Uwe Kleine-König
2026-04-03 14:31 ` [PATCH 3/3] arm64: dts: broadcom: rp1: Add PWM node Andrea della Porta
2026-04-05 7:53 ` Krzysztof Kozlowski
2026-04-05 21:48 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adTAVQddjxHgoh9k@apocalypse \
--to=andrea.porta@suse$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pwm@vger$(echo .)kernel.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=naush@raspberrypi$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=svarbanov@suse$(echo .)de \
--cc=ukleinek@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox