public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
* [PATCH] ARM: configs: Drop duplicated CONFIG_EXT4_FS
@ 2026-06-03  7:27 Krzysztof Kozlowski
  2026-06-03  8:59 ` Richard Cheng
  0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-03  7:27 UTC (permalink / raw)
  To: Arnd Bergmann, soc, Russell King, Theodore Ts'o,
	linux-arm-kernel, linux-kernel
  Cc: Krzysztof Kozlowski

Remove redundant, duplicated CONFIG_EXT4_FS to fix warnings like:

  axm55xx_defconfig:198:warning: override: reassigning to symbol EXT4_FS

Fixes: c065b6046b34 ("Use CONFIG_EXT4_FS instead of CONFIG_EXT3_FS in all of the defconfigs")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss•qualcomm.com>
---
 arch/arm/configs/axm55xx_defconfig | 1 -
 arch/arm/configs/dove_defconfig    | 1 -
 arch/arm/configs/ep93xx_defconfig  | 1 -
 arch/arm/configs/mmp2_defconfig    | 1 -
 arch/arm/configs/mv78xx0_defconfig | 1 -
 5 files changed, 5 deletions(-)

diff --git a/arch/arm/configs/axm55xx_defconfig b/arch/arm/configs/axm55xx_defconfig
index 22b189090e15..0952e5e94c5e 100644
--- a/arch/arm/configs/axm55xx_defconfig
+++ b/arch/arm/configs/axm55xx_defconfig
@@ -195,7 +195,6 @@ CONFIG_PL320_MBOX=y
 # CONFIG_IOMMU_SUPPORT is not set
 CONFIG_EXT2_FS=y
 CONFIG_EXT4_FS=y
-CONFIG_EXT4_FS=y
 CONFIG_AUTOFS_FS=y
 CONFIG_FUSE_FS=y
 CONFIG_CUSE=y
diff --git a/arch/arm/configs/dove_defconfig b/arch/arm/configs/dove_defconfig
index e98c35df675e..3d978ce34b54 100644
--- a/arch/arm/configs/dove_defconfig
+++ b/arch/arm/configs/dove_defconfig
@@ -97,7 +97,6 @@ CONFIG_MV_XOR=y
 CONFIG_EXT2_FS=y
 CONFIG_EXT4_FS=y
 # CONFIG_EXT4_FS_XATTR is not set
-CONFIG_EXT4_FS=y
 CONFIG_ISO9660_FS=y
 CONFIG_JOLIET=y
 CONFIG_UDF_FS=m
diff --git a/arch/arm/configs/ep93xx_defconfig b/arch/arm/configs/ep93xx_defconfig
index 9f3c7324d1cf..ce41dc8c435c 100644
--- a/arch/arm/configs/ep93xx_defconfig
+++ b/arch/arm/configs/ep93xx_defconfig
@@ -105,7 +105,6 @@ CONFIG_EP93XX_DMA=y
 CONFIG_EXT2_FS=y
 CONFIG_EXT4_FS=y
 # CONFIG_EXT4_FS_XATTR is not set
-CONFIG_EXT4_FS=y
 CONFIG_VFAT_FS=y
 CONFIG_TMPFS=y
 CONFIG_JFFS2_FS=y
diff --git a/arch/arm/configs/mmp2_defconfig b/arch/arm/configs/mmp2_defconfig
index a9a212abfd69..0ea608c75f22 100644
--- a/arch/arm/configs/mmp2_defconfig
+++ b/arch/arm/configs/mmp2_defconfig
@@ -54,7 +54,6 @@ CONFIG_RTC_DRV_MAX8925=y
 # CONFIG_RESET_CONTROLLER is not set
 CONFIG_EXT2_FS=y
 CONFIG_EXT4_FS=y
-CONFIG_EXT4_FS=y
 # CONFIG_DNOTIFY is not set
 CONFIG_MSDOS_FS=y
 CONFIG_FAT_DEFAULT_CODEPAGE=437
diff --git a/arch/arm/configs/mv78xx0_defconfig b/arch/arm/configs/mv78xx0_defconfig
index d3a26efe766c..c6b46141cb69 100644
--- a/arch/arm/configs/mv78xx0_defconfig
+++ b/arch/arm/configs/mv78xx0_defconfig
@@ -93,7 +93,6 @@ CONFIG_RTC_DRV_M41T80=y
 CONFIG_EXT2_FS=y
 CONFIG_EXT4_FS=y
 # CONFIG_EXT4_FS_XATTR is not set
-CONFIG_EXT4_FS=m
 CONFIG_ISO9660_FS=m
 CONFIG_JOLIET=y
 CONFIG_UDF_FS=m
-- 
2.53.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: configs: Drop duplicated CONFIG_EXT4_FS
  2026-06-03  7:27 [PATCH] ARM: configs: Drop duplicated CONFIG_EXT4_FS Krzysztof Kozlowski
@ 2026-06-03  8:59 ` Richard Cheng
  2026-06-03  9:12   ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Cheng @ 2026-06-03  8:59 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Arnd Bergmann, soc, Russell King, Theodore Ts'o,
	linux-arm-kernel, linux-kernel

On Wed, Jun 03, 2026 at 09:27:27AM +0800, Krzysztof Kozlowski wrote:
> Remove redundant, duplicated CONFIG_EXT4_FS to fix warnings like:
> 
>   axm55xx_defconfig:198:warning: override: reassigning to symbol EXT4_FS
> 
> Fixes: c065b6046b34 ("Use CONFIG_EXT4_FS instead of CONFIG_EXT3_FS in all of the defconfigs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss•qualcomm.com>
> ---
>  arch/arm/configs/axm55xx_defconfig | 1 -
>  arch/arm/configs/dove_defconfig    | 1 -
>  arch/arm/configs/ep93xx_defconfig  | 1 -
>  arch/arm/configs/mmp2_defconfig    | 1 -
>  arch/arm/configs/mv78xx0_defconfig | 1 -
>  5 files changed, 5 deletions(-)
> 
> diff --git a/arch/arm/configs/axm55xx_defconfig b/arch/arm/configs/axm55xx_defconfig
> index 22b189090e15..0952e5e94c5e 100644
> --- a/arch/arm/configs/axm55xx_defconfig
> +++ b/arch/arm/configs/axm55xx_defconfig
> @@ -195,7 +195,6 @@ CONFIG_PL320_MBOX=y
>  # CONFIG_IOMMU_SUPPORT is not set
>  CONFIG_EXT2_FS=y
>  CONFIG_EXT4_FS=y
> -CONFIG_EXT4_FS=y
>  CONFIG_AUTOFS_FS=y
>  CONFIG_FUSE_FS=y
>  CONFIG_CUSE=y
> diff --git a/arch/arm/configs/dove_defconfig b/arch/arm/configs/dove_defconfig
> index e98c35df675e..3d978ce34b54 100644
> --- a/arch/arm/configs/dove_defconfig
> +++ b/arch/arm/configs/dove_defconfig
> @@ -97,7 +97,6 @@ CONFIG_MV_XOR=y
>  CONFIG_EXT2_FS=y
>  CONFIG_EXT4_FS=y
>  # CONFIG_EXT4_FS_XATTR is not set
> -CONFIG_EXT4_FS=y
>  CONFIG_ISO9660_FS=y
>  CONFIG_JOLIET=y
>  CONFIG_UDF_FS=m
> diff --git a/arch/arm/configs/ep93xx_defconfig b/arch/arm/configs/ep93xx_defconfig
> index 9f3c7324d1cf..ce41dc8c435c 100644
> --- a/arch/arm/configs/ep93xx_defconfig
> +++ b/arch/arm/configs/ep93xx_defconfig
> @@ -105,7 +105,6 @@ CONFIG_EP93XX_DMA=y
>  CONFIG_EXT2_FS=y
>  CONFIG_EXT4_FS=y
>  # CONFIG_EXT4_FS_XATTR is not set
> -CONFIG_EXT4_FS=y
>  CONFIG_VFAT_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_JFFS2_FS=y
> diff --git a/arch/arm/configs/mmp2_defconfig b/arch/arm/configs/mmp2_defconfig
> index a9a212abfd69..0ea608c75f22 100644
> --- a/arch/arm/configs/mmp2_defconfig
> +++ b/arch/arm/configs/mmp2_defconfig
> @@ -54,7 +54,6 @@ CONFIG_RTC_DRV_MAX8925=y
>  # CONFIG_RESET_CONTROLLER is not set
>  CONFIG_EXT2_FS=y
>  CONFIG_EXT4_FS=y
> -CONFIG_EXT4_FS=y
>  # CONFIG_DNOTIFY is not set
>  CONFIG_MSDOS_FS=y
>  CONFIG_FAT_DEFAULT_CODEPAGE=437
> diff --git a/arch/arm/configs/mv78xx0_defconfig b/arch/arm/configs/mv78xx0_defconfig
> index d3a26efe766c..c6b46141cb69 100644
> --- a/arch/arm/configs/mv78xx0_defconfig
> +++ b/arch/arm/configs/mv78xx0_defconfig
> @@ -93,7 +93,6 @@ CONFIG_RTC_DRV_M41T80=y
>  CONFIG_EXT2_FS=y
>  CONFIG_EXT4_FS=y
>  # CONFIG_EXT4_FS_XATTR is not set
> -CONFIG_EXT4_FS=m
>  CONFIG_ISO9660_FS=m
>  CONFIG_JOLIET=y
>  CONFIG_UDF_FS=m
> -- 
> 2.53.0
> 
>

Hi Krzysztof,

LGTM.
Though I wonder which compiler did you use and how did you encounter
the warning? on what system if you may share with us?

Reviewed-by: Richard Cheng <icheng@nvidia•com>

Best regards,
Richard Cheng. 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: configs: Drop duplicated CONFIG_EXT4_FS
  2026-06-03  8:59 ` Richard Cheng
@ 2026-06-03  9:12   ` Krzysztof Kozlowski
  2026-06-03  9:47     ` Richard Cheng
  0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-03  9:12 UTC (permalink / raw)
  To: Richard Cheng
  Cc: Arnd Bergmann, soc, Russell King, Theodore Ts'o,
	linux-arm-kernel, linux-kernel

On 03/06/2026 10:59, Richard Cheng wrote:

Please kindly trim the replies from unnecessary context. It makes it
much easier to find new content.

>> -- 
>> 2.53.0
>>
>>
> 
> Hi Krzysztof,
> 
> LGTM.
> Though I wonder which compiler did you use and how did you encounter
> the warning? on what system if you may share with us?

I am confused with above questions and it feels like the review might
not be applicable in such case. You do understand this is a defconfig?

> 
> Reviewed-by: Richard Cheng <icheng@nvidia•com>

Best regards,
Krzysztof



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: configs: Drop duplicated CONFIG_EXT4_FS
  2026-06-03  9:12   ` Krzysztof Kozlowski
@ 2026-06-03  9:47     ` Richard Cheng
  0 siblings, 0 replies; 4+ messages in thread
From: Richard Cheng @ 2026-06-03  9:47 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Arnd Bergmann, soc, Russell King, Theodore Ts'o,
	linux-arm-kernel, linux-kernel

On Wed, Jun 03, 2026 at 11:12:45AM +0800, Krzysztof Kozlowski wrote:
> On 03/06/2026 10:59, Richard Cheng wrote:
> 
> Please kindly trim the replies from unnecessary context. It makes it
> much easier to find new content.
>
> >> -- 
> >> 2.53.0
> >>
> >>
> > 
> > Hi Krzysztof,
> > 
> > LGTM.
> > Though I wonder which compiler did you use and how did you encounter
> > the warning? on what system if you may share with us?
> 
> I am confused with above questions and it feels like the review might
> not be applicable in such case. You do understand this is a defconfig?
> 

Hi Krzysztof,

You're right, my mistake. I conflated it with a compiler diagnostic.
The warning comes from Kconfig, so it reproduces on any host that run
the corresponding defconfig, regardless of the toolchain.
The questions don't apply.

Best regards,
Richard Cheng.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-06-03  9:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-03  7:27 [PATCH] ARM: configs: Drop duplicated CONFIG_EXT4_FS Krzysztof Kozlowski
2026-06-03  8:59 ` Richard Cheng
2026-06-03  9:12   ` Krzysztof Kozlowski
2026-06-03  9:47     ` Richard Cheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox