From: Neil Armstrong <narmstrong@baylibre•com>
To: Nishka Dasgupta <nishkadg.linux@gmail•com>,
khilman@baylibre•com, linus.walleij@linaro•org,
linux-arm-kernel@lists•infradead.org, linux-gpio@vger•kernel.org,
linux-amlogic@lists•infradead.org
Subject: Re: [PATCH] pinctrl: meson: meson: Add of_node_put() before return
Date: Wed, 21 Aug 2019 16:24:50 +0200 [thread overview]
Message-ID: <b9f39c19-fe9c-47bd-e785-e7252d8be5bf@baylibre.com> (raw)
In-Reply-To: <20190815060718.3286-1-nishkadg.linux@gmail.com>
On 15/08/2019 08:07, Nishka Dasgupta wrote:
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail•com>
> ---
> drivers/pinctrl/meson/pinctrl-meson.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
> index 596786926209..8bba9d053d9f 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson.c
> @@ -651,6 +651,7 @@ static int meson_pinctrl_parse_dt(struct meson_pinctrl *pc,
> continue;
> if (gpio_np) {
> dev_err(pc->dev, "multiple gpio nodes\n");
> + of_node_put(np);
> return -EINVAL;
> }
> gpio_np = np;
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre•com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-21 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 6:07 [PATCH] pinctrl: meson: meson: Add of_node_put() before return Nishka Dasgupta
2019-08-21 14:24 ` Neil Armstrong [this message]
2019-08-23 9:48 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9f39c19-fe9c-47bd-e785-e7252d8be5bf@baylibre.com \
--to=narmstrong@baylibre$(echo .)com \
--cc=khilman@baylibre$(echo .)com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=nishkadg.linux@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox