From: khilman@baylibre•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] ARM: dts: da850: Add node for pullup/pulldown pinconf
Date: Wed, 23 Nov 2016 14:33:38 -0800 [thread overview]
Message-ID: <m260ndx1vh.fsf@baylibre.com> (raw)
In-Reply-To: <06bc8517-8c33-85a1-9d5a-29042c7281db@lechnology.com> (David Lechner's message of "Wed, 23 Nov 2016 10:24:06 -0600")
David Lechner <david@lechnology•com> writes:
> On 11/23/2016 05:12 AM, Sekhar Nori wrote:
>> On Wednesday 23 November 2016 08:59 AM, David Lechner wrote:
>>> This SoC has a separate pin controller for configuring pullup/pulldown
>>> bias on groups of pins.
>>>
>>> Signed-off-by: David Lechner <david@lechnology•com>
>>> ---
>>> arch/arm/boot/dts/da850.dtsi | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>>> index 8945815..1c0224c 100644
>>> --- a/arch/arm/boot/dts/da850.dtsi
>>> +++ b/arch/arm/boot/dts/da850.dtsi
>>> @@ -210,6 +210,11 @@
>>> };
>>>
>>> };
>>> + pinconf: pin-controller at 22c00c {
>>> + compatible = "ti,da850-pupd";
>>> + reg = <0x22c00c 0x8>;
>>> + status = "disabled";
>>> + };
>>
>> Can you please place this below the i2c1 node. I am trying to keep the
>> nodes sorted by unit address. I know thats broken in many places today,
>> but lets add the new ones where they should eventually end up.
>
> I can do this, but it seems that the predominant sorting pattern here
> is to keep subsystems together (e.g. all i2c are together, all uart
> are together, etc.)
>
> Would a separate patch to sort everything by unit address to get this
> cleaned up be acceptable?
No thanks. That kind of thing is the needless churn that gets us flamed.
Kevin
next prev parent reply other threads:[~2016-11-23 22:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 3:29 [PATCH 0/3] TI DA850/OMAP-L138/AM18x pinconf David Lechner
2016-11-23 3:29 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti, da850-pupd David Lechner
2016-11-23 11:01 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti,da850-pupd Sekhar Nori
2016-11-24 14:04 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti, da850-pupd Linus Walleij
2016-11-28 21:54 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti,da850-pupd Rob Herring
2016-11-23 3:29 ` [PATCH 2/3] pinctrl: New driver for TI DA8XX/OMAP-L138/AM18XX pinconf David Lechner
2016-11-23 11:04 ` Sekhar Nori
2016-11-23 16:21 ` David Lechner
2016-11-24 14:05 ` Linus Walleij
2016-11-23 3:29 ` [PATCH 3/3] ARM: dts: da850: Add node for pullup/pulldown pinconf David Lechner
2016-11-23 11:12 ` Sekhar Nori
2016-11-23 16:24 ` David Lechner
2016-11-23 22:33 ` Kevin Hilman [this message]
2016-11-24 5:54 ` Sekhar Nori
2016-11-23 11:17 ` [PATCH 0/3] TI DA850/OMAP-L138/AM18x pinconf Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m260ndx1vh.fsf@baylibre.com \
--to=khilman@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox