From: Andrzej Pietrasiewicz <andrzej.p@samsung•com>
To: 'Andrew Morton' <akpm@linux-foundation•org>,
'Randy Dunlap' <rdunlap@xenotime•net>
Cc: linux-kernel@vger•kernel.org, devel@driverdev•osuosl.org,
'Greg Kroah-Hartman' <gregkh@linuxfoundation•org>,
linux-next@vger•kernel.org,
'Mike Lockwood' <lockwood@android•com>,
'Felipe Balbi' <balbi@ti•com>,
Marek Szyprowski <m.szyprowski@samsung•com>
Subject: RE: mmotm 2012-07-10-16-59 uploaded (staging/ccg)
Date: Thu, 12 Jul 2012 11:00:13 +0200 [thread overview]
Message-ID: <000001cd600c$c00e0230$402a0690$%p@samsung.com> (raw)
In-Reply-To: <20120711151644.23016bd8.akpm@linux-foundation.org>
Dear Andrew,
On Thursday, July 12, 2012 12:17 AM Andrew Morton wrote:
> On Wed, 11 Jul 2012 15:01:32 -0700
> Randy Dunlap <rdunlap@xenotime•net> wrote:
>
> > In file included from drivers/staging/ccg/ccg.c:59:0:
> > drivers/staging/ccg/../../usb/gadget/f_fs.c:41:0: warning: "pr_vdebug"
> redefined
> > drivers/staging/ccg/../../usb/gadget/u_serial.c:138:0: note: this is the
> location of the previous definition
>
> <looks at drivers/staging/ccg/ccg.c>
<snip>
@Randy:
There is a patch for this:
http://www.spinics.net/lists/linux-usb/msg65344.html
I guess you acked it.
@Feilpe, Greg:
Should I send a pull request?
>
> : /*
> : * Kbuild is not very cooperative with respect to linking separately
> : * compiled library objects into one module. So for now we won't use
> : * separate compilation ... ensuring init/exit sections work to shrink
> : * the runtime footprint, and giving us at least some parts of what
> : * a "gcc --combine ... part1.c part2.c part3.c ... " build would.
> : */
<snip>
> Who wrote that
<snip>
> comment?
<snip>
FYI: The text was taken from Gadget Zero (zero.c) and was originally
written by David Brownell, may he Rest in Peace.
I think that the #include approach is intended to be revised sometime:
http://marc.info/?l=linux-usb&m=132431126927355&w=2 - if there is
just one gadget module configurable through configfs, the things will
probably be simplified.
AP
next prev parent reply other threads:[~2012-07-12 9:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 0:01 mmotm 2012-07-10-16-59 uploaded akpm
2012-07-11 6:38 ` Artem Bityutskiy
2012-07-11 7:44 ` Andrew Morton
2012-07-11 7:53 ` Artem Bityutskiy
2012-07-11 7:59 ` Andrew Morton
2012-07-11 8:08 ` Artem Bityutskiy
2012-07-11 8:15 ` Andrew Morton
2012-07-11 9:09 ` Johannes Weiner
2012-07-11 9:09 ` Johannes Weiner
2012-07-11 9:09 ` Johannes Weiner
2012-07-11 10:34 ` Michal Hocko
2012-07-11 22:01 ` mmotm 2012-07-10-16-59 uploaded (staging/ccg) Randy Dunlap
2012-07-11 22:16 ` Andrew Morton
2012-07-11 23:38 ` Nicholas A. Bellinger
2012-07-11 23:57 ` Andrew Morton
2012-07-12 9:00 ` Andrzej Pietrasiewicz [this message]
2012-07-12 14:46 ` Randy Dunlap
2012-07-12 15:23 ` 'Greg Kroah-Hartman'
2012-07-13 11:42 ` mmotm 2012-07-10-16-59 uploaded S, Venkatraman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cd600c$c00e0230$402a0690$%p@samsung.com' \
--to=andrzej.p@samsung$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=balbi@ti$(echo .)com \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=lockwood@android$(echo .)com \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=rdunlap@xenotime$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox